{"thread":{"id":"48060","subject":"[PATCH] format-patch: use --compact-summary instead of --summary","startedAt":"2018-03-16T20:08:10Z","lastAt":"2018-03-17T08:09:20Z","messageCount":3,"participants":["Nguyễn Thái Ngọc Duy","Junio C Hamano","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"341920","messageId":"20180316200648.18256-1-pclouds@gmail.com","threadId":"48060","inReplyTo":null,"subject":"[PATCH] format-patch: use --compact-summary instead of --summary","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2018-03-16T20:06:48Z","receivedAt":"2018-03-16T20:08:10Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"For reviewers, a couple fewer lines from diffstat (either cover letter\nor patches) is a good thing because there's less to read.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n I realize that rename percentage is lost with this change. I just\n hope that nobody cares about that, or I'll have to implement rename\n percentage in --compact-summary too in order to move this patch\n forward.\n\n builtin/log.c                                 |  9 +++++---\n ...tach_--stdout_--suffix=.diff_initial..side |  7 +++---\n ...at-patch_--attach_--stdout_initial..master | 19 +++++++---------\n ...t-patch_--attach_--stdout_initial..master^ | 12 +++++-----\n ...rmat-patch_--attach_--stdout_initial..side |  7 +++---\n ..._--stdout_--numbered-files_initial..master | 19 +++++++---------\n ..._--subject-prefix=TESTCASE_initial..master | 19 +++++++---------\n ...at-patch_--inline_--stdout_initial..master | 19 +++++++---------\n ...t-patch_--inline_--stdout_initial..master^ | 12 +++++-----\n ...-patch_--inline_--stdout_initial..master^^ |  7 +++---\n ...rmat-patch_--inline_--stdout_initial..side |  7 +++---\n ...-stdout_--cover-letter_-n_initial..master^ | 22 ++++++++-----------\n ...tch_--stdout_--no-numbered_initial..master | 19 +++++++---------\n ...-patch_--stdout_--numbered_initial..master | 19 +++++++---------\n ...diff.format-patch_--stdout_initial..master | 19 +++++++---------\n ...iff.format-patch_--stdout_initial..master^ | 12 +++++-----\n .../diff.format-patch_--stdout_initial..side  |  7 +++---\n t/t4052-stat-output.sh                        |  4 ++--\n 18 files changed, 103 insertions(+), 136 deletions(-)\n\ndiff --git a/builtin/log.c b/builtin/log.c\nindex 94ee177d56..c8e3be5de7 100644\n--- a/builtin/log.c\n+++ b/builtin/log.c\n@@ -1062,7 +1062,8 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,\n \t\treturn;\n \n \tmemcpy(&opts, &rev->diffopt, sizeof(opts));\n-\topts.output_format = DIFF_FORMAT_SUMMARY | DIFF_FORMAT_DIFFSTAT;\n+\topts.output_format = DIFF_FORMAT_DIFFSTAT;\n+\topts.flags.stat_with_summary = 1;\n \topts.stat_width = MAIL_DEFAULT_WRAP;\n \n \tdiff_setup_done(&opts);\n@@ -1615,8 +1616,10 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)\n \n \tif (!use_patch_format &&\n \t\t(!rev.diffopt.output_format ||\n-\t\t rev.diffopt.output_format == DIFF_FORMAT_PATCH))\n-\t\trev.diffopt.output_format = DIFF_FORMAT_DIFFSTAT | DIFF_FORMAT_SUMMARY;\n+\t\t rev.diffopt.output_format == DIFF_FORMAT_PATCH)) {\n+\t\trev.diffopt.output_format = DIFF_FORMAT_DIFFSTAT;\n+\t\trev.diffopt.flags.stat_with_summary = 1;\n+\t}\n \tif (!rev.diffopt.stat_width)\n \t\trev.diffopt.stat_width = MAIL_DEFAULT_WRAP;\n \ndiff --git a/t/t4013/diff.format-patch_--attach_--stdout_--suffix=.diff_initial..side b/t/t4013/diff.format-patch_--attach_--stdout_--suffix=.diff_initial..side\nindex 547ca065a5..89ab87fb4e 100644\n--- a/t/t4013/diff.format-patch_--attach_--stdout_--suffix=.diff_initial..side\n+++ b/t/t4013/diff.format-patch_--attach_--stdout_--suffix=.diff_initial..side\n@@ -12,11 +12,10 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--attach_--stdout_initial..master b/t/t4013/diff.format-patch_--attach_--stdout_initial..master\nindex 52fedc179e..48f284f1d9 100644\n--- a/t/t4013/diff.format-patch_--attach_--stdout_initial..master\n+++ b/t/t4013/diff.format-patch_--attach_--stdout_initial..master\n@@ -14,11 +14,10 @@ Content-Transfer-Encoding: 8bit\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -73,10 +72,9 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -121,11 +119,10 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--attach_--stdout_initial..master^ b/t/t4013/diff.format-patch_--attach_--stdout_initial..master^\nindex 1c3cde251b..be6de1290a 100644\n--- a/t/t4013/diff.format-patch_--attach_--stdout_initial..master^\n+++ b/t/t4013/diff.format-patch_--attach_--stdout_initial..master^\n@@ -14,11 +14,10 @@ Content-Transfer-Encoding: 8bit\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -73,10 +72,9 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--attach_--stdout_initial..side b/t/t4013/diff.format-patch_--attach_--stdout_initial..side\nindex 4717bd8313..c14f4c9011 100644\n--- a/t/t4013/diff.format-patch_--attach_--stdout_initial..side\n+++ b/t/t4013/diff.format-patch_--attach_--stdout_initial..side\n@@ -12,11 +12,10 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--inline_--stdout_--numbered-files_initial..master b/t/t4013/diff.format-patch_--inline_--stdout_--numbered-files_initial..master\nindex 02c4db7ec5..d763a0b437 100644\n--- a/t/t4013/diff.format-patch_--inline_--stdout_--numbered-files_initial..master\n+++ b/t/t4013/diff.format-patch_--inline_--stdout_--numbered-files_initial..master\n@@ -14,11 +14,10 @@ Content-Transfer-Encoding: 8bit\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -73,10 +72,9 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -121,11 +119,10 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--inline_--stdout_--subject-prefix=TESTCASE_initial..master b/t/t4013/diff.format-patch_--inline_--stdout_--subject-prefix=TESTCASE_initial..master\nindex c7677c5951..441a7d8a9d 100644\n--- a/t/t4013/diff.format-patch_--inline_--stdout_--subject-prefix=TESTCASE_initial..master\n+++ b/t/t4013/diff.format-patch_--inline_--stdout_--subject-prefix=TESTCASE_initial..master\n@@ -14,11 +14,10 @@ Content-Transfer-Encoding: 8bit\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -73,10 +72,9 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -121,11 +119,10 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--inline_--stdout_initial..master b/t/t4013/diff.format-patch_--inline_--stdout_initial..master\nindex 5b3e34e2c0..0eb5b3aa3b 100644\n--- a/t/t4013/diff.format-patch_--inline_--stdout_initial..master\n+++ b/t/t4013/diff.format-patch_--inline_--stdout_initial..master\n@@ -14,11 +14,10 @@ Content-Transfer-Encoding: 8bit\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -73,10 +72,9 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -121,11 +119,10 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--inline_--stdout_initial..master^ b/t/t4013/diff.format-patch_--inline_--stdout_initial..master^\nindex d13f8a8128..2d019707e2 100644\n--- a/t/t4013/diff.format-patch_--inline_--stdout_initial..master^\n+++ b/t/t4013/diff.format-patch_--inline_--stdout_initial..master^\n@@ -14,11 +14,10 @@ Content-Transfer-Encoding: 8bit\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n \n --------------g-i-t--v-e-r-s-i-o-n\n@@ -73,10 +72,9 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--inline_--stdout_initial..master^^ b/t/t4013/diff.format-patch_--inline_--stdout_initial..master^^\nindex caec5537de..1aa57f21d6 100644\n--- a/t/t4013/diff.format-patch_--inline_--stdout_initial..master^^\n+++ b/t/t4013/diff.format-patch_--inline_--stdout_initial..master^^\n@@ -14,11 +14,10 @@ Content-Transfer-Encoding: 8bit\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--inline_--stdout_initial..side b/t/t4013/diff.format-patch_--inline_--stdout_initial..side\nindex d3a6762130..844b348eee 100644\n--- a/t/t4013/diff.format-patch_--inline_--stdout_initial..side\n+++ b/t/t4013/diff.format-patch_--inline_--stdout_initial..side\n@@ -12,11 +12,10 @@ Content-Type: text/plain; charset=UTF-8; format=fixed\n Content-Transfer-Encoding: 8bit\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n \n --------------g-i-t--v-e-r-s-i-o-n\ndiff --git a/t/t4013/diff.format-patch_--stdout_--cover-letter_-n_initial..master^ b/t/t4013/diff.format-patch_--stdout_--cover-letter_-n_initial..master^\nindex 244d964fc6..9f4525a60d 100644\n--- a/t/t4013/diff.format-patch_--stdout_--cover-letter_-n_initial..master^\n+++ b/t/t4013/diff.format-patch_--stdout_--cover-letter_-n_initial..master^\n@@ -10,13 +10,11 @@ A U Thor (2):\n   Second\n   Third\n \n- dir/sub | 4 ++++\n- file0   | 3 +++\n- file1   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 4 ++++\n+ file0        | 3 +++\n+ file1 (new)  | 3 +++\n+ file2 (gone) | 3 ---\n  4 files changed, 10 insertions(+), 3 deletions(-)\n- create mode 100644 file1\n- delete mode 100644 file2\n \n -- \n g-i-t--v-e-r-s-i-o-n\n@@ -28,11 +26,10 @@ Subject: [DIFFERENT_PREFIX 1/2] Second\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..8422d40 100644\n@@ -73,10 +70,9 @@ Date: Mon, 26 Jun 2006 00:02:00 +0000\n Subject: [DIFFERENT_PREFIX 2/2] Third\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n diff --git a/dir/sub b/dir/sub\n index 8422d40..cead32e 100644\ndiff --git a/t/t4013/diff.format-patch_--stdout_--no-numbered_initial..master b/t/t4013/diff.format-patch_--stdout_--no-numbered_initial..master\nindex bfc287a147..c102104f70 100644\n--- a/t/t4013/diff.format-patch_--stdout_--no-numbered_initial..master\n+++ b/t/t4013/diff.format-patch_--stdout_--no-numbered_initial..master\n@@ -6,11 +6,10 @@ Subject: [PATCH] Second\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..8422d40 100644\n@@ -51,10 +50,9 @@ Date: Mon, 26 Jun 2006 00:02:00 +0000\n Subject: [PATCH] Third\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n diff --git a/dir/sub b/dir/sub\n index 8422d40..cead32e 100644\n@@ -85,11 +83,10 @@ Date: Mon, 26 Jun 2006 00:03:00 +0000\n Subject: [PATCH] Side\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..7289e35 100644\ndiff --git a/t/t4013/diff.format-patch_--stdout_--numbered_initial..master b/t/t4013/diff.format-patch_--stdout_--numbered_initial..master\nindex 568f6f584e..f29efe555e 100644\n--- a/t/t4013/diff.format-patch_--stdout_--numbered_initial..master\n+++ b/t/t4013/diff.format-patch_--stdout_--numbered_initial..master\n@@ -6,11 +6,10 @@ Subject: [PATCH 1/3] Second\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..8422d40 100644\n@@ -51,10 +50,9 @@ Date: Mon, 26 Jun 2006 00:02:00 +0000\n Subject: [PATCH 2/3] Third\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n diff --git a/dir/sub b/dir/sub\n index 8422d40..cead32e 100644\n@@ -85,11 +83,10 @@ Date: Mon, 26 Jun 2006 00:03:00 +0000\n Subject: [PATCH 3/3] Side\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..7289e35 100644\ndiff --git a/t/t4013/diff.format-patch_--stdout_initial..master b/t/t4013/diff.format-patch_--stdout_initial..master\nindex 5f0352f9f7..febe8c4390 100644\n--- a/t/t4013/diff.format-patch_--stdout_initial..master\n+++ b/t/t4013/diff.format-patch_--stdout_initial..master\n@@ -6,11 +6,10 @@ Subject: [PATCH 1/3] Second\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..8422d40 100644\n@@ -51,10 +50,9 @@ Date: Mon, 26 Jun 2006 00:02:00 +0000\n Subject: [PATCH 2/3] Third\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n diff --git a/dir/sub b/dir/sub\n index 8422d40..cead32e 100644\n@@ -85,11 +83,10 @@ Date: Mon, 26 Jun 2006 00:03:00 +0000\n Subject: [PATCH 3/3] Side\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..7289e35 100644\ndiff --git a/t/t4013/diff.format-patch_--stdout_initial..master^ b/t/t4013/diff.format-patch_--stdout_initial..master^\nindex 2ae454d807..ade0790a44 100644\n--- a/t/t4013/diff.format-patch_--stdout_initial..master^\n+++ b/t/t4013/diff.format-patch_--stdout_initial..master^\n@@ -6,11 +6,10 @@ Subject: [PATCH 1/2] Second\n \n This is the second commit.\n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file2   | 3 ---\n+ dir/sub      | 2 ++\n+ file0        | 3 +++\n+ file2 (gone) | 3 ---\n  3 files changed, 5 insertions(+), 3 deletions(-)\n- delete mode 100644 file2\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..8422d40 100644\n@@ -51,10 +50,9 @@ Date: Mon, 26 Jun 2006 00:02:00 +0000\n Subject: [PATCH 2/2] Third\n \n ---\n- dir/sub | 2 ++\n- file1   | 3 +++\n+ dir/sub     | 2 ++\n+ file1 (new) | 3 +++\n  2 files changed, 5 insertions(+)\n- create mode 100644 file1\n \n diff --git a/dir/sub b/dir/sub\n index 8422d40..cead32e 100644\ndiff --git a/t/t4013/diff.format-patch_--stdout_initial..side b/t/t4013/diff.format-patch_--stdout_initial..side\nindex a7d52fbeea..59db45454b 100644\n--- a/t/t4013/diff.format-patch_--stdout_initial..side\n+++ b/t/t4013/diff.format-patch_--stdout_initial..side\n@@ -5,11 +5,10 @@ Date: Mon, 26 Jun 2006 00:03:00 +0000\n Subject: [PATCH] Side\n \n ---\n- dir/sub | 2 ++\n- file0   | 3 +++\n- file3   | 4 ++++\n+ dir/sub     | 2 ++\n+ file0       | 3 +++\n+ file3 (new) | 4 ++++\n  3 files changed, 9 insertions(+)\n- create mode 100644 file3\n \n diff --git a/dir/sub b/dir/sub\n index 35d242b..7289e35 100644\ndiff --git a/t/t4052-stat-output.sh b/t/t4052-stat-output.sh\nindex 6e2cf933f7..acea4c0b76 100755\n--- a/t/t4052-stat-output.sh\n+++ b/t/t4052-stat-output.sh\n@@ -267,10 +267,10 @@ log -1 --stat\n EOF\n \n cat >expect72 <<'EOF'\n- ...aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa | 1000 +++++++++++++++++\n+ ...aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa (new) | 1000 +++++++++++++++++\n EOF\n cat >expect72-graph <<'EOF'\n-|  ...aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa | 1000 +++++++++++++++++\n+|  ...aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa (new) | 1000 +++++++++++++++++\n EOF\n cat >expect200 <<'EOF'\n  aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa | 1000 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n-- \n2.16.2.903.gd04caf5039\n\n"},{"id":"341952","messageId":"xmqqlgerzojl.fsf@gitster-ct.c.googlers.com","threadId":"48060","inReplyTo":"20180316200648.18256-1-pclouds@gmail.com","subject":"Re: [PATCH] format-patch: use --compact-summary instead of --summary","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-03-16T21:41:18Z","receivedAt":"2018-03-16T21:41:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:\n\n> For reviewers, a couple fewer lines from diffstat (either cover letter\n> or patches) is a good thing because there's less to read.\n\nI can certainly accept that there may be some reviewers who share\nthat view, but me personally, I would rather have them outside the\nmain diffstat section, so addition and removal of files that are\nrarer events do stand out.\n\nI guess people would not mind an option to use it, but they can\nalready say \"git format-patch --compact-summary $upstream..\", so...\n\n\n"},{"id":"342011","messageId":"CACsJy8DBDqin3xYk70A2HxrZ6AYJhd0V5dj98Ni+j8t0vdNGyQ@mail.gmail.com","threadId":"48060","inReplyTo":"xmqqlgerzojl.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] format-patch: use --compact-summary instead of --summary","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-03-17T08:08:35Z","receivedAt":"2018-03-17T08:09:20Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Fri, Mar 16, 2018 at 10:41 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:\n>\n>> For reviewers, a couple fewer lines from diffstat (either cover letter\n>> or patches) is a good thing because there's less to read.\n>\n> I can certainly accept that there may be some reviewers who share\n> that view, but me personally, I would rather have them outside the\n> main diffstat section, so addition and removal of files that are\n> rarer events do stand out.\n>\n> I guess people would not mind an option to use it, but they can\n> already say \"git format-patch --compact-summary $upstream..\", so...\n\nGood point. I can't negate --summary though. But that calls for another patch.\n-- \nDuy\n"}]}