{"thread":{"id":"4803","subject":"[PATH] sed -e '/RE/r rfile/' needs space in 'r rfile'","startedAt":"2006-07-08T15:27:10Z","lastAt":"2006-07-08T18:57:43Z","messageCount":4,"participants":["Michal Rokos","Johannes Schindelin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"23415","messageId":"200607081727.10837.michal.rokos@nextsoft.cz","threadId":"4803","inReplyTo":null,"subject":"[PATH] sed -e '/RE/r rfile/' needs space in 'r rfile'","fromName":"Michal Rokos","fromEmail":"michal.rokos@nextsoft.cz","sentAt":"2006-07-08T15:27:10Z","receivedAt":"2006-07-08T15:27:10Z","isPatch":false,"sender":{"key":"michal.rokos@nextsoft.cz","avatar":null},"body":"Johannes,\n\nin commit 07002287f3e219a16a948a8a6eca0a41162a491f\nyou cleaned up 'replace ugly and unportable sed invocation' as you said.\nPlease note, that some SEDs (like HP-UX one) mandate a space between 'r' \nand 'rfile'.\n\nMichal\n\nSigned-off-by: Michal Rokos <michal.rokos@nextsoft.cz>\n\ndiff --git a/Makefile b/Makefile\nindex 202f261..8f9881f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -552,9 +553,9 @@ git-instaweb: git-instaweb.sh gitweb/git\n \t    -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \\\n \t    -e 's/@@NO_CURL@@/$(NO_CURL)/g' \\\n \t    -e 's/@@NO_PYTHON@@/$(NO_PYTHON)/g' \\\n-\t    -e '/@@GITWEB_CGI@@/rgitweb/gitweb.cgi' \\\n+\t    -e '/@@GITWEB_CGI@@/r gitweb/gitweb.cgi' \\\n \t    -e '/@@GITWEB_CGI@@/d' \\\n-\t    -e '/@@GITWEB_CSS@@/rgitweb/gitweb.css' \\\n+\t    -e '/@@GITWEB_CSS@@/r gitweb/gitweb.css' \\\n \t    -e '/@@GITWEB_CSS@@/d' \\\n \t    $@.sh > $@+\n \tchmod +x $@+\n\n-- \nMichal Rokos\n\nNextSoft s.r.o.\nVyskočilova 1/1410\n140 21 Praha 4\nphone:  +420 267 224 311\nfax:    +420 267 224 307\nmobile: +420 736 646 591\ne-mail: michal.rokos@nextsoft.cz\n"},{"id":"23419","messageId":"Pine.LNX.4.63.0607081844580.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4803","inReplyTo":"200607081727.10837.michal.rokos@nextsoft.cz","subject":"Re: [PATH] sed -e '/RE/r rfile/' needs space in 'r rfile'","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-08T16:47:24Z","receivedAt":"2006-07-08T16:47:24Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 8 Jul 2006, Michal Rokos wrote:\n\n> Johannes,\n\nCould you Cc me next time you address me personally? There are times when \nI am too busy to read all the mails of all the lists, and your mail would \nhave been not read by me at those occasions.\n\n> in commit 07002287f3e219a16a948a8a6eca0a41162a491f\n> you cleaned up 'replace ugly and unportable sed invocation' as you said.\n> Please note, that some SEDs (like HP-UX one) mandate a space between 'r' \n> and 'rfile'.\n\nAck. Note that this is yet-another-reason to step away from scripts.\n\nCiao,\nDscho\n"},{"id":"23420","messageId":"7v7j2oq7h3.fsf@assigned-by-dhcp.cox.net","threadId":"4803","inReplyTo":"Pine.LNX.4.63.0607081844580.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATH] sed -e '/RE/r rfile/' needs space in 'r rfile'","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-07-08T18:25:44Z","receivedAt":"2006-07-08T18:25:44Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n>> in commit 07002287f3e219a16a948a8a6eca0a41162a491f\n>> you cleaned up 'replace ugly and unportable sed invocation' as you said.\n>> Please note, that some SEDs (like HP-UX one) mandate a space between 'r' \n>> and 'rfile'.\n>\n> Ack. Note that this is yet-another-reason to step away from scripts.\n\nAre you talking about doing this part in the Makefile in C ;-)?\n"},{"id":"23425","messageId":"Pine.LNX.4.63.0607082055360.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4803","inReplyTo":"7v7j2oq7h3.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATH] sed -e '/RE/r rfile/' needs space in 'r rfile'","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-08T18:57:43Z","receivedAt":"2006-07-08T18:57:43Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 8 Jul 2006, Junio C Hamano wrote:\n\n> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n> \n> >> in commit 07002287f3e219a16a948a8a6eca0a41162a491f\n> >> you cleaned up 'replace ugly and unportable sed invocation' as you said.\n> >> Please note, that some SEDs (like HP-UX one) mandate a space between 'r' \n> >> and 'rfile'.\n> >\n> > Ack. Note that this is yet-another-reason to step away from scripts.\n> \n> Are you talking about doing this part in the Makefile in C ;-)?\n\nIf it is not portable, then yes ;-)\n\nBut of course, you know the spirit this was written in: I had no way to \ntest with sed on HP-UX, so I do not know if my change works there. \nHowever, I know that if it is C -- except for bugs in HP-UX's C compiler \n-- then it works on HP-UX as expected.\n\nCiao,\nDscho\n"}]}