{"thread":{"id":"48011","subject":"recent glob expansion breakage on Windows?","startedAt":"2018-03-08T21:02:34Z","lastAt":"2018-03-13T23:12:30Z","messageCount":4,"participants":["Laszlo Ersek","Jonathan Nieder","Carsey, Jaben"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"341315","messageId":"e0ba9fb9-056e-4979-415b-f8eca47e2490@redhat.com","threadId":"48011","inReplyTo":null,"subject":"recent glob expansion breakage on Windows?","fromName":"Laszlo Ersek","fromEmail":"lersek@redhat.com","sentAt":"2018-03-08T21:02:15Z","receivedAt":"2018-03-08T21:02:34Z","isPatch":false,"sender":{"key":"lersek@redhat.com","avatar":null},"body":"Hi,\n\nJaben reports that git-send-email is suddenly failing to expand the\n\"*.patch\" glob for him, at the Windows CMD prompt:\n\n---------\nE:\\...>git send-email --suppress-cc=author --suppress-cc=self\n--suppress-cc=cc --suppress-cc=sob --dry-run *.patch\n\nNo patch files specified!\n---------\n\nWhereas, moving the same patch files to another subdir, and then passing\nthe subdir to git-send-email, works fine.\n\nI seem to have found some $^O based perl code in the git tree that\nexpands the glob manually (in place of the shell) on Windows -- however,\nthat code looks ancient ^W very stable, and doesn't seem to explain the\nsudden breakage.\n\nIs it possible that a separate perl update on Jaben's Windows box is\ncausing this? Or does the breakage look consistent with a recent git change?\n\nHas anyone else reported something similar recently?\n\nThanks (and sorry about the noise; this list might not be the best place\nto ask)!\nLaszlo\n"},{"id":"341318","messageId":"20180308220356.GA171451@aiede.svl.corp.google.com","threadId":"48011","inReplyTo":"e0ba9fb9-056e-4979-415b-f8eca47e2490@redhat.com","subject":"Re: recent glob expansion breakage on Windows?","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-03-08T22:03:56Z","receivedAt":"2018-03-08T22:04:31Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"+git-for-windows\nHi,\n\nLaszlo Ersek wrote:\n\n> Jaben reports that git-send-email is suddenly failing to expand the\n> \"*.patch\" glob for him, at the Windows CMD prompt:\n>\n> ---------\n> E:\\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-cc=cc --suppress-cc=sob --dry-run *.patch\n>\n> No patch files specified!\n> ---------\n>\n> Whereas, moving the same patch files to another subdir, and then passing\n> the subdir to git-send-email, works fine.\n>\n> I seem to have found some $^O based perl code in the git tree that\n> expands the glob manually (in place of the shell) on Windows -- however,\n> that code looks ancient ^W very stable, and doesn't seem to explain the\n> sudden breakage.\n>\n> Is it possible that a separate perl update on Jaben's Windows box is\n> causing this? Or does the breakage look consistent with a recent git change?\n>\n> Has anyone else reported something similar recently?\n\nThis reminds me of https://github.com/git-for-windows/git/issues/339.\nThere, Johannes Schindelin writes (about a different command):\n\n| This is expected because neither PowerShell nor cmd.exe nor git.exe\n| expand wildcards. Those examples you found were written with a shell\n| in mind, and the shell expands wildcards (hence Git does not think\n| it needs to).\n\nThat may or may not also apply to send-email.  In what version did it\nwork?\n\nThanks,\nJonathan\n\n> Thanks (and sorry about the noise; this list might not be the best place\n> to ask)!\n> Laszlo\n"},{"id":"341333","messageId":"3f8076fa-ead3-4034-2d41-364b72169873@redhat.com","threadId":"48011","inReplyTo":"20180308220356.GA171451@aiede.svl.corp.google.com","subject":"Re: recent glob expansion breakage on Windows?","fromName":"Laszlo Ersek","fromEmail":"lersek@redhat.com","sentAt":"2018-03-09T09:41:50Z","receivedAt":"2018-03-09T09:42:00Z","isPatch":false,"sender":{"key":"lersek@redhat.com","avatar":null},"body":"On 03/08/18 23:03, Jonathan Nieder wrote:\n> +git-for-windows\n> Hi,\n> \n> Laszlo Ersek wrote:\n> \n>> Jaben reports that git-send-email is suddenly failing to expand the\n>> \"*.patch\" glob for him, at the Windows CMD prompt:\n>>\n>> ---------\n>> E:\\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-cc=cc --suppress-cc=sob --dry-run *.patch\n>>\n>> No patch files specified!\n>> ---------\n>>\n>> Whereas, moving the same patch files to another subdir, and then passing\n>> the subdir to git-send-email, works fine.\n>>\n>> I seem to have found some $^O based perl code in the git tree that\n>> expands the glob manually (in place of the shell) on Windows -- however,\n>> that code looks ancient ^W very stable, and doesn't seem to explain the\n>> sudden breakage.\n>>\n>> Is it possible that a separate perl update on Jaben's Windows box is\n>> causing this? Or does the breakage look consistent with a recent git change?\n>>\n>> Has anyone else reported something similar recently?\n> \n> This reminds me of https://github.com/git-for-windows/git/issues/339.\n> There, Johannes Schindelin writes (about a different command):\n> \n> | This is expected because neither PowerShell nor cmd.exe nor git.exe\n> | expand wildcards. Those examples you found were written with a shell\n> | in mind, and the shell expands wildcards (hence Git does not think\n> | it needs to).\n> \n> That may or may not also apply to send-email.\n\nThank you for the reference -- I can't say whether closing issue #339 as\nWONTFIX was justified or not, but it certainly seems inconsistent with\nJaben's earlier experience (to my understanding), i.e. that git did\nexpand the glob.\n\n> In what version did it work?\n\nJaben, can you please answer that? (One version in which it is broken is\n2.14.1.windows.1.) Can you perhaps ask your teammates about their\ngit/windows versions (assuming the *.patch glob is expanded correctly\nfor them)?\n\nThank you, Jonathan,\nLaszlo\n"},{"id":"341604","messageId":"CB6E33457884FA40993F35157061515CA3C8FC64@FMSMSX103.amr.corp.intel.com","threadId":"48011","inReplyTo":"3f8076fa-ead3-4034-2d41-364b72169873@redhat.com","subject":"RE: recent glob expansion breakage on Windows?","fromName":"Carsey, Jaben","fromEmail":"jaben.carsey@intel.com","sentAt":"2018-03-13T23:12:22Z","receivedAt":"2018-03-13T23:12:30Z","isPatch":false,"sender":{"key":"jaben.carsey@intel.com","avatar":null},"body":"I do not remember what version I was using before.  I am suddenly wondering if I previously sent single patches instead of using wildcard (which works fine).  The only person I have found doing patch series here on windows uses the directory method (put patch files there, list directory name on send-email command line).\n\nI have updated to the 2.16.2 version and I see the same issues.\n\n-Jaben\n\n> -----Original Message-----\n> From: Laszlo Ersek [mailto:lersek@redhat.com]\n> Sent: Friday, March 09, 2018 1:42 AM\n> To: Jonathan Nieder <jrnieder@gmail.com>\n> Cc: public git mailing list <git@vger.kernel.org>; Carsey, Jaben\n> <jaben.carsey@intel.com>; git-for-windows@googlegroups.com\n> Subject: Re: recent glob expansion breakage on Windows?\n> Importance: High\n> \n> On 03/08/18 23:03, Jonathan Nieder wrote:\n> > +git-for-windows\n> > Hi,\n> >\n> > Laszlo Ersek wrote:\n> >\n> >> Jaben reports that git-send-email is suddenly failing to expand the\n> >> \"*.patch\" glob for him, at the Windows CMD prompt:\n> >>\n> >> ---------\n> >> E:\\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-\n> cc=cc --suppress-cc=sob --dry-run *.patch\n> >>\n> >> No patch files specified!\n> >> ---------\n> >>\n> >> Whereas, moving the same patch files to another subdir, and then passing\n> >> the subdir to git-send-email, works fine.\n> >>\n> >> I seem to have found some $^O based perl code in the git tree that\n> >> expands the glob manually (in place of the shell) on Windows -- however,\n> >> that code looks ancient ^W very stable, and doesn't seem to explain the\n> >> sudden breakage.\n> >>\n> >> Is it possible that a separate perl update on Jaben's Windows box is\n> >> causing this? Or does the breakage look consistent with a recent git\n> change?\n> >>\n> >> Has anyone else reported something similar recently?\n> >\n> > This reminds me of https://github.com/git-for-windows/git/issues/339.\n> > There, Johannes Schindelin writes (about a different command):\n> >\n> > | This is expected because neither PowerShell nor cmd.exe nor git.exe\n> > | expand wildcards. Those examples you found were written with a shell\n> > | in mind, and the shell expands wildcards (hence Git does not think\n> > | it needs to).\n> >\n> > That may or may not also apply to send-email.\n> \n> Thank you for the reference -- I can't say whether closing issue #339 as\n> WONTFIX was justified or not, but it certainly seems inconsistent with\n> Jaben's earlier experience (to my understanding), i.e. that git did\n> expand the glob.\n> \n> > In what version did it work?\n> \n> Jaben, can you please answer that? (One version in which it is broken is\n> 2.14.1.windows.1.) Can you perhaps ask your teammates about their\n> git/windows versions (assuming the *.patch glob is expanded correctly\n> for them)?\n> \n> Thank you, Jonathan,\n> Laszlo\n"}]}