{"thread":{"id":"48004","subject":"[PATCH] userdiff.c: Add C# async keyword in diff pattern","startedAt":"2018-03-08T10:04:19Z","lastAt":"2018-03-08T11:05:39Z","messageCount":3,"participants":["Thomas Levesque","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"341262","messageId":"0102016205115067-f3cdd5f1-2d69-4464-a665-db3a28360260-000000@eu-west-1.amazonses.com","threadId":"48004","inReplyTo":null,"subject":"[PATCH] userdiff.c: Add C# async keyword in diff pattern","fromName":"Thomas Levesque","fromEmail":"thomas.levesque@gmail.com","sentAt":"2018-03-08T10:04:03Z","receivedAt":"2018-03-08T10:04:19Z","isPatch":true,"sender":{"key":"thomas.levesque@gmail.com","avatar":null},"body":"Currently C# async methods are not shown in diff hunk headers. I just\nadded the async keyword to the csharp method pattern so that they are\nproperly detected.\n---\n userdiff.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/userdiff.c b/userdiff.c\nindex dbfb4e13cddce..b92caf42b27be 100644\n--- a/userdiff.c\n+++ b/userdiff.c\n@@ -138,7 +138,7 @@ PATTERNS(\"csharp\",\n \t /* Keywords */\n \t \"!^[ \\t]*(do|while|for|if|else|instanceof|new|return|switch|case|throw|catch|using)\\n\"\n \t /* Methods and constructors */\n-\t \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[<>@._[:alnum:]]+[ \\t]*\\\\(.*\\\\))[ \\t]*$\\n\"\n+\t \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe|async)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[<>@._[:alnum:]]+[ \\t]*\\\\(.*\\\\))[ \\t]*$\\n\"\n \t /* Properties */\n \t \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[@._[:alnum:]]+)[ \\t]*$\\n\"\n \t /* Type definitions */\n\n--\nhttps://github.com/git/git/pull/464\n"},{"id":"341264","messageId":"CAPig+cTPMqf1hN-fsaAkdZwCEH94ZPYJbfSE_rcjFCoSobxK5Q@mail.gmail.com","threadId":"48004","inReplyTo":"0102016205115067-f3cdd5f1-2d69-4464-a665-db3a28360260-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] userdiff.c: Add C# async keyword in diff pattern","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-03-08T10:22:44Z","receivedAt":"2018-03-08T10:22:51Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Mar 8, 2018 at 5:04 AM, Thomas Levesque\n<thomas.levesque@gmail.com> wrote:\n> Currently C# async methods are not shown in diff hunk headers. I just\n> added the async keyword to the csharp method pattern so that they are\n> properly detected.\n\nThanks for the contribution. Please sign-off your patch (see\nSubmittingPatches[1]).\n\n[1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L278\n\n> ---\n> diff --git a/userdiff.c b/userdiff.c\n> index dbfb4e13cddce..b92caf42b27be 100644\n> --- a/userdiff.c\n> +++ b/userdiff.c\n> @@ -138,7 +138,7 @@ PATTERNS(\"csharp\",\n>          /* Keywords */\n>          \"!^[ \\t]*(do|while|for|if|else|instanceof|new|return|switch|case|throw|catch|using)\\n\"\n>          /* Methods and constructors */\n> -        \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[<>@._[:alnum:]]+[ \\t]*\\\\(.*\\\\))[ \\t]*$\\n\"\n> +        \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe|async)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[<>@._[:alnum:]]+[ \\t]*\\\\(.*\\\\))[ \\t]*$\\n\"\n>          /* Properties */\n>          \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[@._[:alnum:]]+)[ \\t]*$\\n\"\n>          /* Type definitions */\n"},{"id":"341265","messageId":"0102016205499aff-6779e882-12d1-481e-8594-c02d72aa7165-000000@eu-west-1.amazonses.com","threadId":"48004","inReplyTo":"CAPig+cTPMqf1hN-fsaAkdZwCEH94ZPYJbfSE_rcjFCoSobxK5Q@mail.gmail.com","subject":"[PATCH] userdiff.c: Add C# async keyword in diff pattern","fromName":"Thomas Levesque","fromEmail":"thomas.levesque@gmail.com","sentAt":"2018-03-08T11:05:32Z","receivedAt":"2018-03-08T11:05:39Z","isPatch":true,"sender":{"key":"thomas.levesque@gmail.com","avatar":null},"body":"Currently C# async methods are not shown in diff hunk headers. I just\nadded the async keyword to the csharp method pattern so that they are\nproperly detected.\n\nSigned-off-by: Thomas Levesque <thomas.levesque@gmail.com>\n---\n userdiff.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/userdiff.c b/userdiff.c\nindex dbfb4e13cddce..b92caf42b27be 100644\n--- a/userdiff.c\n+++ b/userdiff.c\n@@ -138,7 +138,7 @@ PATTERNS(\"csharp\",\n \t /* Keywords */\n \t \"!^[ \\t]*(do|while|for|if|else|instanceof|new|return|switch|case|throw|catch|using)\\n\"\n \t /* Methods and constructors */\n-\t \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[<>@._[:alnum:]]+[ \\t]*\\\\(.*\\\\))[ \\t]*$\\n\"\n+\t \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe|async)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[<>@._[:alnum:]]+[ \\t]*\\\\(.*\\\\))[ \\t]*$\\n\"\n \t /* Properties */\n \t \"^[ \\t]*(((static|public|internal|private|protected|new|virtual|sealed|override|unsafe)[ \\t]+)*[][<>@.~_[:alnum:]]+[ \\t]+[@._[:alnum:]]+)[ \\t]*$\\n\"\n \t /* Type definitions */\n\n--\nhttps://github.com/git/git/pull/464\n"}]}