{"thread":{"id":"4799","subject":"[PATCH] do not use locale specific strftime when preparing 2822 date","startedAt":"2006-07-07T18:53:22Z","lastAt":"2006-07-07T19:59:57Z","messageCount":2,"participants":["Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"23383","messageId":"1152298402442-git-send-email-jnareb@gmail.com","threadId":"4799","inReplyTo":null,"subject":"[PATCH] do not use locale specific strftime when preparing 2822 date","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-07-07T18:53:22Z","receivedAt":"2006-07-07T18:53:22Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"---\n\n git-send-email.perl |   41 ++++++++++++++++++++++++++++++++++++++---\n 1 files changed, 38 insertions(+), 3 deletions(-)\n\nf00ff14faf86c376d0ffb3cef24d2e5a5437dfcf\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex b04b8f4..c9c1975 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -34,8 +34,43 @@ sub readline {\n package main;\n \n # most mail servers generate the Date: header, but not all...\n-$ENV{LC_ALL} = 'C';\n-use POSIX qw/strftime/;\n+sub format_2822_time {\n+\tmy ($time) = @_;\n+\tmy @localtm = localtime($time);\n+\tmy @gmttm = gmtime($time);\n+\tmy $localmin = $localtm[1] + $localtm[2] * 60;\n+\tmy $gmtmin = $gmttm[1] + $gmttm[2] * 60;\n+\tif ($localtm[0] != $gmttm[0]) {\n+\t\tdie \"local zone differs from GMT by a non-minute interval\\n\";\n+\t}\n+\tif ((($gmttm[6] + 1) % 7) == $localtm[6]) {\n+\t\t$localmin += 1440;\n+\t} elsif ((($gmttm[6] - 1) % 7) == $localtm[6]) {\n+\t\t$localmin -= 1440;\n+\t} elsif ($gmttm[6] != $localtm[6]) {\n+\t\tdie \"local time offset greater than or equal to 24 hours\\n\";\n+\t}\n+\tmy $offset = $localmin - $gmtmin;\n+\tmy $offhour = $offset / 60;\n+\tmy $offmin = abs($offset % 60);\n+\tif (abs($offhour) >= 24) {\n+\t\tdie (\"local time offset greater than or equal to 24 hours\\n\");\n+\t}\n+\n+\treturn sprintf(\"%s, %2d %s %d %02d:%02d:%02d %s%02d%02d\",\n+\t\t       qw(Sun Mon Tue Wed Thu Fri Sat)[$localtm[6]],\n+\t\t       $localtm[3],\n+\t\t       qw(Jan Feb Mar Apr May Jun\n+\t\t\t  Jul Aug Sep Oct Nov Dec)[$localtm[4]],\n+\t\t       $localtm[5]+1900,\n+\t\t       $localtm[2],\n+\t\t       $localtm[1],\n+\t\t       $localtm[0],\n+\t\t       ($offset >= 0) ? '+' : '-',\n+\t\t       abs($offhour),\n+\t\t       $offmin,\n+\t\t       );\n+}\n \n my $have_email_valid = eval { require Email::Valid; 1 };\n my $smtp;\n@@ -387,7 +422,7 @@ sub send_message\n \tmy @recipients = unique_email_list(@to);\n \tmy $to = join (\",\\n\\t\", @recipients);\n \t@recipients = unique_email_list(@recipients,@cc,@bcclist);\n-\tmy $date = strftime('%a, %d %b %Y %H:%M:%S %z', localtime($time++));\n+\tmy $date = format_2822_time($time++);\n \tmy $gitversion = '@@GIT_VERSION@@';\n \tif ($gitversion =~ m/..GIT_VERSION../) {\n \t    $gitversion = `git --version`;\n-- \n1.3.0\n"},{"id":"23393","messageId":"e8mefb$8ur$2@sea.gmane.org","threadId":"4799","inReplyTo":"1152298402442-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH] do not use locale specific strftime when preparing 2822 date","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-07-07T19:59:57Z","receivedAt":"2006-07-07T19:59:57Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Disregard this email. It was send by mistake by git-send-spam^Wemail.perl\n\n-- \nJakub Narebski\n"}]}