{"thread":{"id":"47879","subject":"[PATCH] Fix misconversion of gitsubmodule.txt","startedAt":"2018-02-20T08:51:52Z","lastAt":"2018-02-20T20:12:25Z","messageCount":9,"participants":["marmot1123","Eric Sunshine","brian m. carlson","Stefan Beller","Kaartic Sivaraam","Todd Zullinger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"339693","messageId":"01020161b2696296-9d580cc6-c21f-4fa2-a876-7d77d36cb44a-000000@eu-west-1.amazonses.com","threadId":"47879","inReplyTo":null,"subject":"[PATCH] Fix misconversion of gitsubmodule.txt","fromName":"marmot1123","fromEmail":"marmot.motoki@gmail.com","sentAt":"2018-02-20T08:51:46Z","receivedAt":"2018-02-20T08:51:52Z","isPatch":true,"sender":{"key":"marmot.motoki@gmail.com","avatar":"https://avatars.githubusercontent.com/u/6357126?v=4"},"body":"In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions `submodule’s`.\nIt seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.\n---\n Documentation/gitsubmodules.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt\nindex 46cf120f666df..0d59ab4cdfb1c 100644\n--- a/Documentation/gitsubmodules.txt\n+++ b/Documentation/gitsubmodules.txt\n@@ -24,7 +24,7 @@ On the filesystem, a submodule usually (but not always - see FORMS below)\n consists of (i) a Git directory located under the `$GIT_DIR/modules/`\n directory of its superproject, (ii) a working directory inside the\n superproject's working directory, and a `.git` file at the root of\n-the submodule’s working directory pointing to (i).\n+the submodule's working directory pointing to (i).\n \n Assuming the submodule has a Git directory at `$GIT_DIR/modules/foo/`\n and a working directory at `path/to/bar/`, the superproject tracks the\n@@ -33,7 +33,7 @@ in its `.gitmodules` file (see linkgit:gitmodules[5]) of the form\n `submodule.foo.path = path/to/bar`.\n \n The `gitlink` entry contains the object name of the commit that the\n-superproject expects the submodule’s working directory to be at.\n+superproject expects the submodule's working directory to be at.\n \n The section `submodule.foo.*` in the `.gitmodules` file gives additional\n hints to Gits porcelain layer such as where to obtain the submodule via\n\n--\nhttps://github.com/git/git/pull/459\n"},{"id":"339694","messageId":"CAPig+cS0D_Svkj+1yFTT1nk1jvXhH35uNCET1r_6tLd86tdviQ@mail.gmail.com","threadId":"47879","inReplyTo":"01020161b2696296-9d580cc6-c21f-4fa2-a876-7d77d36cb44a-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] Fix misconversion of gitsubmodule.txt","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-02-20T10:02:06Z","receivedAt":"2018-02-20T10:02:13Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Tue, Feb 20, 2018 at 3:51 AM, marmot1123 <marmot.motoki@gmail.com> wrote:\n> In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions `submodule’s`.\n> It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.\n\nThanks for the contribution. Please sign-off your patch; see\nDocumentation/SubmittingPatches.\n"},{"id":"339700","messageId":"20180220113036.GG6619@genre.crustytoothpaste.net","threadId":"47879","inReplyTo":"01020161b2696296-9d580cc6-c21f-4fa2-a876-7d77d36cb44a-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] Fix misconversion of gitsubmodule.txt","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2018-02-20T11:30:36Z","receivedAt":"2018-02-20T11:30:50Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Tue, Feb 20, 2018 at 08:51:46AM +0000, marmot1123 wrote:\n> In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions `submodule’s`.\n> It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.\n\nWhile I agree consistency is good, does this have any effect on the\noutput?  I think AsciiDoc (and Asciidoctor) produce the non-ASCII\nformat for output, so this should be a no-op for all known output\nformats.\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\nhttps://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: https://keybase.io/bk2204\n"},{"id":"339702","messageId":"01020161b30b99df-5029ec2b-a5cb-475b-b54f-9879a117a7f3-000000@eu-west-1.amazonses.com","threadId":"47879","inReplyTo":"01020161b2696296-9d580cc6-c21f-4fa2-a876-7d77d36cb44a-000000@eu-west-1.amazonses.com","subject":"[PATCH v2] Fix misconversion of gitsubmodule.txt","fromName":"marmot1123","fromEmail":"marmot.motoki@gmail.com","sentAt":"2018-02-20T11:48:57Z","receivedAt":"2018-02-20T11:49:03Z","isPatch":true,"sender":{"key":"marmot.motoki@gmail.com","avatar":"https://avatars.githubusercontent.com/u/6357126?v=4"},"body":"In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions `submodule’s`.\nIt seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.\n\nSigned-off-by: Motoki Seki <marmot.motoki@gmail.com>\n---\n Documentation/gitsubmodules.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt\nindex 46cf120f666df..0d59ab4cdfb1c 100644\n--- a/Documentation/gitsubmodules.txt\n+++ b/Documentation/gitsubmodules.txt\n@@ -24,7 +24,7 @@ On the filesystem, a submodule usually (but not always - see FORMS below)\n consists of (i) a Git directory located under the `$GIT_DIR/modules/`\n directory of its superproject, (ii) a working directory inside the\n superproject's working directory, and a `.git` file at the root of\n-the submodule’s working directory pointing to (i).\n+the submodule's working directory pointing to (i).\n \n Assuming the submodule has a Git directory at `$GIT_DIR/modules/foo/`\n and a working directory at `path/to/bar/`, the superproject tracks the\n@@ -33,7 +33,7 @@ in its `.gitmodules` file (see linkgit:gitmodules[5]) of the form\n `submodule.foo.path = path/to/bar`.\n \n The `gitlink` entry contains the object name of the commit that the\n-superproject expects the submodule’s working directory to be at.\n+superproject expects the submodule's working directory to be at.\n \n The section `submodule.foo.*` in the `.gitmodules` file gives additional\n hints to Gits porcelain layer such as where to obtain the submodule via\n\n--\nhttps://github.com/git/git/pull/459\n"},{"id":"339721","messageId":"CAGZ79kajrwqu2X7BRe8w0W_sa0nosXxspfhbrm0d-ASzxCLn-A@mail.gmail.com","threadId":"47879","inReplyTo":"01020161b30b99df-5029ec2b-a5cb-475b-b54f-9879a117a7f3-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH v2] Fix misconversion of gitsubmodule.txt","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-02-20T18:50:59Z","receivedAt":"2018-02-20T18:51:06Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Kaartic was the last to touch that file,\n(as found via git log origin/master -- Documentation/gitsubmodules.txt),\nsorry I did not find this in the review.\n\nThanks for the patch!\nStefan\n\n\nOn Tue, Feb 20, 2018 at 3:48 AM, marmot1123 <marmot.motoki@gmail.com> wrote:\n> In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions `submodule’s`.\n> It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.\n>\n> Signed-off-by: Motoki Seki <marmot.motoki@gmail.com>\n> ---\n>  Documentation/gitsubmodules.txt | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt\n> index 46cf120f666df..0d59ab4cdfb1c 100644\n> --- a/Documentation/gitsubmodules.txt\n> +++ b/Documentation/gitsubmodules.txt\n> @@ -24,7 +24,7 @@ On the filesystem, a submodule usually (but not always - see FORMS below)\n>  consists of (i) a Git directory located under the `$GIT_DIR/modules/`\n>  directory of its superproject, (ii) a working directory inside the\n>  superproject's working directory, and a `.git` file at the root of\n> -the submodule’s working directory pointing to (i).\n> +the submodule's working directory pointing to (i).\n>\n>  Assuming the submodule has a Git directory at `$GIT_DIR/modules/foo/`\n>  and a working directory at `path/to/bar/`, the superproject tracks the\n> @@ -33,7 +33,7 @@ in its `.gitmodules` file (see linkgit:gitmodules[5]) of the form\n>  `submodule.foo.path = path/to/bar`.\n>\n>  The `gitlink` entry contains the object name of the commit that the\n> -superproject expects the submodule’s working directory to be at.\n> +superproject expects the submodule's working directory to be at.\n>\n>  The section `submodule.foo.*` in the `.gitmodules` file gives additional\n>  hints to Gits porcelain layer such as where to obtain the submodule via\n>\n> --\n> https://github.com/git/git/pull/459\n"},{"id":"339730","messageId":"b4e6f89b-fc20-7244-ad23-548697f9764e@gmail.com","threadId":"47879","inReplyTo":"CAGZ79kajrwqu2X7BRe8w0W_sa0nosXxspfhbrm0d-ASzxCLn-A@mail.gmail.com","subject":"Re: [PATCH v2] Fix misconversion of gitsubmodule.txt","fromName":"Kaartic Sivaraam","fromEmail":"kaartic.sivaraam@gmail.com","sentAt":"2018-02-20T19:36:38Z","receivedAt":"2018-02-20T19:36:49Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"Hi,\n\nOn Wednesday 21 February 2018 12:20 AM, Stefan Beller wrote:\n> Kaartic was the last to touch that file,\n> (as found via git log origin/master -- Documentation/gitsubmodules.txt),\n> sorry I did not find this in the review.\n> \n\n\"Non-ASCII characters\" made me dig into to this a little deeper as I\ngenerally don't use them particularly for text files.\n\n\"git blame\" points at d48034551 (submodules: overhaul documentation,\n2017-06-22) as the offending comment.\n\n\n> Thanks for the patch!\n\nYeah, nice catch!\n\n\n--\nKaartic\n\nQUOTE\n\n“It is impossible to live without failing at something, unless you live\nso cautiously that you might as well not have lived at all – in which\ncase, you fail by default.”\n\n      - J. K. Rowling\n\n"},{"id":"339731","messageId":"20180220193834.GM27038@zaya.teonanacatl.net","threadId":"47879","inReplyTo":"01020161b30b99df-5029ec2b-a5cb-475b-b54f-9879a117a7f3-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH v2] Fix misconversion of gitsubmodule.txt","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2018-02-20T19:38:34Z","receivedAt":"2018-02-20T19:38:45Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Hi,\n\nmarmot1123 wrote:\n> In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions `submodule’s`.\n> It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.\n\nIf replacing the non-ASCI apostrophes is the goal, aren't\nthere a number of others in the same file worth cleaning up\nat the same time?\n\n$ grep '’' Documentation/gitsubmodules.txt\nthe submodule’s working directory pointing to (i).\nsuperproject expects the submodule’s working directory to be at.\nWhen deinitialized or deleted (see below), the submodule’s Git\nbut no submodule working directory. The submodule’s Git directory\nthe superproject’s `$GIT_DIR/config` file, so the superproject’s history\nThe deletion removes the superproject’s tracking data, which are\nThe submodule’s working directory is removed from the file\n\nThis does seem to be the only file which includes the\nnon-ASCII apostrophe under Documentation.\n\nSome tests include it (intentionally) as does\ncontrib/credential/netrc/git-credential-netrc.\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nThe direct use of physical force is so poor a solution to the problem\nof limited resources that it is commonly employed only by small\nchildren and great nations.\n    -- David Friedman\n\n"},{"id":"339733","messageId":"CAGZ79kZf6hm9jU2oBUsxp2X33B=_RQps0y9JOc2-j2zm1k4cDw@mail.gmail.com","threadId":"47879","inReplyTo":"b4e6f89b-fc20-7244-ad23-548697f9764e@gmail.com","subject":"Re: [PATCH v2] Fix misconversion of gitsubmodule.txt","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-02-20T19:44:58Z","receivedAt":"2018-02-20T19:45:04Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Feb 20, 2018 at 11:36 AM, Kaartic Sivaraam\n<kaartic.sivaraam@gmail.com> wrote:\n> Hi,\n>\n> On Wednesday 21 February 2018 12:20 AM, Stefan Beller wrote:\n>> Kaartic was the last to touch that file,\n>> (as found via git log origin/master -- Documentation/gitsubmodules.txt),\n>> sorry I did not find this in the review.\n>>\n>\n> \"Non-ASCII characters\" made me dig into to this a little deeper as I\n> generally don't use them particularly for text files.\n>\n> \"git blame\" points at d48034551 (submodules: overhaul documentation,\n> 2017-06-22) as the offending comment.\n\nHah, good catch! Sorry for my assumptions there.\n"},{"id":"339735","messageId":"xmqqfu5v2zfj.fsf@gitster-ct.c.googlers.com","threadId":"47879","inReplyTo":"20180220193834.GM27038@zaya.teonanacatl.net","subject":"Re: [PATCH v2] Fix misconversion of gitsubmodule.txt","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-02-20T20:12:16Z","receivedAt":"2018-02-20T20:12:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> If replacing the non-ASCI apostrophes is the goal, aren't\n> there a number of others in the same file worth cleaning up\n> at the same time?\n>\n> $ grep '’' Documentation/gitsubmodules.txt\n> the submodule’s working directory pointing to (i).\n> superproject expects the submodule’s working directory to be at.\n> When deinitialized or deleted (see below), the submodule’s Git\n> but no submodule working directory. The submodule’s Git directory\n> the superproject’s `$GIT_DIR/config` file, so the superproject’s history\n> The deletion removes the superproject’s tracking data, which are\n> The submodule’s working directory is removed from the file\n>\n> This does seem to be the only file which includes the\n> non-ASCII apostrophe under Documentation.\n\nThanks for checking.  I agree that it is a good idea to clean the\nwhole file up at the same time.  The title would need to be updated,\nas it will no longer be \"fix misconversion\".  The justification would\nalso become different---\"the 'overhaul' did not just move the text\nbut made the apostrophe style changes and reverting that change is a\ngood thing\" was a good justification for \"fix misconversion\", but\nnow we need to explain to the future readers of \"git log\" why we\nprefer to turn all of them in this file to ASCII single quotes (just\nsaying \"make it consistent\" is sufficient).\n\nThanks.\n\n"}]}