{"thread":{"id":"47844","subject":"[PATCH v1] fsmonitor: update documentation to remove reference to invalid config settings","startedAt":"2018-02-14T15:42:04Z","lastAt":"2018-02-14T18:28:18Z","messageCount":2,"participants":["Ben Peart","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"339286","messageId":"20180214154130.111708-1-benpeart@microsoft.com","threadId":"47844","inReplyTo":null,"subject":"[PATCH v1] fsmonitor: update documentation to remove reference to invalid config settings","fromName":"Ben Peart","fromEmail":"benpeart@microsoft.com","sentAt":"2018-02-14T15:41:30Z","receivedAt":"2018-02-14T15:42:04Z","isPatch":true,"sender":{"key":"benpeart@microsoft.com","avatar":"https://avatars.githubusercontent.com/u/15252029?v=4"},"body":"Remove the reference to setting core.fsmonitor to `true` (or `false`) as those\nare not valid settings.\n\nSigned-off-by: Ben Peart <benpeart@microsoft.com>\n---\n\nNotes:\n    Base Ref: master\n    Web-Diff: https://github.com/benpeart/git/commit/4b7ec2c11e\n    Checkout: git fetch https://github.com/benpeart/git fsmonitor_docs-v1 && git checkout 4b7ec2c11e\n\n Documentation/git-update-index.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\nindex bdb0342593..ad2383d7ed 100644\n--- a/Documentation/git-update-index.txt\n+++ b/Documentation/git-update-index.txt\n@@ -484,8 +484,8 @@ the `core.fsmonitor` configuration variable (see\n linkgit:git-config[1]) than using the `--fsmonitor` option to\n `git update-index` in each repository, especially if you want to do so\n across all repositories you use, because you can set the configuration\n-variable to `true` (or `false`) in your `$HOME/.gitconfig` just once\n-and have it affect all repositories you touch.\n+variable in your `$HOME/.gitconfig` just once and have it affect all\n+repositories you touch.\n \n When the `core.fsmonitor` configuration variable is changed, the\n file system monitor is added to or removed from the index the next time\n\nbase-commit: e7e80778e705ea3f9332c634781d6d0f8c6eab64\n-- \n2.15.0.windows.1\n\n"},{"id":"339310","messageId":"xmqq7erfo287.fsf@gitster-ct.c.googlers.com","threadId":"47844","inReplyTo":"20180214154130.111708-1-benpeart@microsoft.com","subject":"Re: [PATCH v1] fsmonitor: update documentation to remove reference to invalid config settings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-02-14T18:28:08Z","receivedAt":"2018-02-14T18:28:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ben Peart <benpeart@microsoft.com> writes:\n\n> Remove the reference to setting core.fsmonitor to `true` (or `false`) as those\n> are not valid settings.\n>\n> Signed-off-by: Ben Peart <benpeart@microsoft.com>\n> ---\n\nThanks.  It is a bit embarrassing that nobody caught it for this\nlong.  Will apply.\n\n>\n> Notes:\n>     Base Ref: master\n>     Web-Diff: https://github.com/benpeart/git/commit/4b7ec2c11e\n>     Checkout: git fetch https://github.com/benpeart/git fsmonitor_docs-v1 && git checkout 4b7ec2c11e\n>\n>  Documentation/git-update-index.txt | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\n> index bdb0342593..ad2383d7ed 100644\n> --- a/Documentation/git-update-index.txt\n> +++ b/Documentation/git-update-index.txt\n> @@ -484,8 +484,8 @@ the `core.fsmonitor` configuration variable (see\n>  linkgit:git-config[1]) than using the `--fsmonitor` option to\n>  `git update-index` in each repository, especially if you want to do so\n>  across all repositories you use, because you can set the configuration\n> -variable to `true` (or `false`) in your `$HOME/.gitconfig` just once\n> -and have it affect all repositories you touch.\n> +variable in your `$HOME/.gitconfig` just once and have it affect all\n> +repositories you touch.\n>  \n>  When the `core.fsmonitor` configuration variable is changed, the\n>  file system monitor is added to or removed from the index the next time\n>\n> base-commit: e7e80778e705ea3f9332c634781d6d0f8c6eab64\n"}]}