{"thread":{"id":"47833","subject":"should \"--recurse-submodule\" be \"--recurse-submodules\"?","startedAt":"2018-02-14T00:30:08Z","lastAt":"2018-02-14T19:12:14Z","messageCount":2,"participants":["Robert P. J. Day","Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"339246","messageId":"alpine.LFD.2.21.1802131927310.17903@localhost.localdomain","threadId":"47833","inReplyTo":null,"subject":"should \"--recurse-submodule\" be \"--recurse-submodules\"?","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2018-02-14T00:30:00Z","receivedAt":"2018-02-14T00:30:08Z","isPatch":false,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"\n  also just noticed the following:\n\nDocumentation/RelNotes/2.13.0.txt:489: * A few commands that recently learned the \"--recurse-submodule\"\nDocumentation/RelNotes/2.12.0.txt:226: * \"git push --dry-run --recurse-submodule=on-demand\" wasn't\nDocumentation/RelNotes/2.11.1.txt:27: * \"git push --dry-run --recurse-submodule=on-demand\" wasn't\nt/t5531-deep-submodule-push.sh:366:\t\tgit push --recurse-submodule=check origin master\nt/t5572-pull-submodule.sh:45:test_expect_success 'pull --recurse-submodule setup' '\n\n  should some of those be corrected?\n\nrday\n"},{"id":"339387","messageId":"CAGZ79kZ1yYXToC_WvW8e93zvajkw06e8BT_FcJUXWtFBK3Xe4w@mail.gmail.com","threadId":"47833","inReplyTo":"alpine.LFD.2.21.1802131927310.17903@localhost.localdomain","subject":"Re: should \"--recurse-submodule\" be \"--recurse-submodules\"?","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-02-14T19:12:07Z","receivedAt":"2018-02-14T19:12:14Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Feb 13, 2018 at 4:30 PM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:\n>\n>   also just noticed the following:\n>\n> Documentation/RelNotes/2.13.0.txt:489: * A few commands that recently learned the \"--recurse-submodule\"\n> Documentation/RelNotes/2.12.0.txt:226: * \"git push --dry-run --recurse-submodule=on-demand\" wasn't\n> Documentation/RelNotes/2.11.1.txt:27: * \"git push --dry-run --recurse-submodule=on-demand\" wasn't\n> t/t5531-deep-submodule-push.sh:366:             git push --recurse-submodule=check origin master\n> t/t5572-pull-submodule.sh:45:test_expect_success 'pull --recurse-submodule setup' '\n>\n>   should some of those be corrected?\n\nI get the same list via\n  git grep -- --recurse-submodule |grep -v -- --recurse-submodules\nso there is no missing piece left.\n\nAs you can see, the first 3 are Documentation, and the other 2 are tests,\nthe actual code is always --recurse-submodules (with an s!).\n\nFixing the docs as well as t5572 has the impact of \"just fixing typos\"\n(though that is specifically valuable for command line options where\nexact spelling matters)\n\nThe fix in 5531 is an actual bugfix in the test suite, which\nwent unnoticed as the test itself did not fail.\n\nThe test did not fail because git autocompleted the command\nline option silently. But that is not what we want to test there.\n\nStefan\n"}]}