{"thread":{"id":"47832","subject":"[PATCH v2] Correct mispellings of \".gitmodule\" to \".gitmodules\"","startedAt":"2018-02-14T00:09:38Z","lastAt":"2018-02-14T19:37:12Z","messageCount":2,"participants":["Robert P. J. Day","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"339244","messageId":"alpine.LFD.2.21.1802131907480.17291@localhost.localdomain","threadId":"47832","inReplyTo":null,"subject":"[PATCH v2] Correct mispellings of \".gitmodule\" to \".gitmodules\"","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2018-02-14T00:09:31Z","receivedAt":"2018-02-14T00:09:38Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"There are a small number of misspellings, \".gitmodule\", scattered\nthroughout the code base, correct them ... no apparent functional\nchanges.\n\n Documentation/technical/api-submodule-config.txt | 2 +-\n contrib/subtree/git-subtree.txt | 2 +-\n submodule-config.c | 4 ++--\n t/t5526-fetch-submodules.sh | 2 +-\n 4 files changed, 5 insertions(+), 5 deletions(-)\n\nSigned-off-by: Robert P. J. Day \n\n---\n\n can't believe i forgot to sign my own patch. le *sigh* ...\n\ndiff --git a/Documentation/technical/api-submodule-config.txt b/Documentation/technical/api-submodule-config.txt\nindex 3dce003fd..ee907c4a8 100644\n--- a/Documentation/technical/api-submodule-config.txt\n+++ b/Documentation/technical/api-submodule-config.txt\n@@ -4,7 +4,7 @@ submodule config cache API\n The submodule config cache API allows to read submodule\n configurations/information from specified revisions. Internally\n information is lazily read into a cache that is used to avoid\n-unnecessary parsing of the same .gitmodule files. Lookups can be done by\n+unnecessary parsing of the same .gitmodules files. Lookups can be done by\n submodule path or name.\n\n Usage\ndiff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\nindex 60d76cddd..352deda69 100644\n--- a/contrib/subtree/git-subtree.txt\n+++ b/contrib/subtree/git-subtree.txt\n@@ -28,7 +28,7 @@ as a subdirectory of your application.\n\n Subtrees are not to be confused with submodules, which are meant for\n the same task. Unlike submodules, subtrees do not need any special\n-constructions (like .gitmodule files or gitlinks) be present in\n+constructions (like .gitmodules files or gitlinks) be present in\n your repository, and do not force end-users of your\n repository to do anything special or to understand how subtrees\n work. A subtree is just a subdirectory that can be\ndiff --git a/submodule-config.c b/submodule-config.c\nindex 2aa8a1747..602ba8ca8 100644\n--- a/submodule-config.c\n+++ b/submodule-config.c\n@@ -9,7 +9,7 @@\n /*\n * submodule cache lookup structure\n * There is one shared set of 'struct submodule' entries which can be\n- * looked up by their sha1 blob id of the .gitmodule file and either\n+ * looked up by their sha1 blob id of the .gitmodules file and either\n * using path or name as key.\n * for_path stores submodule entries with path as key\n * for_name stores submodule entries with name as key\n@@ -91,7 +91,7 @@ static void submodule_cache_clear(struct submodule_cache *cache)\n \t/*\n \t * We iterate over the name hash here to be symmetric with the\n \t * allocation of struct submodule entries. Each is allocated by\n-\t * their .gitmodule blob sha1 and submodule name.\n+\t * their .gitmodules blob sha1 and submodule name.\n \t */\n \thashmap_iter_init(&cache->for_name, &iter);\n \twhile ((entry = hashmap_iter_next(&iter)))\ndiff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh\nindex a552ad4ea..74486c73b 100755\n--- a/t/t5526-fetch-submodules.sh\n+++ b/t/t5526-fetch-submodules.sh\n@@ -485,7 +485,7 @@ test_expect_success \"don't fetch submodule when newly recorded commits are alrea\n \t)\n '\n\n-test_expect_success \"'fetch.recurseSubmodules=on-demand' works also without .gitmodule entry\" '\n+test_expect_success \"'fetch.recurseSubmodules=on-demand' works also without .gitmodules entry\" '\n \t(\n \t\tcd downstream &&\n \t\tgit fetch --recurse-submodules\n\nrday\n\n-- \n\n========================================================================\nRobert P. J. Day Ottawa, Ontario, CANADA\n http://crashcourse.ca\n\nTwitter: http://twitter.com/rpjday\nLinkedIn: http://ca.linkedin.com/in/rpjday\n========================================================================\n"},{"id":"339391","messageId":"xmqqpo57mkgw.fsf@gitster-ct.c.googlers.com","threadId":"47832","inReplyTo":"alpine.LFD.2.21.1802131907480.17291@localhost.localdomain","subject":"Re: [PATCH v2] Correct mispellings of \".gitmodule\" to \".gitmodules\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-02-14T19:37:03Z","receivedAt":"2018-02-14T19:37:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Robert P. J. Day\" writes:\n\n> There are a small number of misspellings, \".gitmodule\", scattered\n> throughout the code base, correct them ... no apparent functional\n> changes.\n>\n> Documentation/technical/api-submodule-config.txt | 2 +-\n> contrib/subtree/git-subtree.txt | 2 +-\n> submodule-config.c | 4 ++--\n> t/t5526-fetch-submodules.sh | 2 +-\n> 4 files changed, 5 insertions(+), 5 deletions(-)\n>\n> Signed-off-by: Robert P. J. Day \n>\n> ---\n>\n> can't believe i forgot to sign my own patch. le *sigh* ...\n>\n> diff --git a/Documentation/technical/api-submodule-config.txt b/Documentation/technical/api-submodule-config.txt\n\nJust for future reference, the diffstat and summary comes _after_\nthe three-dash line, before which is your sign-off, and after which\nyou can have additional comment like \"can't believe...\".\n\nNo need to resend, as I can remove the cruft from the log message\nwhile queuing.\n\nThanks. The patch looks good. Will queue.\n"}]}