{"thread":{"id":"47830","subject":"[PATCH] Correct mispellings of \".gitmodule\" to \".gitmodules\"","startedAt":"2018-02-13T23:34:04Z","lastAt":"2018-02-13T23:45:31Z","messageCount":2,"participants":["Robert P. J. Day","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"339240","messageId":"alpine.LFD.2.21.1802131831410.16573@localhost.localdomain","threadId":"47830","inReplyTo":null,"subject":"[PATCH] Correct mispellings of \".gitmodule\" to \".gitmodules\"","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2018-02-13T23:33:54Z","receivedAt":"2018-02-13T23:34:04Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"\nThere are a small number of misspellings, \".gitmodule\", scattered\nthroughout the code base, correct them ... no apparent functional\nchanges.\n\n Documentation/technical/api-submodule-config.txt | 2 +-\n contrib/subtree/git-subtree.txt                  | 2 +-\n submodule-config.c                               | 4 ++--\n t/t5526-fetch-submodules.sh                      | 2 +-\n 4 files changed, 5 insertions(+), 5 deletions(-)\n\n---\n\n  fairly brainless correction of what appear to be minor misspellings.\n\ndiff --git a/Documentation/technical/api-submodule-config.txt b/Documentation/technical/api-submodule-config.txt\nindex 3dce003fd..ee907c4a8 100644\n--- a/Documentation/technical/api-submodule-config.txt\n+++ b/Documentation/technical/api-submodule-config.txt\n@@ -4,7 +4,7 @@ submodule config cache API\n The submodule config cache API allows to read submodule\n configurations/information from specified revisions. Internally\n information is lazily read into a cache that is used to avoid\n-unnecessary parsing of the same .gitmodule files. Lookups can be done by\n+unnecessary parsing of the same .gitmodules files. Lookups can be done by\n submodule path or name.\n\n Usage\ndiff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\nindex 60d76cddd..352deda69 100644\n--- a/contrib/subtree/git-subtree.txt\n+++ b/contrib/subtree/git-subtree.txt\n@@ -28,7 +28,7 @@ as a subdirectory of your application.\n\n Subtrees are not to be confused with submodules, which are meant for\n the same task. Unlike submodules, subtrees do not need any special\n-constructions (like .gitmodule files or gitlinks) be present in\n+constructions (like .gitmodules files or gitlinks) be present in\n your repository, and do not force end-users of your\n repository to do anything special or to understand how subtrees\n work. A subtree is just a subdirectory that can be\ndiff --git a/submodule-config.c b/submodule-config.c\nindex 2aa8a1747..602ba8ca8 100644\n--- a/submodule-config.c\n+++ b/submodule-config.c\n@@ -9,7 +9,7 @@\n /*\n  * submodule cache lookup structure\n  * There is one shared set of 'struct submodule' entries which can be\n- * looked up by their sha1 blob id of the .gitmodule file and either\n+ * looked up by their sha1 blob id of the .gitmodules file and either\n  * using path or name as key.\n  * for_path stores submodule entries with path as key\n  * for_name stores submodule entries with name as key\n@@ -91,7 +91,7 @@ static void submodule_cache_clear(struct submodule_cache *cache)\n \t/*\n \t * We iterate over the name hash here to be symmetric with the\n \t * allocation of struct submodule entries. Each is allocated by\n-\t * their .gitmodule blob sha1 and submodule name.\n+\t * their .gitmodules blob sha1 and submodule name.\n \t */\n \thashmap_iter_init(&cache->for_name, &iter);\n \twhile ((entry = hashmap_iter_next(&iter)))\ndiff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh\nindex a552ad4ea..74486c73b 100755\n--- a/t/t5526-fetch-submodules.sh\n+++ b/t/t5526-fetch-submodules.sh\n@@ -485,7 +485,7 @@ test_expect_success \"don't fetch submodule when newly recorded commits are alrea\n \t)\n '\n\n-test_expect_success \"'fetch.recurseSubmodules=on-demand' works also without .gitmodule entry\" '\n+test_expect_success \"'fetch.recurseSubmodules=on-demand' works also without .gitmodules entry\" '\n \t(\n \t\tcd downstream &&\n \t\tgit fetch --recurse-submodules\n\n-- \n\n========================================================================\nRobert P. J. Day                                 Ottawa, Ontario, CANADA\n                        http://crashcourse.ca\n\nTwitter:                                       http://twitter.com/rpjday\nLinkedIn:                               http://ca.linkedin.com/in/rpjday\n========================================================================\n"},{"id":"339242","messageId":"CAGZ79kY7a0zFkatY4vvTAGjFnvr43EWkFC_RW0O-Lp4e+dwOPA@mail.gmail.com","threadId":"47830","inReplyTo":"alpine.LFD.2.21.1802131831410.16573@localhost.localdomain","subject":"Re: [PATCH] Correct mispellings of \".gitmodule\" to \".gitmodules\"","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-02-13T23:45:25Z","receivedAt":"2018-02-13T23:45:31Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Feb 13, 2018 at 3:33 PM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:\n>\n> There are a small number of misspellings, \".gitmodule\", scattered\n> throughout the code base, correct them ... no apparent functional\n> changes.\n\nThanks for catching these!\n\n\n>  Documentation/technical/api-submodule-config.txt | 2 +-\n>  contrib/subtree/git-subtree.txt                  | 2 +-\n>  submodule-config.c                               | 4 ++--\n>  t/t5526-fetch-submodules.sh                      | 2 +-\n>  4 files changed, 5 insertions(+), 5 deletions(-)\n\nPlease sign off your patch. (See Documentation/SubmittingPatches)\n\n>\n> ---\n>\n>   fairly brainless correction of what appear to be minor misspellings.\n\nthe code looks good.\n\nThanks,\nStefan\n\n>\n> diff --git a/Documentation/technical/api-submodule-config.txt b/Documentation/technical/api-submodule-config.txt\n> index 3dce003fd..ee907c4a8 100644\n> --- a/Documentation/technical/api-submodule-config.txt\n> +++ b/Documentation/technical/api-submodule-config.txt\n> @@ -4,7 +4,7 @@ submodule config cache API\n>  The submodule config cache API allows to read submodule\n>  configurations/information from specified revisions. Internally\n>  information is lazily read into a cache that is used to avoid\n> -unnecessary parsing of the same .gitmodule files. Lookups can be done by\n> +unnecessary parsing of the same .gitmodules files. Lookups can be done by\n>  submodule path or name.\n>\n>  Usage\n> diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt\n> index 60d76cddd..352deda69 100644\n> --- a/contrib/subtree/git-subtree.txt\n> +++ b/contrib/subtree/git-subtree.txt\n> @@ -28,7 +28,7 @@ as a subdirectory of your application.\n>\n>  Subtrees are not to be confused with submodules, which are meant for\n>  the same task. Unlike submodules, subtrees do not need any special\n> -constructions (like .gitmodule files or gitlinks) be present in\n> +constructions (like .gitmodules files or gitlinks) be present in\n>  your repository, and do not force end-users of your\n>  repository to do anything special or to understand how subtrees\n>  work. A subtree is just a subdirectory that can be\n> diff --git a/submodule-config.c b/submodule-config.c\n> index 2aa8a1747..602ba8ca8 100644\n> --- a/submodule-config.c\n> +++ b/submodule-config.c\n> @@ -9,7 +9,7 @@\n>  /*\n>   * submodule cache lookup structure\n>   * There is one shared set of 'struct submodule' entries which can be\n> - * looked up by their sha1 blob id of the .gitmodule file and either\n> + * looked up by their sha1 blob id of the .gitmodules file and either\n>   * using path or name as key.\n>   * for_path stores submodule entries with path as key\n>   * for_name stores submodule entries with name as key\n> @@ -91,7 +91,7 @@ static void submodule_cache_clear(struct submodule_cache *cache)\n>         /*\n>          * We iterate over the name hash here to be symmetric with the\n>          * allocation of struct submodule entries. Each is allocated by\n> -        * their .gitmodule blob sha1 and submodule name.\n> +        * their .gitmodules blob sha1 and submodule name.\n>          */\n>         hashmap_iter_init(&cache->for_name, &iter);\n>         while ((entry = hashmap_iter_next(&iter)))\n> diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh\n> index a552ad4ea..74486c73b 100755\n> --- a/t/t5526-fetch-submodules.sh\n> +++ b/t/t5526-fetch-submodules.sh\n> @@ -485,7 +485,7 @@ test_expect_success \"don't fetch submodule when newly recorded commits are alrea\n>         )\n>  '\n>\n> -test_expect_success \"'fetch.recurseSubmodules=on-demand' works also without .gitmodule entry\" '\n> +test_expect_success \"'fetch.recurseSubmodules=on-demand' works also without .gitmodules entry\" '\n>         (\n>                 cd downstream &&\n>                 git fetch --recurse-submodules\n>\n> --\n>\n> ========================================================================\n> Robert P. J. Day                                 Ottawa, Ontario, CANADA\n>                         http://crashcourse.ca\n>\n> Twitter:                                       http://twitter.com/rpjday\n> LinkedIn:                               http://ca.linkedin.com/in/rpjday\n> ========================================================================\n"}]}