{"thread":{"id":"47796","subject":"Issue: Git Gui: show ssh key don't show key type id_ed25519.pub","startedAt":"2018-02-09T11:29:25Z","lastAt":"2018-02-24T18:49:36Z","messageCount":2,"participants":["Fechter, Juergen","Beat Bolli"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"338864","messageId":"F65780F29E48994380E2BCE87C6F071101146AB1@DEERLM99EX2MSX.ww931.my-it-solutions.net","threadId":"47796","inReplyTo":null,"subject":"Issue: Git Gui: show ssh key don't show key type id_ed25519.pub","fromName":"Fechter, Juergen","fromEmail":"juergen.fechter@atos.net","sentAt":"2018-02-09T11:21:56Z","receivedAt":"2018-02-09T11:29:25Z","isPatch":false,"sender":{"key":"juergen.fechter@atos.net","avatar":null},"body":"Hello,\n\nMaybe someone can fix this issue.\nThanks\n\nGit Gui: show ssh key don't show key type id_ed25519.pub\nSetup\n. Which version of Git for Windows are you using? Is it 32-bit or 64-bit?\n$ git --version --build-options\n\n** 2.16.1windows.2 **\n\n. Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?\n$ cmd.exe /c ver\n\n** Microsoft Windows [Version 10.0.16299.214] **\n. What options did you set as part of the installation? Or did you choose the\ndefaults?\n# One of the following:\n> type \"C:\\Program Files\\Git\\etc\\install-options.txt\"\n> type \"C:\\Program Files (x86)\\Git\\etc\\install-options.txt\"\n> type \"%USERPROFILE%\\AppData\\Local\\Programs\\Git\\etc\\install-options.txt\"\n$ cat /etc/install-options.txt\n\n** insert your machine's response here **\n. Any other interesting things about your environment that might be related\nto the issue you're seeing?\n** insert your response here **\nDetails\n. Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other\n** insert your response here **\n. What commands did you run to trigger this issue? If you can provide a\nhttp://stackoverflow.com/help/mcve\nthis will help us understand the issue.\n** insert your commands here **\n. What did you expect to occur after running these commands?\n** insert here **\n. What actually happened instead?\n** insert here **\n. If the problem was occurring with a specific repository, can you provide the\nURL to that repository to help us with testing?\n** insert URL here **\nDescription\nUnder ~/.ssh are only one ssh key pair of type ed25519\n( id_ed25519 and id_ed25519.pub)\nGit GUI don't show it\nC:\\Users\\goldfinger2\\.ssh>dir /b\nagent.env\nauthorized_keys\nid_ed25519\nid_ed25519.pub\nWin32-OpenSSH Beta currently supports only one key type (ed25519).\nhttps://github.com/PowerShell/Win32-OpenSSH/issues/973\nhttps://blogs.msdn.microsoft.com/powershell/2017/12/15/using-the-openssh-beta-in-windows-10-fall-creators-update-and-windows-server-1709/\nSteps to Reproduce\n1. Open Git Gui\n2. Select Help\n3. Show SSH Key : No Keys found\nExpected behavior: Showing the ed25519 Key\nReproduces how often: 100%\nAdditional information\nThe problem is located in the find_ssh_key function in sshkey.tcl.\nWhich is not searching after id_ed25519.pub\nfind_ssh_key {} {\n\n        foreach name {~/.ssh/id_dsa.pub ~/.ssh/id_rsa.pub ~/.ssh/identity.pub} {\n\n>> This looks like a problem in upstream Git GUI. Would you mind reporting this to the Git mailing list at git@vger.kernel.org? \n>> Or even better, write the patch yourself? ;-) This looks like a problem in upstream Git GUI. \n>> Would you mind reporting this to the Git mailing list at git@vger.kernel.org? Or even better, write the patch yourself? ;-) \n\n"},{"id":"340183","messageId":"20180224183913.8345-1-dev+git@drbeat.li","threadId":"47796","inReplyTo":"F65780F29E48994380E2BCE87C6F071101146AB1@DEERLM99EX2MSX.ww931.my-it-solutions.net","subject":"[PATCH] git-gui: search for all current SSH key types","fromName":"Beat Bolli","fromEmail":"dev+git@drbeat.li","sentAt":"2018-02-24T18:39:13Z","receivedAt":"2018-02-24T18:49:36Z","isPatch":true,"sender":{"key":"dev+git@drbeat.li","avatar":"https://avatars.githubusercontent.com/u/21444?v=4"},"body":"OpenSSH has supported Ed25519 keys since version 6.4 (2014-01-30), and\nECDSA keys since version 5.7 (2011-01-24). git-gui fails to find these\nkey types in its Help/Show SSH Key dialog.\n\nTeach git-gui to show Ed25519 and ECDSA keys as well.\n\nThis was originally reported in\nhttps://github.com/git-for-windows/git/issues/1487 and subseqently in\nhttps://public-inbox.org/git/F65780F29E48994380E2BCE87C6F071101146AB1@DEERLM99EX2MSX.ww931.my-it-solutions.net/\n\nSigned-off-by: Beat Bolli <dev+git@drbeat.li>\n---\nCc: Alexander Gavrilov <angavrilov@gmail.com>\nCc: Pat Thoyts <patthoyts@users.sourceforge.net>\n\n git-gui/lib/sshkey.tcl | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/git-gui/lib/sshkey.tcl b/git-gui/lib/sshkey.tcl\nindex aa6457bbb..589ff8f78 100644\n--- a/git-gui/lib/sshkey.tcl\n+++ b/git-gui/lib/sshkey.tcl\n@@ -2,7 +2,10 @@\n # Copyright (C) 2006, 2007 Shawn Pearce\n \n proc find_ssh_key {} {\n-\tforeach name {~/.ssh/id_dsa.pub ~/.ssh/id_rsa.pub ~/.ssh/identity.pub} {\n+\tforeach name {\n+\t\t~/.ssh/id_dsa.pub ~/.ssh/id_ecdsa.pub ~/.ssh/id_ed25519.pub\n+\t\t~/.ssh/id_rsa.pub ~/.ssh/identity.pub\n+\t} {\n \t\tif {[file exists $name]} {\n \t\t\tset fh    [open $name r]\n \t\t\tset cont  [read $fh]\n-- \n2.15.0.rc1.299.gda03b47c3\n\n"}]}