{"thread":{"id":"47775","subject":"[PATCH] t0050: remove the unused $test_case variable","startedAt":"2018-02-06T23:13:24Z","lastAt":"2018-02-07T19:08:17Z","messageCount":5,"participants":["Ævar Arnfjörð Bjarmason","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"338546","messageId":"20180206231303.8483-1-avarab@gmail.com","threadId":"47775","inReplyTo":null,"subject":"[PATCH] t0050: remove the unused $test_case variable","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-02-06T23:13:03Z","receivedAt":"2018-02-06T23:13:24Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The $test_case variable hasn't been used since\ndecd3c0c28 (\"t0050-*.sh: mark the rename (case change) test as\npassing\", 2014-11-28) when its last user went away.\n\nLet's remove the \"say\" as well, since it's obvious from subsequent\noutput that we're testing on a case sensitive filesystem.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/t0050-filesystem.sh | 8 --------\n 1 file changed, 8 deletions(-)\n\ndiff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh\nindex b29d749bb7..606ffddd92 100755\n--- a/t/t0050-filesystem.sh\n+++ b/t/t0050-filesystem.sh\n@@ -7,14 +7,6 @@ test_description='Various filesystem issues'\n auml=$(printf '\\303\\244')\n aumlcdiar=$(printf '\\141\\314\\210')\n \n-if test_have_prereq CASE_INSENSITIVE_FS\n-then\n-\tsay \"will test on a case insensitive filesystem\"\n-\ttest_case=test_expect_failure\n-else\n-\ttest_case=test_expect_success\n-fi\n-\n if test_have_prereq UTF8_NFD_TO_NFC\n then\n \tsay \"will test on a unicode corrupting filesystem\"\n-- \n2.15.1.424.g9478a66081\n\n"},{"id":"338590","messageId":"bf3ad52d-4aa3-8678-9466-3996f6cba11c@kdbg.org","threadId":"47775","inReplyTo":"20180206231303.8483-1-avarab@gmail.com","subject":"Re: [PATCH] t0050: remove the unused $test_case variable","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2018-02-07T07:20:11Z","receivedAt":"2018-02-07T07:20:18Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 07.02.2018 um 00:13 schrieb Ævar Arnfjörð Bjarmason:\n> The $test_case variable hasn't been used since\n> decd3c0c28 (\"t0050-*.sh: mark the rename (case change) test as\n> passing\", 2014-11-28) when its last user went away.\n> \n> Let's remove the \"say\" as well, since it's obvious from subsequent\n> output that we're testing on a case sensitive filesystem.\n\nAm I misunderstanding the message? I think it reports properties of the \ntest environment. And the tests do run on case-insensitive filesystems. \nIMO, the message should be kept.\n\n> \n> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> ---\n>   t/t0050-filesystem.sh | 8 --------\n>   1 file changed, 8 deletions(-)\n> \n> diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh\n> index b29d749bb7..606ffddd92 100755\n> --- a/t/t0050-filesystem.sh\n> +++ b/t/t0050-filesystem.sh\n> @@ -7,14 +7,6 @@ test_description='Various filesystem issues'\n>   auml=$(printf '\\303\\244')\n>   aumlcdiar=$(printf '\\141\\314\\210')\n>   \n> -if test_have_prereq CASE_INSENSITIVE_FS\n> -then\n> -\tsay \"will test on a case insensitive filesystem\"\n> -\ttest_case=test_expect_failure\n> -else\n> -\ttest_case=test_expect_success\n> -fi\n> -\n>   if test_have_prereq UTF8_NFD_TO_NFC\n>   then\n>   \tsay \"will test on a unicode corrupting filesystem\"\n> \n"},{"id":"338593","messageId":"87fu6dz0h6.fsf@evledraar.gmail.com","threadId":"47775","inReplyTo":"bf3ad52d-4aa3-8678-9466-3996f6cba11c@kdbg.org","subject":"Re: [PATCH] t0050: remove the unused $test_case variable","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-02-07T08:07:49Z","receivedAt":"2018-02-07T08:07:59Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Wed, Feb 07 2018, Johannes Sixt jotted:\n\n> Am 07.02.2018 um 00:13 schrieb Ævar Arnfjörð Bjarmason:\n>> The $test_case variable hasn't been used since\n>> decd3c0c28 (\"t0050-*.sh: mark the rename (case change) test as\n>> passing\", 2014-11-28) when its last user went away.\n>>\n>> Let's remove the \"say\" as well, since it's obvious from subsequent\n>> output that we're testing on a case sensitive filesystem.\n>\n> Am I misunderstanding the message? I think it reports properties of\n> the test environment. And the tests do run on case-insensitive\n> filesystems. IMO, the message should be kept.\n\nIt's obvious from subsequent output whether the FS is case sensitive or\nnot, so I thought it was redundant to keep this report at the top since\nwe didn't have the variable setting anymore.\n"},{"id":"338650","messageId":"a8bc404e-fca8-6d64-21c4-df6d6879bee7@kdbg.org","threadId":"47775","inReplyTo":"87fu6dz0h6.fsf@evledraar.gmail.com","subject":"Re: [PATCH] t0050: remove the unused $test_case variable","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2018-02-07T18:42:46Z","receivedAt":"2018-02-07T18:42:55Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 07.02.2018 um 09:07 schrieb Ævar Arnfjörð Bjarmason:\n> \n> On Wed, Feb 07 2018, Johannes Sixt jotted:\n> \n>> Am 07.02.2018 um 00:13 schrieb Ævar Arnfjörð Bjarmason:\n>>> The $test_case variable hasn't been used since\n>>> decd3c0c28 (\"t0050-*.sh: mark the rename (case change) test as\n>>> passing\", 2014-11-28) when its last user went away.\n>>>\n>>> Let's remove the \"say\" as well, since it's obvious from subsequent\n>>> output that we're testing on a case sensitive filesystem.\n>>\n>> Am I misunderstanding the message? I think it reports properties of\n>> the test environment. And the tests do run on case-insensitive\n>> filesystems. IMO, the message should be kept.\n> \n> It's obvious from subsequent output whether the FS is case sensitive or\n> not, so I thought it was redundant to keep this report at the top since\n> we didn't have the variable setting anymore.\n\nThere are test cases that do different things depending on whether the \nCASE_INSENSITIVE_FS prerequisite is set. I think it was the intent to \nreport whether it is set and not whether one or the other value of the \n(now unused) variable is used somewhere.\n\nBTW, the message texts do not show which variant is taken (these are \nwithout your patch):\n\nOn Windows:\n\nt>sh t0050-filesystem.sh\nwill test on a case insensitive filesystem\nwill test on a filesystem lacking symbolic links\nok 1 - detection of case insensitive filesystem during repo init\nok 2 - detection of filesystem w/o symlink support during repo init\nok 3 - setup case tests\nok 4 - rename (case change)\nok 5 - merge (case change)\nnot ok 6 - add (with different case) # TODO known breakage\nok 7 - setup unicode normalization tests\nok 8 - rename (silent unicode normalization)\nok 9 - merge (silent unicode normalization)\n# still have 1 known breakage(s)\n# passed all remaining 8 test(s)\n1..9\n\nOn Linux:\n\nt@master:1002> ./t0050-filesystem.sh\nok 1 - detection of case insensitive filesystem during repo init\nok 2 - detection of filesystem w/o symlink support during repo init\nok 3 - setup case tests\nok 4 - rename (case change)\nok 5 - merge (case change)\nok 6 # skip add (with different case) (missing CASE_INSENSITIVE_FS)\nok 7 - setup unicode normalization tests\nok 8 - rename (silent unicode normalization)\nok 9 - merge (silent unicode normalization)\n# passed all 9 test(s)\n1..9\n\nI'd even argue that there should be messages on Linux, too.\n\n-- Hannes\n"},{"id":"338653","messageId":"87k1vomxd3.fsf@evledraar.gmail.com","threadId":"47775","inReplyTo":"a8bc404e-fca8-6d64-21c4-df6d6879bee7@kdbg.org","subject":"Re: [PATCH] t0050: remove the unused $test_case variable","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-02-07T19:08:08Z","receivedAt":"2018-02-07T19:08:17Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Wed, Feb 07 2018, Johannes Sixt jotted:\n\n> Am 07.02.2018 um 09:07 schrieb Ævar Arnfjörð Bjarmason:\n>>\n>> On Wed, Feb 07 2018, Johannes Sixt jotted:\n>>\n>>> Am 07.02.2018 um 00:13 schrieb Ævar Arnfjörð Bjarmason:\n>>>> The $test_case variable hasn't been used since\n>>>> decd3c0c28 (\"t0050-*.sh: mark the rename (case change) test as\n>>>> passing\", 2014-11-28) when its last user went away.\n>>>>\n>>>> Let's remove the \"say\" as well, since it's obvious from subsequent\n>>>> output that we're testing on a case sensitive filesystem.\n>>>\n>>> Am I misunderstanding the message? I think it reports properties of\n>>> the test environment. And the tests do run on case-insensitive\n>>> filesystems. IMO, the message should be kept.\n>>\n>> It's obvious from subsequent output whether the FS is case sensitive or\n>> not, so I thought it was redundant to keep this report at the top since\n>> we didn't have the variable setting anymore.\n>\n> There are test cases that do different things depending on whether the\n> CASE_INSENSITIVE_FS prerequisite is set. I think it was the intent to\n> report whether it is set and not whether one or the other value of the\n> (now unused) variable is used somewhere.\n>\n> BTW, the message texts do not show which variant is taken (these are\n> without your patch):\n>\n> On Windows:\n>\n> t>sh t0050-filesystem.sh\n> will test on a case insensitive filesystem\n> will test on a filesystem lacking symbolic links\n> ok 1 - detection of case insensitive filesystem during repo init\n> ok 2 - detection of filesystem w/o symlink support during repo init\n> ok 3 - setup case tests\n> ok 4 - rename (case change)\n> ok 5 - merge (case change)\n> not ok 6 - add (with different case) # TODO known breakage\n> ok 7 - setup unicode normalization tests\n> ok 8 - rename (silent unicode normalization)\n> ok 9 - merge (silent unicode normalization)\n> # still have 1 known breakage(s)\n> # passed all remaining 8 test(s)\n> 1..9\n>\n> On Linux:\n>\n> t@master:1002> ./t0050-filesystem.sh\n> ok 1 - detection of case insensitive filesystem during repo init\n> ok 2 - detection of filesystem w/o symlink support during repo init\n> ok 3 - setup case tests\n> ok 4 - rename (case change)\n> ok 5 - merge (case change)\n> ok 6 # skip add (with different case) (missing CASE_INSENSITIVE_FS)\n> ok 7 - setup unicode normalization tests\n> ok 8 - rename (silent unicode normalization)\n> ok 9 - merge (silent unicode normalization)\n> # passed all 9 test(s)\n> 1..9\n>\n> I'd even argue that there should be messages on Linux, too.\n\nThanks. Let's just drop this patch. I thought it would still print out\nsomething similar to that \"missing CASE_INSENSITIVE_FS\" at a quick\nglance last night, but was obviously wrong.\n"}]}