{"thread":{"id":"47752","subject":"[GSoC][PATCH] commit: add a commit.signOff config variable","startedAt":"2018-02-04T02:03:31Z","lastAt":"2018-02-06T07:02:13Z","messageCount":5,"participants":["Chen Jingpiao","Eric Sunshine","Ævar Arnfjörð Bjarmason","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"338155","messageId":"20180204020318.4363-1-chenjingpiao@gmail.com","threadId":"47752","inReplyTo":null,"subject":"[GSoC][PATCH] commit: add a commit.signOff config variable","fromName":"Chen Jingpiao","fromEmail":"chenjingpiao@gmail.com","sentAt":"2018-02-04T02:03:18Z","receivedAt":"2018-02-04T02:03:31Z","isPatch":true,"sender":{"key":"chenjingpiao@gmail.com","avatar":null},"body":"Add the commit.signOff configuration variable to use the -s or --signoff\noption of git commit by default.\n\nSigned-off-by: Chen Jingpiao <chenjingpiao@gmail.com>\n---\n\nThough we can configure signoff using format.signOff variable. Someone like to\nadd Signed-off-by line by the committer.\n\n Documentation/config.txt     |  4 +++\n Documentation/git-commit.txt |  2 ++\n builtin/commit.c             |  4 +++\n t/t7501-commit.sh            | 69 ++++++++++++++++++++++++++++++++++++++++++++\n 4 files changed, 79 insertions(+)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 0e25b2c92..5dec3f0cb 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1303,6 +1303,10 @@ commit.gpgSign::\n \tconvenient to use an agent to avoid typing your GPG passphrase\n \tseveral times.\n \n+commit.signOff::\n+\tA boolean value which lets you enable the `-s/--signoff` option of\n+\t`git commit` by default. See linkgit:git-commit[1].\n+\n commit.status::\n \tA boolean to enable/disable inclusion of status information in the\n \tcommit message template when using an editor to prepare the commit\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex f970a4342..7a28ea765 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -166,6 +166,8 @@ The `-m` option is mutually exclusive with `-c`, `-C`, and `-F`.\n \tthe rights to submit this work under the same license and\n \tagrees to a Developer Certificate of Origin\n \t(see http://developercertificate.org/ for more information).\n+\tSee the `commit.signOff` configuration variable in\n+\tlinkgit:git-config[1].\n \n -n::\n --no-verify::\ndiff --git a/builtin/commit.c b/builtin/commit.c\nindex 4610e3d8e..324213254 100644\n--- a/builtin/commit.c\n+++ b/builtin/commit.c\n@@ -1548,6 +1548,10 @@ static int git_commit_config(const char *k, const char *v, void *cb)\n \t\tsign_commit = git_config_bool(k, v) ? \"\" : NULL;\n \t\treturn 0;\n \t}\n+\tif (!strcmp(k, \"commit.signoff\")) {\n+\t\tsignoff = git_config_bool(k, v);\n+\t\treturn 0;\n+\t}\n \tif (!strcmp(k, \"commit.verbose\")) {\n \t\tint is_bool;\n \t\tconfig_commit_verbose = git_config_bool_or_int(k, v, &is_bool);\ndiff --git a/t/t7501-commit.sh b/t/t7501-commit.sh\nindex fa61b1a4e..46733ed2a 100755\n--- a/t/t7501-commit.sh\n+++ b/t/t7501-commit.sh\n@@ -505,6 +505,75 @@ Myfooter: x\" &&\n \ttest_cmp expected actual\n '\n \n+test_expect_success \"commit.signoff=true and --signoff omitted\" '\n+\techo 7 >positive &&\n+\tgit add positive &&\n+\tgit -c commit.signoff=true commit -m \"thank you\" &&\n+\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n+\t(\n+\t\techo thank you\n+\t\techo\n+\t\tgit var GIT_COMMITTER_IDENT |\n+\t\tsed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n+\t) >expected &&\n+\ttest_cmp expected actual\n+'\n+\n+test_expect_success \"commit.signoff=true and --signoff\" '\n+\techo 8 >positive &&\n+\tgit add positive &&\n+\tgit -c commit.signoff=true commit --signoff -m \"thank you\" &&\n+\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n+\t(\n+\t\techo thank you\n+\t\techo\n+\t\tgit var GIT_COMMITTER_IDENT |\n+\t\tsed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n+\t) >expected &&\n+\ttest_cmp expected actual\n+'\n+\n+test_expect_success \"commit.signoff=true and --no-signoff\" '\n+\techo 9 >positive &&\n+\tgit add positive &&\n+\tgit -c commit.signoff=true commit --no-signoff -m \"thank you\" &&\n+\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n+\techo thank you >expected &&\n+\ttest_cmp expected actual\n+'\n+\n+test_expect_success \"commit.signoff=false and --signoff omitted\" '\n+\techo 10 >positive &&\n+\tgit add positive &&\n+\tgit -c commit.signoff=false commit -m \"thank you\" &&\n+\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n+\techo thank you >expected &&\n+\ttest_cmp expected actual\n+'\n+\n+test_expect_success \"commit.signoff=false and --signoff\" '\n+\techo 11 >positive &&\n+\tgit add positive &&\n+\tgit -c commit.signoff=false commit --signoff -m \"thank you\" &&\n+\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n+\t(\n+\t\techo thank you\n+\t\techo\n+\t\tgit var GIT_COMMITTER_IDENT |\n+\t\tsed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n+\t) >expected &&\n+\ttest_cmp expected actual\n+'\n+\n+test_expect_success \"commit.signoff=false and --no-signoff\" '\n+\techo 12 >positive &&\n+\tgit add positive &&\n+\tgit -c commit.signoff=false commit --no-signoff -m \"thank you\" &&\n+\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n+\techo thank you >expected &&\n+\ttest_cmp expected actual\n+'\n+\n test_expect_success 'multiple -m' '\n \n \t>negative &&\n-- \n2.16.1.70.g5ccd54536\n\n"},{"id":"338164","messageId":"20180204113135.GA28130@flurp.local","threadId":"47752","inReplyTo":"20180204020318.4363-1-chenjingpiao@gmail.com","subject":"Re: [GSoC][PATCH] commit: add a commit.signOff config variable","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-02-04T11:31:35Z","receivedAt":"2018-02-04T11:31:49Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Feb 04, 2018 at 10:03:18AM +0800, Chen Jingpiao wrote:\n> Add the commit.signOff configuration variable to use the -s or --signoff\n> option of git commit by default.\n> \n> Signed-off-by: Chen Jingpiao <chenjingpiao@gmail.com>\n> ---\n> \n> Though we can configure signoff using format.signOff variable. Someone like to\n> add Signed-off-by line by the committer.\n\nThis commentary explains why this feature is desirable, therefore it\nwould be a good idea to include this in the commit message itself.\n\n> diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh\n> @@ -505,6 +505,75 @@ Myfooter: x\" &&\n> +test_expect_success \"commit.signoff=true and --signoff omitted\" '\n> +\techo 7 >positive &&\n> +\tgit add positive &&\n> +\tgit -c commit.signoff=true commit -m \"thank you\" &&\n> +\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +\t(\n> +\t\techo thank you\n> +\t\techo\n> +\t\tgit var GIT_COMMITTER_IDENT |\n> +\t\tsed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n> +\t) >expected &&\n> +\ttest_cmp expected actual\n> +'\n\nThe bodies of these test are quite noisy, doing a lot of work that isn't\nreally necessary, which makes it difficult to figure out what is really\nbeing tested. Other tests in this script already check that the commit\nmessage is properly formatted when Signed-off-by: is inserted so you\ndon't need to repeat all that boilerplate here.\n\nInstead, you are interested only in whether or not Signed-off-by: has\nbeen added to the message. For that purpose, you can use a simple 'grep'\nexpression.\n\nThe amount of copy/paste code in these six tests is also unfortunate.\nRather than merely repeating the same code over and over, you could\ninstead parameterize the test. For instance, you could run all six tests\nvia a simple for-loop:\n\n--- >8 ---\nfor cfg in true false\ndo\n    for opt in '' --signoff --no-signoff\n    do\n        case \"$opt:$cfg\" in\n        --signoff:*|:true) expect= ;;\n        --no-signoff:*|:false) expect=! ;;\n        esac\n        test_expect_success \"commit.signoff=$cfg & ${opt:---signoff omitted}\" '\n            git -c commit.signoff=$cfg commit --allow-empty -m x $opt &&\n            eval \"$expect git log -1 --format=%B | grep ^Signed-off-by:\"\n        '\n    done\ndone\n--- >8 ---\n\nA final consideration is that tests run slowly on Windows, and although\nit's nice to be thorough by testing all six combinations, you can\nprobably exercise the new code sufficiently by instead testing just two\ncombinations. For instance, instead of all six combinations, test just\nthese two:\n\n--- >8 ---\ntest_expect_success 'commit.signoff=true & --signoff omitted' '\n    git -c commit.signoff=true commit --allow-empty -m x &&\n    git log -1 --format=%B | grep ^Signed-off-by:\n'\n\ntest_expect_success 'commit.signoff=true & --no-signoff' '\n    git -c commit.signoff=true commit --allow-empty -m x --no-signoff &&\n    ! git log -1 --format=%B | grep ^Signed-off-by:\n'\n--- >8 ---\n\n> +test_expect_success \"commit.signoff=true and --signoff\" '\n> +\techo 8 >positive &&\n> +\tgit add positive &&\n> +\tgit -c commit.signoff=true commit --signoff -m \"thank you\" &&\n> +\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +\t(\n> +\t\techo thank you\n> +\t\techo\n> +\t\tgit var GIT_COMMITTER_IDENT |\n> +\t\tsed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n> +\t) >expected &&\n> +\ttest_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=true and --no-signoff\" '\n> +\techo 9 >positive &&\n> +\tgit add positive &&\n> +\tgit -c commit.signoff=true commit --no-signoff -m \"thank you\" &&\n> +\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +\techo thank you >expected &&\n> +\ttest_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=false and --signoff omitted\" '\n> +\techo 10 >positive &&\n> +\tgit add positive &&\n> +\tgit -c commit.signoff=false commit -m \"thank you\" &&\n> +\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +\techo thank you >expected &&\n> +\ttest_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=false and --signoff\" '\n> +\techo 11 >positive &&\n> +\tgit add positive &&\n> +\tgit -c commit.signoff=false commit --signoff -m \"thank you\" &&\n> +\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +\t(\n> +\t\techo thank you\n> +\t\techo\n> +\t\tgit var GIT_COMMITTER_IDENT |\n> +\t\tsed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n> +\t) >expected &&\n> +\ttest_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=false and --no-signoff\" '\n> +\techo 12 >positive &&\n> +\tgit add positive &&\n> +\tgit -c commit.signoff=false commit --no-signoff -m \"thank you\" &&\n> +\tgit cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +\techo thank you >expected &&\n> +\ttest_cmp expected actual\n> +'\n"},{"id":"338172","messageId":"87zi4olgwh.fsf@evledraar.gmail.com","threadId":"47752","inReplyTo":"20180204113135.GA28130@flurp.local","subject":"Re: [GSoC][PATCH] commit: add a commit.signOff config variable","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-02-04T18:59:58Z","receivedAt":"2018-02-04T19:00:10Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Sun, Feb 04 2018, Eric Sunshine jotted:\n\n> --- >8 ---\n> for cfg in true false\n> do\n>     for opt in '' --signoff --no-signoff\n>     do\n>         case \"$opt:$cfg\" in\n>         --signoff:*|:true) expect= ;;\n>         --no-signoff:*|:false) expect=! ;;\n>         esac\n>         test_expect_success \"commit.signoff=$cfg & ${opt:---signoff omitted}\" '\n>             git -c commit.signoff=$cfg commit --allow-empty -m x $opt &&\n>             eval \"$expect git log -1 --format=%B | grep ^Signed-off-by:\"\n>         '\n>     done\n> done\n> --- >8 ---\n>\n> A final consideration is that tests run slowly on Windows, and although\n> it's nice to be thorough by testing all six combinations, you can\n> probably exercise the new code sufficiently by instead testing just two\n> combinations. For instance, instead of all six combinations, test just\n> these two:\n>\n> --- >8 ---\n> test_expect_success 'commit.signoff=true & --signoff omitted' '\n>     git -c commit.signoff=true commit --allow-empty -m x &&\n>     git log -1 --format=%B | grep ^Signed-off-by:\n> '\n>\n> test_expect_success 'commit.signoff=true & --no-signoff' '\n>     git -c commit.signoff=true commit --allow-empty -m x --no-signoff &&\n>     ! git log -1 --format=%B | grep ^Signed-off-by:\n> '\n> --- >8 ---\n\nI just skimmed this, but just to this question. I don't think we need to\nworry about 2 v.s. 6 tests having an impact on Windows performance, it's\njust massive amounts of tests like my in-flight wildmatch test series\nthat really matter.\n\nBut if we are worring about 2 v.s. 6 there's always my in-flight\nEXPENSIVE_ON_WINDOWS prereq :)\n"},{"id":"338258","messageId":"CAGZ79kZgqDp49McgtzWRbArsK6qVz1E9Syi5tJo73F-+T4UOiA@mail.gmail.com","threadId":"47752","inReplyTo":"20180204020318.4363-1-chenjingpiao@gmail.com","subject":"Re: [GSoC][PATCH] commit: add a commit.signOff config variable","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-02-05T21:50:41Z","receivedAt":"2018-02-05T21:50:47Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Sat, Feb 3, 2018 at 6:03 PM, Chen Jingpiao <chenjingpiao@gmail.com> wrote:\n> Add the commit.signOff configuration variable to use the -s or --signoff\n> option of git commit by default.\n>\n> Signed-off-by: Chen Jingpiao <chenjingpiao@gmail.com>\n> ---\n\nWelcome to the Git community!\n\n>\n> Though we can configure signoff using format.signOff variable. Someone like to\n> add Signed-off-by line by the committer.\n\nThere is more discussion about this at\nhttps://public-inbox.org/git/1482946838-28779-1-git-send-email-ehabkost@redhat.com/\nspecifically\nhttps://public-inbox.org/git/xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com/\n\nNot sure if there was any other reasons and discussions brought up\nsince then, but that discussion seems to not favor patches that\nadd .signoff options.\n\nThanks,\nStefan\n\n>\n>  Documentation/config.txt     |  4 +++\n>  Documentation/git-commit.txt |  2 ++\n>  builtin/commit.c             |  4 +++\n>  t/t7501-commit.sh            | 69 ++++++++++++++++++++++++++++++++++++++++++++\n>  4 files changed, 79 insertions(+)\n>\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index 0e25b2c92..5dec3f0cb 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -1303,6 +1303,10 @@ commit.gpgSign::\n>         convenient to use an agent to avoid typing your GPG passphrase\n>         several times.\n>\n> +commit.signOff::\n> +       A boolean value which lets you enable the `-s/--signoff` option of\n> +       `git commit` by default. See linkgit:git-commit[1].\n> +\n>  commit.status::\n>         A boolean to enable/disable inclusion of status information in the\n>         commit message template when using an editor to prepare the commit\n> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\n> index f970a4342..7a28ea765 100644\n> --- a/Documentation/git-commit.txt\n> +++ b/Documentation/git-commit.txt\n> @@ -166,6 +166,8 @@ The `-m` option is mutually exclusive with `-c`, `-C`, and `-F`.\n>         the rights to submit this work under the same license and\n>         agrees to a Developer Certificate of Origin\n>         (see http://developercertificate.org/ for more information).\n> +       See the `commit.signOff` configuration variable in\n> +       linkgit:git-config[1].\n>\n>  -n::\n>  --no-verify::\n> diff --git a/builtin/commit.c b/builtin/commit.c\n> index 4610e3d8e..324213254 100644\n> --- a/builtin/commit.c\n> +++ b/builtin/commit.c\n> @@ -1548,6 +1548,10 @@ static int git_commit_config(const char *k, const char *v, void *cb)\n>                 sign_commit = git_config_bool(k, v) ? \"\" : NULL;\n>                 return 0;\n>         }\n> +       if (!strcmp(k, \"commit.signoff\")) {\n> +               signoff = git_config_bool(k, v);\n> +               return 0;\n> +       }\n>         if (!strcmp(k, \"commit.verbose\")) {\n>                 int is_bool;\n>                 config_commit_verbose = git_config_bool_or_int(k, v, &is_bool);\n> diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh\n> index fa61b1a4e..46733ed2a 100755\n> --- a/t/t7501-commit.sh\n> +++ b/t/t7501-commit.sh\n> @@ -505,6 +505,75 @@ Myfooter: x\" &&\n>         test_cmp expected actual\n>  '\n>\n> +test_expect_success \"commit.signoff=true and --signoff omitted\" '\n> +       echo 7 >positive &&\n> +       git add positive &&\n> +       git -c commit.signoff=true commit -m \"thank you\" &&\n> +       git cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +       (\n> +               echo thank you\n> +               echo\n> +               git var GIT_COMMITTER_IDENT |\n> +               sed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n> +       ) >expected &&\n> +       test_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=true and --signoff\" '\n> +       echo 8 >positive &&\n> +       git add positive &&\n> +       git -c commit.signoff=true commit --signoff -m \"thank you\" &&\n> +       git cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +       (\n> +               echo thank you\n> +               echo\n> +               git var GIT_COMMITTER_IDENT |\n> +               sed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n> +       ) >expected &&\n> +       test_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=true and --no-signoff\" '\n> +       echo 9 >positive &&\n> +       git add positive &&\n> +       git -c commit.signoff=true commit --no-signoff -m \"thank you\" &&\n> +       git cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +       echo thank you >expected &&\n> +       test_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=false and --signoff omitted\" '\n> +       echo 10 >positive &&\n> +       git add positive &&\n> +       git -c commit.signoff=false commit -m \"thank you\" &&\n> +       git cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +       echo thank you >expected &&\n> +       test_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=false and --signoff\" '\n> +       echo 11 >positive &&\n> +       git add positive &&\n> +       git -c commit.signoff=false commit --signoff -m \"thank you\" &&\n> +       git cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +       (\n> +               echo thank you\n> +               echo\n> +               git var GIT_COMMITTER_IDENT |\n> +               sed -e \"s/>.*/>/\" -e \"s/^/Signed-off-by: /\"\n> +       ) >expected &&\n> +       test_cmp expected actual\n> +'\n> +\n> +test_expect_success \"commit.signoff=false and --no-signoff\" '\n> +       echo 12 >positive &&\n> +       git add positive &&\n> +       git -c commit.signoff=false commit --no-signoff -m \"thank you\" &&\n> +       git cat-file commit HEAD | sed -e \"1,/^\\$/d\" >actual &&\n> +       echo thank you >expected &&\n> +       test_cmp expected actual\n> +'\n> +\n>  test_expect_success 'multiple -m' '\n>\n>         >negative &&\n> --\n> 2.16.1.70.g5ccd54536\n>\n"},{"id":"338483","messageId":"20180206070151.GA16810@ppiao","threadId":"47752","inReplyTo":"CAGZ79kZgqDp49McgtzWRbArsK6qVz1E9Syi5tJo73F-+T4UOiA@mail.gmail.com","subject":"Re: [GSoC][PATCH] commit: add a commit.signOff config variable","fromName":"Chen Jingpiao","fromEmail":"chenjingpiao@gmail.com","sentAt":"2018-02-06T07:01:51Z","receivedAt":"2018-02-06T07:02:13Z","isPatch":true,"sender":{"key":"chenjingpiao@gmail.com","avatar":null},"body":"On 02/05 01:50, Stefan Beller wrote:\n> On Sat, Feb 3, 2018 at 6:03 PM, Chen Jingpiao <chenjingpiao@gmail.com> wrote:\n> > Add the commit.signOff configuration variable to use the -s or --signoff\n> > option of git commit by default.\n> >\n> > Signed-off-by: Chen Jingpiao <chenjingpiao@gmail.com>\n> > ---\n> \n> Welcome to the Git community!\n> \n> >\n> > Though we can configure signoff using format.signOff variable. Someone like to\n> > add Signed-off-by line by the committer.\n> \n> There is more discussion about this at\n> https://public-inbox.org/git/1482946838-28779-1-git-send-email-ehabkost@redhat.com/\n> specifically\n> https://public-inbox.org/git/xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com/\n> \n> Not sure if there was any other reasons and discussions brought up\n> since then, but that discussion seems to not favor patches that\n> add .signoff options.\n\nThank you.\n\nI agree with Johannes Schindelin once said \"a signoff _has_ to be a conscious\nact, or else  it will lose its meaning.\"\nI think I shouldn't add this configuration variable.\n\nWhen add configuration variable for sign-off to format-patch have some discussion:\n\thttps://public-inbox.org/git/20090331204338.GA88381@macbook.lan/\n\thttps://public-inbox.org/git/20090401102610.GC26181@coredump.intra.peff.net/\n\thttps://public-inbox.org/git/7veiw69p26.fsf@gitster.siamese.dyndns.org/\n\n--\nChen Jingpiao\n"}]}