{"thread":{"id":"47723","subject":"Re: [PATCH v1 0/5] Incremental rewrite of git-submodules: git-foreach","startedAt":"2018-01-30T20:37:10Z","lastAt":"2018-02-02T05:00:46Z","messageCount":2,"participants":["Stefan Beller","Prathamesh Chavan"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"337806","messageId":"CAGZ79kbVbUQGx84ynhG6DnOMNy4Qv1Og3ykRGqCNbNAswwnBfw@mail.gmail.com","threadId":"47723","inReplyTo":"20180129193453.3438-1-pc44800@gmail.com","subject":"Re: [PATCH v1 0/5] Incremental rewrite of git-submodules: git-foreach","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-01-30T20:37:01Z","receivedAt":"2018-01-30T20:37:10Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Mon, Jan 29, 2018 at 11:34 AM, Prathamesh Chavan <pc44800@gmail.com> wrote:\n> Following series of patches focuses on porting submodule subcommand\n> git-foreach from shell to C.\n> An initial attempt for porting was introduced about 9 months back,\n> and since then then patches have undergone many changes. Some of the\n> notable discussion thread which I would like to point out is: [1]\n> The previous version of this patch series which was floated is\n> available at: [2].\n>\n> The following changes were made to that:\n> * As it was observed in other submodule subcommand's ported function\n>   that the number of params increased a lot, the variables quiet and\n>   recursive, were replaced in the cb_foreach struct with a single\n>   unsigned integer variable called flags.\n>\n> * To accomodate the possiblity of a direct call to the functions\n>   runcommand_in_submodule(), callback function\n>   runcommand_in_submodule_cb() was introduced.\n>\n> [1]: https://public-inbox.org/git/20170419170513.16475-1-pc44800@gmail.com/T/#u\n> [2]: https://public-inbox.org/git/20170807211900.15001-14-pc44800@gmail.com/\n>\n> As before you can find this series at:\n> https://github.com/pratham-pc/git/commits/patch-series-3\n>\n> And its build report is available at:\n> https://travis-ci.org/pratham-pc/git/builds/\n> Branch: patch-series-3\n> Build #202\n>\n> Prathamesh Chavan (5):\n>   submodule foreach: correct '$path' in nested submodules from a\n>     subdirectory\n>   submodule foreach: document '$sm_path' instead of '$path'\n>   submodule foreach: clarify the '$toplevel' variable documentation\n>   submodule foreach: document variable '$displaypath'\n>   submodule: port submodule subcommand 'foreach' from shell to C\n>\n>  Documentation/git-submodule.txt |  15 ++--\n>  builtin/submodule--helper.c     | 151 ++++++++++++++++++++++++++++++++++++++++\n>  git-submodule.sh                |  40 +----------\n>  t/t7407-submodule-foreach.sh    |  38 +++++++++-\n>  4 files changed, 197 insertions(+), 47 deletions(-)\n\nThanks for bringing this series up again, my review still holds.\n\nThanks,\nStefan\n"},{"id":"338077","messageId":"CAME+mvXPKO6f1j9htMCj32GCf5aeTkMLEzM83stwLVEHXc4yFg@mail.gmail.com","threadId":"47723","inReplyTo":"CAGZ79kbVbUQGx84ynhG6DnOMNy4Qv1Og3ykRGqCNbNAswwnBfw@mail.gmail.com","subject":"Re: [PATCH v1 0/5] Incremental rewrite of git-submodules: git-foreach","fromName":"Prathamesh Chavan","fromEmail":"pc44800@gmail.com","sentAt":"2018-02-02T05:00:40Z","receivedAt":"2018-02-02T05:00:46Z","isPatch":true,"sender":{"key":"pc44800@gmail.com","avatar":"https://avatars.githubusercontent.com/u/17272661?v=4"},"body":"Since due to some reason, the previous patch-series list was\nunavailable on the mailing list, I have re-posted the series.\nIt is available at:\nhttps://public-inbox.org/git/20180202045745.5076-1-pc44800@gmail.com/\n\nThanks,\nPrathamesh Chavan\n"}]}