{"thread":{"id":"4768","subject":"[PATCH] Beautifulise git-show output","startedAt":"2006-07-04T22:34:50Z","lastAt":"2006-07-04T22:59:06Z","messageCount":3,"participants":["beber.mailing@gmail.com","Junio C Hamano","Bertrand Jacquin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"23251","messageId":"11520525682686-git-send-email-beber.mailing@gmail.com","threadId":"4768","inReplyTo":null,"subject":"[PATCH] Beautifulise git-show output","fromName":"","fromEmail":"beber.mailing@gmail.com","sentAt":"2006-07-04T22:34:50Z","receivedAt":"2006-07-04T22:34:50Z","isPatch":true,"sender":{"key":"beber.mailing@gmail.com","avatar":null},"body":"From: Bertrand Jacquin (Beber) <beber.mailing@gmail.com>\n\ndiff --git a/log-tree.c b/log-tree.c\nindex ebb49f2..55f77ad 100644\n--- a/log-tree.c\n+++ b/log-tree.c\n@@ -164,7 +164,7 @@ int log_tree_diff_flush(struct rev_info \n \t}\n \n \tif (opt->loginfo && !opt->no_commit_id)\n-\t\tshow_log(opt, opt->loginfo, opt->diffopt.with_stat ? \"---\\n\" : \"\\n\");\n+\t\tshow_log(opt, opt->loginfo, opt->diffopt.with_stat ? \"\\n---\\n\" : \"\\n\");\n \tdiff_flush(&opt->diffopt);\n \treturn 1;\n }\n-- \n1.4.1\n"},{"id":"23254","messageId":"7vejx1f0fz.fsf@assigned-by-dhcp.cox.net","threadId":"4768","inReplyTo":"11520525682686-git-send-email-beber.mailing@gmail.com","subject":"Re: [PATCH] Beautifulise git-show output","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-07-04T22:51:44Z","receivedAt":"2006-07-04T22:51:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Why?\n\nA patch like this needs to be justified with a bit more\nexplanation; the word \"beautiful\" is subjective.\n\n(current)\n\tChange this and that file\n\n        Signed-off-by: A U Thor <a.u.thor@example.com>\n\t---\n         this-file |   20 +++++++----\n\t that-file |    4 ++++\n\t 2 files changed, 20 insertions(+), 4 deletions(-)\n\n        diff --git a/this-file b/this-file\n\t...\n \n(yours -- and I think 1.3.0 did it like this)\n\tChange this and that file\n\n        Signed-off-by: A U Thor <a.u.thor@example.com>\n\n\t---\n         this-file |   20 +++++++----\n\t that-file |    4 ++++\n\t 2 files changed, 20 insertions(+), 4 deletions(-)\n\n        diff --git a/this-file b/this-file\n\t...\n \nIt _might_ be easier to read if it were like this, though:\n \n\tChange this and that file\n\n        Signed-off-by: A U Thor <a.u.thor@example.com>\n\t---\n\n         this-file |   20 +++++++----\n\t that-file |    4 ++++\n\t 2 files changed, 20 insertions(+), 4 deletions(-)\n\n        diff --git a/this-file b/this-file\n\t...\n\nHowever, the screen real estate, especially in the vertical\ndirection, is a scarce resource; I do not think the three-dash\nis a too weak visual separator that needs to be helped by an\nextra newline.\n"},{"id":"23256","messageId":"4fb292fa0607041559t5dad90e3h5e764348a8b4c562@mail.gmail.com","threadId":"4768","inReplyTo":"7vejx1f0fz.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Beautifulise git-show output","fromName":"Bertrand Jacquin","fromEmail":"beber.mailing@gmail.com","sentAt":"2006-07-04T22:59:06Z","receivedAt":"2006-07-04T22:59:06Z","isPatch":true,"sender":{"key":"beber.mailing@gmail.com","avatar":null},"body":"On 7/5/06, Junio C Hamano <junkio@cox.net> wrote:\n> Why?\n>\n> A patch like this needs to be justified with a bit more\n> explanation; the word \"beautiful\" is subjective.\n\nArg, git-send-email seems to made a bad job after git-format-patch, sorry.\n\nSo explanation don't go here. So here it is :\nGit-show actually show (for example) :\n\n    Makefile: Create Makefile for Beamer theme\n    rules are : install & uninstall (be careful on this one)\n\n    Also, I hacked presentation oral's Makefile to check them presence or not\n---\n\n docs/presentation_oral/Makefile        |    5 +-\n docs/presentation_oral/themes/Makefile |   91 ++++++++++++++++++++++++++++++++\n 2 files changed, 95 insertions(+), 1 deletions(-)\n create mode 100644 docs/presentation_oral/themes/Makefile\n\nI would like to have a newline after commit mesage too as there is one\nbefore diff-stat.\n\n-- \n# Beber : beber@gna.org\n# IM : beber@jabber.fr\n# http://guybrush.ath.cx, irc://irc.freenode.net/#{e.fr,gentoofr}\n"}]}