{"thread":{"id":"47647","subject":"RE: [PATCH v2 1/6] DO NOT APPLY Bypass GCC attributes on NonStop platform where used.","startedAt":"2018-01-19T22:42:31Z","lastAt":"2018-01-19T22:42:31Z","messageCount":1,"participants":["Randall S. Becker"],"isPatch":true,"patchVersion":2,"patchTotal":6},"messages":[{"id":"336950","messageId":"000d01d39176$c0b6cbd0$42246370$@nexbridge.com","threadId":"47647","inReplyTo":null,"subject":"RE: [PATCH v2 1/6] DO NOT APPLY Bypass GCC attributes on NonStop platform where used.","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-01-19T22:42:09Z","receivedAt":"2018-01-19T22:42:31Z","isPatch":true,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On January 19, 2018 3:29 PM, Ramsay Jones wrote:\n> On 19/01/18 17:34, randall.s.becker@rogers.com wrote:\n> > From: \"Randall S. Becker\" <rsbecker@nexbridge.com>\n> >\n> > * remote.c: force ignoring of GCC __attribute construct not supported\n> >   by c99 by defining it as an empty CPP macro.\n> >\n> > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>\n> > ---\n> >  remote.c | 4 ++++\n> >  1 file changed, 4 insertions(+)\n> >\n> > diff --git a/remote.c b/remote.c\n> > index 4e93753e1..c18f9de7f 100644\n> > --- a/remote.c\n> > +++ b/remote.c\n> > @@ -11,6 +11,10 @@\n> >  #include \"mergesort.h\"\n> >  #include \"argv-array.h\"\n> >\n> > +#if defined (__TANDEM)\n> > +#define __attribute(a)\n> > +#endif\n> > +\n> \n> Hmm, the only use of __attribute() I can find is in compat/regex/.\n> In particular, there is no use of __attribute() in regex.c.\n> [__attribute__() is used in regex.c]\n> \n> Is this an old patch which is no longer required?\n> \n> puzzled.\n\nAfter investigation, this patch can be dropped. The __attribute__ fix from git-compat-utils.h is actually being picked up correctly now (unlike our 2.8.5 port when it was required). I am suspecting that this was blocked by a configuration setting in config.mak.uname that got fixed when I got my hands on that file for a cleanup. The path through there is via #ifndef __GNUC__.\n\nCheers,\nRandall\n\n"}]}