{"thread":{"id":"47609","subject":"[PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings","startedAt":"2018-01-14T16:46:15Z","lastAt":"2018-01-14T18:21:07Z","messageCount":3,"participants":["randall.s.becker@rogers.com","Philip Oakley","Randall S. Becker"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"336585","messageId":"20180114164529.10120-1-randall.s.becker@rogers.com","threadId":"47609","inReplyTo":null,"subject":"[PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings","fromName":"","fromEmail":"randall.s.becker@rogers.com","sentAt":"2018-01-14T16:45:29Z","receivedAt":"2018-01-14T16:46:15Z","isPatch":true,"sender":{"key":"randall.s.becker@rogers.com","avatar":null},"body":"From: \"Randall S. Becker\" <rsbecker@nexbridge.com>\n\n* The while loop in the inline method hashmap_enable_item_counting\n  used an unneeded variable. The loop has been revised accordingly.\n\nSigned-off-by: Randall S. Becker <rsbecker@nexbridge.com>\n---\n hashmap.h | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/hashmap.h b/hashmap.h\nindex 7ce79f3..d375d9c 100644\n--- a/hashmap.h\n+++ b/hashmap.h\n@@ -400,7 +400,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map)\n  */\n static inline void hashmap_enable_item_counting(struct hashmap *map)\n {\n-\tvoid *item;\n \tunsigned int n = 0;\n \tstruct hashmap_iter iter;\n \n@@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map)\n \t\treturn;\n \n \thashmap_iter_init(map, &iter);\n-\twhile ((item = hashmap_iter_next(&iter)))\n+\twhile (hashmap_iter_next(&iter))\n \t\tn++;\n \n \tmap->do_count_items = 1;\n-- \n2.8.5.23.g6fa7ec3\n\n"},{"id":"336590","messageId":"E2F9FAE97F7D4B49A5A644FC796A9AAC@PhilipOakley","threadId":"47609","inReplyTo":"20180114164529.10120-1-randall.s.becker@rogers.com","subject":"Re: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.org","sentAt":null,"receivedAt":"2018-01-14T17:25:22Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"From: <randall.s.becker@rogers.com>\nSubject: [PATCH] Remoted unnecessary void* from hashmap.h that caused \ncompile warnings\n\ns/Remoted/Removed/ ?\n\nMaybe shorten to \" hashmap.h: remove unnecessary void* \" (ex the superflous \nspaces)\n--\nPhilip\n\n\n> From: \"Randall S. Becker\" <rsbecker@nexbridge.com>\n>\n> * The while loop in the inline method hashmap_enable_item_counting\n>  used an unneeded variable. The loop has been revised accordingly.\n>\n> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>\n> ---\n> hashmap.h | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/hashmap.h b/hashmap.h\n> index 7ce79f3..d375d9c 100644\n> --- a/hashmap.h\n> +++ b/hashmap.h\n> @@ -400,7 +400,6 @@ static inline void \n> hashmap_disable_item_counting(struct hashmap *map)\n>  */\n> static inline void hashmap_enable_item_counting(struct hashmap *map)\n> {\n> - void *item;\n>  unsigned int n = 0;\n>  struct hashmap_iter iter;\n>\n> @@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct \n> hashmap *map)\n>  return;\n>\n>  hashmap_iter_init(map, &iter);\n> - while ((item = hashmap_iter_next(&iter)))\n> + while (hashmap_iter_next(&iter))\n>  n++;\n>\n>  map->do_count_items = 1;\n> -- \n> 2.8.5.23.g6fa7ec3\n> \n\n"},{"id":"336595","messageId":"002801d38d64$6e62efa0$4b28cee0$@nexbridge.com","threadId":"47609","inReplyTo":"E2F9FAE97F7D4B49A5A644FC796A9AAC@PhilipOakley","subject":"RE: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-01-14T18:20:55Z","receivedAt":"2018-01-14T18:21:07Z","isPatch":true,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On January 14, 2018 12:25 PM, Philip Oakley wrote:\n> To: randall.s.becker@rogers.com; git@vger.kernel.org\n> Cc: Randall S. Becker <rsbecker@nexbridge.com>\n> Subject: Re: [PATCH] Remoted unnecessary void* from hashmap.h that\n> caused compile warnings\n> \n> From: <randall.s.becker@rogers.com>\n> Subject: [PATCH] Remoted unnecessary void* from hashmap.h that caused\n> compile warnings\n> \n> s/Remoted/Removed/ ?\n> \n> Maybe shorten to \" hashmap.h: remove unnecessary void* \" (ex the\n> superflous\n> spaces)\n\nI amended the commit fixing the typo and cleaning up the comment.\n\nThanks,\nRandall\n\n"}]}