{"thread":{"id":"47592","subject":"[BUG] Weird breakages in t1450 #2 on NonStop","startedAt":"2018-01-11T14:46:00Z","lastAt":"2018-01-12T15:47:59Z","messageCount":4,"participants":["Randall S. Becker","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"336461","messageId":"003601d38aea$e0e08ff0$a2a1afd0$@nexbridge.com","threadId":"47592","inReplyTo":null,"subject":"[BUG] Weird breakages in t1450 #2 on NonStop","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-01-11T14:45:46Z","receivedAt":"2018-01-11T14:46:00Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"This one has me scratching my head:\n\nThe object file name being reported below in t1450, subtest 2 is corrupt,\nbut I can't figure out why the script might be generating this condition -\nthere's nothing apparent, but it looks like the git commit -m C step is\nreporting or using a bad name. This breakage was not present in 2.8.5 (now\nat 7234152 (2.13.5) and is persistent (i.e. always happens). This is the\nonly test in all of git where I have observed this particular situation.\nAdding set -x to test_commit is unrevealing. The git fsck in this test is\nnever executed because the test_commit fails with a non-zero git commit\ncompletion code. There is no rn---- (actual r n 252 252 252 252) in the\nobjects directory - even the 'rn' does not correspond to anything.. I am\nsuspecting an unterminated string that ran into freed memory somewhere, but\nthat's speculative. \n\nDoes anyone have a perspective on this - was it subsequently fixed?\n\nThanks,\nRandall\n\nInitialized empty Git repository in /home/git/git/t/trash\ndirectory.t1450-fsck/another/.git/\nerror: object directory /home/git/git/t/trash\ndirectory.t1450-fsck/another/.git/objects/rn---- does not exist; check\n.git/objects/info/alternates.\n[master (root-commit) 1aac250] C\n Author: A U Thor <author@example.com>\n 1 file changed, 1 insertion(+)\n create mode 100644 fileC\nerror: object directory /home/git/git/t/trash\ndirectory.t1450-fsck/another/.git/objects/rn---- does not exist; check\n.git/objects/info/alternates.\n--- empty       2018-01-11 13:57:30 +0000\n+++ actual      2018-01-11 13:57:40 +0000\n@@ -0,0 +1 @@\n+error: object directory /home/git/git/t/trash\ndirectory.t1450-fsck/another/.git/objects/rn---- does not exist; check\n.git/objects/info/alternates.\nnot ok 2 - loose objects borrowed from alternate are not missing\n#\n#               mkdir another &&\n#               (\n#                       cd another &&\n#                       git init &&\n#                       echo ../../../.git/objects\n>.git/objects/info/alternates &&\n#                       test_commit C fileC one &&\n#                       git fsck --no-dangling >../actual 2>&1\n#               ) &&\n#               test_cmp empty actual\n#\n\nLs -l of the objects directory:\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 .\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 ..\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 13\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 56\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 bd\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 c9\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 f7\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 info\ndrwxrwxr-x 1 randall ITUGLIB 4096 Jan 11 08:26 pack\nfrom find:\n./13\n./13/4756353796a5439d93586be27999eea3807a34\n./56\n./56/26abf0f72e58d7a153368ba57db4c673c0e171\n./bd\n./bd/04fbdc74c1ad468ee1cc86d49860490ab3e6c7\n./c9\n./c9/145d6720f85544cc4bb6009a2e541660aa156b\n./c9/176b0dd1a95c80ad8de21784b1eeffd3681f49\n./f7\n./f7/19efd430d52bcfc8566a43b2eb655688d38871\n./info\n./pack\n\n"},{"id":"336484","messageId":"000201d38b24$9e27ac40$da7704c0$@nexbridge.com","threadId":"47592","inReplyTo":"003601d38aea$e0e08ff0$a2a1afd0$@nexbridge.com","subject":"RE: [BUG] Weird breakages in t1450 #2 on NonStop","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-01-11T21:39:04Z","receivedAt":"2018-01-11T21:39:19Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On January 11, 2018 9:46 AM, I wrote:\n> This one has me scratching my head:\n> \n> The object file name being reported below in t1450, subtest 2 is corrupt,\nbut I\n> can't figure out why the script might be generating this condition -\nthere's\n> nothing apparent, but it looks like the git commit -m C step is reporting\nor\n> using a bad name. This breakage was not present in 2.8.5 (now at 7234152\n> (2.13.5) and is persistent (i.e. always happens). This is the only test in\nall of\n> git where I have observed this particular situation.\n> Adding set -x to test_commit is unrevealing. The git fsck in this test is\nnever\n> executed because the test_commit fails with a non-zero git commit\n> completion code. There is no rn---- (actual r n 252 252 252 252) in the\nobjects\n> directory - even the 'rn' does not correspond to anything.. I am\nsuspecting an\n> unterminated string that ran into freed memory somewhere, but that's\n> speculative.\n\nDoes anyone recall fixing this one at or near\ndfe46c5ce6e68d682f80f9874f0eb107e9fee797? There was a rewrite of sha1_file.c\nincluding link_alt_odb_entry where I am finding memory corruptions. I think\nI'm chasing something that was already fixed some time after 2.13.5 but the\ncommon parent to where I am is pretty far back compared to master.\n\nThanks,\nRandall\n\n-- Brief whoami:\n  NonStop developer since approximately NonStop(211288444200000000)\n  UNIX developer since approximately 421664400\n-- In my real life, I talk too much.\n\n\n\n\n\n"},{"id":"336512","messageId":"20180112143912.GB9088@sigill.intra.peff.net","threadId":"47592","inReplyTo":"000201d38b24$9e27ac40$da7704c0$@nexbridge.com","subject":"Re: [BUG] Weird breakages in t1450 #2 on NonStop","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2018-01-12T14:39:12Z","receivedAt":"2018-01-12T14:39:19Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Jan 11, 2018 at 04:39:04PM -0500, Randall S. Becker wrote:\n\n> > executed because the test_commit fails with a non-zero git commit\n> > completion code. There is no rn---- (actual r n 252 252 252 252) in\n> > the objects directory - even the 'rn' does not correspond to\n> > anything.. I am suspecting an unterminated string that ran into\n> > freed memory somewhere, but that's speculative.\n> \n> Does anyone recall fixing this one at or near\n> dfe46c5ce6e68d682f80f9874f0eb107e9fee797? There was a rewrite of\n> sha1_file.c including link_alt_odb_entry where I am finding memory\n> corruptions. I think I'm chasing something that was already fixed some\n> time after 2.13.5 but the common parent to where I am is pretty far\n> back compared to master.\n\nI did a lot of work on link_alt_odb_entry() in the past year or so, and\nI seem to recall seeing some cases where we could run into unterminated\nmemory in the error message.\n\nMaybe dc732bd5cb (read_info_alternates: read contents into strbuf,\n2017-09-19)?\n\n-Peff\n"},{"id":"336516","messageId":"001c01d38bbc$b04a05b0$10de1110$@nexbridge.com","threadId":"47592","inReplyTo":"20180112143912.GB9088@sigill.intra.peff.net","subject":"RE: [BUG] Weird breakages in t1450 #2 on NonStop","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-01-12T15:47:39Z","receivedAt":"2018-01-12T15:47:59Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On January 12, 2018 9:39 AM, Jeff King wrote:\n> On Thu, Jan 11, 2018 at 04:39:04PM -0500, Randall S. Becker wrote:\n> \n> > > executed because the test_commit fails with a non-zero git commit\n> > > completion code. There is no rn---- (actual r n 252 252 252 252) in\n> > > the objects directory - even the 'rn' does not correspond to\n> > > anything.. I am suspecting an unterminated string that ran into\n> > > freed memory somewhere, but that's speculative.\n> >\n> > Does anyone recall fixing this one at or near\n> > dfe46c5ce6e68d682f80f9874f0eb107e9fee797? There was a rewrite of\n> > sha1_file.c including link_alt_odb_entry where I am finding memory\n> > corruptions. I think I'm chasing something that was already fixed some\n> > time after 2.13.5 but the common parent to where I am is pretty far\n> > back compared to master.\n> \n> I did a lot of work on link_alt_odb_entry() in the past year or so, and I seem\n> to recall seeing some cases where we could run into unterminated memory\n> in the error message.\n> \n> Maybe dc732bd5cb (read_info_alternates: read contents into strbuf, 2017-\n> 09-19)?\n\nIn that case, I think I'm going to jump right to 2.16.0-rc2. I think I would have preferred 2.15.2 - but there isn't one yet 😉\n\nCheers,\nRandall\n\n-- Brief whoami:\n NonStop developer since approximately 211288444200000000\n UNIX developer since approximately 421664400\n-- In my real life, I talk too much.\n\n\n\n"}]}