{"thread":{"id":"47520","subject":"[Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c","startedAt":"2018-01-01T21:22:32Z","lastAt":"2018-01-02T23:08:31Z","messageCount":4,"participants":["Randall S. Becker","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"335593","messageId":"004701d38346$7dd4be00$797e3a00$@nexbridge.com","threadId":"47520","inReplyTo":null,"subject":"[Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-01-01T21:21:25Z","receivedAt":"2018-01-01T21:22:32Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"I'm looking for the proper approach for dealing with the following situation\nin 2.8.5:\n* I have defined NO_INTPTR_T = UnfortunatelyYes in config.mak.uname for my\nplatform. The c99 compiler I have does not define it.\n* The code compiles except for compat/regex/regcomp.c - not sure why this is\nbeing used since I have also *not* defined NO_REGEX because regex is sane\nhere.\n* If I include git-compat-util.h, where intptr_t is defined, in this\ncompile, loads of other compile problems result.\n* To get around the compile problem, I have wrapped the definition of\nintptr_t as follows, temporarily, duplicating content from git-compat-util.h\n        #include <stdint.h>\n        #if defined __TANDEM\n        #ifdef NO_INTPTR_T\n        typedef long intptr_t;\n        typedef unsigned long uintptr_t;\n        #endif\n        #endif\n\nSo the question now is how best to handle this long term. I'm slowly porting\nup to 2.16 - hoping a week or two until I get there with the mods required\nand running tests and all. It does not look like the issue of intptr_t is\nsubsequently resolved in regcomp.c (other than #include <stdint.h> being\nremoved), so this is going to continue to haunt me as a problem. There are\nloads of ways of dealing with it, but I'd like to fix this in a way that\nbest follows the team's standards. So...\n\n1. I'd rather not worry about regcomp.c, but don't know why it's still\nsomehow required. \n2. git-compat-util.h is pretty heavy just for intptr_t in this module.\nRefactoring might be an option.\n\nThanks,\nRandall\n\n-- Brief whoami: NonStop&UNIX developer since approximately\nUNIX(421664400)/NonStop(211288444200000000)\n-- In my real life, I talk too much.\n\n\n"},{"id":"335594","messageId":"CAPig+cQ_H20ON0usig-FWj7YVF_AOR_yvBRhXJeFmRv_w7pZAw@mail.gmail.com","threadId":"47520","inReplyTo":"004701d38346$7dd4be00$797e3a00$@nexbridge.com","subject":"Re: [Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-01-01T21:51:24Z","receivedAt":"2018-01-01T21:51:30Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Jan 1, 2018 at 4:21 PM, Randall S. Becker\n<rsbecker@nexbridge.com> wrote:\n> * I have defined NO_INTPTR_T = UnfortunatelyYes in config.mak.uname for my\n> platform. The c99 compiler I have does not define it.\n> * The code compiles except for compat/regex/regcomp.c - not sure why this is\n> being used since I have also *not* defined NO_REGEX because regex is sane\n> here.\n\nPresumably you're compiling for NonStop? config.mak.uname defines\nNO_REGEX for that platform (it also defines NO_INTPTR_T). git-blame\npoints at 6c109904bc (Port to HP NonStop, 2012-09-19).\n"},{"id":"335596","messageId":"004a01d3834d$91bf2520$b53d6f60$@nexbridge.com","threadId":"47520","inReplyTo":"CAPig+cQ_H20ON0usig-FWj7YVF_AOR_yvBRhXJeFmRv_w7pZAw@mail.gmail.com","subject":"RE: [Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-01-01T22:12:04Z","receivedAt":"2018-01-01T22:12:23Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On January 1, 2018 4:51 PM Eric Sunshine wrote:\n> On Mon, Jan 1, 2018 at 4:21 PM, Randall S. Becker\n> <rsbecker@nexbridge.com> wrote:\n> > * I have defined NO_INTPTR_T = UnfortunatelyYes in config.mak.uname\n> > for my platform. The c99 compiler I have does not define it.\n> > * The code compiles except for compat/regex/regcomp.c - not sure why\n> > this is being used since I have also *not* defined NO_REGEX because\n> > regex is sane here.\n> \n> Presumably you're compiling for NonStop? config.mak.uname defines\n> NO_REGEX for that platform (it also defines NO_INTPTR_T). git-blame points\n> at 6c109904bc (Port to HP NonStop, 2012-09-19).\n\nI got rid of that entry 3 years ago but did not contribute the updates because there are many other platform dependencies including FLOSS. Caution: that particular commit is not usable or useful on current NonStop operating systems.\n\n"},{"id":"335642","messageId":"004c01d3841e$94d9e6b0$be8db410$@nexbridge.com","threadId":"47520","inReplyTo":"CAPig+cQ_H20ON0usig-FWj7YVF_AOR_yvBRhXJeFmRv_w7pZAw@mail.gmail.com","subject":"RE: [Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-01-02T23:08:14Z","receivedAt":"2018-01-02T23:08:31Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On January 1, 2018 4:51 PM Eric Sunshine wrote:\n> On Mon, Jan 1, 2018 at 4:21 PM, Randall S. Becker\n> <rsbecker@nexbridge.com> wrote:\n> > * I have defined NO_INTPTR_T = UnfortunatelyYes in config.mak.uname\n> > for my platform. The c99 compiler I have does not define it.\n> > * The code compiles except for compat/regex/regcomp.c - not sure why\n> > this is being used since I have also *not* defined NO_REGEX because\n> > regex is sane here.\n> \n> Presumably you're compiling for NonStop? config.mak.uname defines\n> NO_REGEX for that platform (it also defines NO_INTPTR_T). git-blame points\n> at 6c109904bc (Port to HP NonStop, 2012-09-19).\n\nI found one teeny thing. NO_REGEX=NeedsStartEnd is what should be in config.mak.uname to get it right rather than ignoring NO_REGEX completely. I will commit that after my porting adventure. This still requires regcomp.c to be used and misses intptr_t, so still looking for a solution. I'm also currently at commit 7234152 and dealing with a bunch of new dependencies that weren't there at 2.8.5.\n\nCheers,\nRandall\n\n-- Brief whoami: NonStop&UNIX developer since approximately UNIX(421664400)/NonStop(211288444200000000)\n-- In my real life, I talk too much.\n\n\n\n"}]}