{"thread":{"id":"47495","subject":"[PATCH] Fix confusing wording","startedAt":"2017-12-25T10:35:07Z","lastAt":"2018-01-07T16:36:34Z","messageCount":3,"participants":["Ivan Pozdeev","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"335281","messageId":"8da9d436-88b9-7959-dd9c-65bdd376bf54@mail.mipt.ru","threadId":"47495","inReplyTo":null,"subject":"[PATCH] Fix confusing wording","fromName":"Ivan Pozdeev","fromEmail":"vano@mail.mipt.ru","sentAt":"2017-12-25T10:26:37Z","receivedAt":"2017-12-25T10:35:07Z","isPatch":true,"sender":{"key":"vano@mail.mipt.ru","avatar":null},"body":"Not sure if I should add a CVE-2009-0037 reference as well.\n\n---\nhttp.c | 2 +-\n1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/http.c b/http.c\nindex 215bebe..26b3386 100644\n--- a/http.c\n+++ b/http.c\n@@ -802,7 +802,7 @@ static CURL *get_curl_handle(void)\nget_curl_allowed_protocols(-1));\n#else\nwarning(\"protocol restrictions not applied to curl redirects because\\n\"\n- \"your curl version is too old (>= 7.19.4)\");\n+ \"your libcurl version is too old (< 7.19.4)\");\n#endif\nif (getenv(\"GIT_CURL_VERBOSE\"))\ncurl_easy_setopt(result, CURLOPT_VERBOSE, 1L);\n-- \n2.10.0.windows.1\n\n-- \nRegards,\nIvan\n\n"},{"id":"335391","messageId":"xmqqincslzvd.fsf@gitster.mtv.corp.google.com","threadId":"47495","inReplyTo":"8da9d436-88b9-7959-dd9c-65bdd376bf54@mail.mipt.ru","subject":"Re: [PATCH] Fix confusing wording","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-12-27T19:44:38Z","receivedAt":"2017-12-27T19:44:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ivan Pozdeev <vano@mail.mipt.ru> writes:\n\n> Not sure if I should add a CVE-2009-0037 reference as well.\n\nNot in an end-user facing message like this one, I would say.\n\n>\n> ---\n\nSign off?\n\n> http.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/http.c b/http.c\n> index 215bebe..26b3386 100644\n> --- a/http.c\n> +++ b/http.c\n> @@ -802,7 +802,7 @@ static CURL *get_curl_handle(void)\n> get_curl_allowed_protocols(-1));\n> #else\n> warning(\"protocol restrictions not applied to curl redirects because\\n\"\n> - \"your curl version is too old (>= 7.19.4)\");\n> + \"your libcurl version is too old (< 7.19.4)\");\n> #endif\n\nBetween 'curl' and 'libcurl', the latter certainly is more\ntechnically correct.  I have a feeling that it would be better to\nspell out \">=\" as \"requires at least\" than replacing it with equally\ncryptic \"<\" (it is OK to spell it out as \"your libcurl version is\nolder than minimum required 7.19.4\", too).\n\nThanks.\n"},{"id":"336084","messageId":"ea302300-6f42-e6f5-16e2-81329a532788@mail.mipt.ru","threadId":"47495","inReplyTo":"xmqqincslzvd.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] Fix confusing wording","fromName":"Ivan Pozdeev","fromEmail":"vano@mail.mipt.ru","sentAt":"2018-01-07T16:36:19Z","receivedAt":"2018-01-07T16:36:34Z","isPatch":true,"sender":{"key":"vano@mail.mipt.ru","avatar":null},"body":"\nOn 27.12.2017 22:44, Junio C Hamano wrote:\n> Ivan Pozdeev <vano@mail.mipt.ru> writes:\n>\n>> Not sure if I should add a CVE-2009-0037 reference as well.\n> Not in an end-user facing message like this one, I would say.\nTo me, as an end user, the current message had no meaning at all. It \neven sounds like I'm better off for having an old version 'cuz git tried \nto apply some limitation to the download, and couldn't.\nIf it had \"see <CVE> for more details\", I could quickly find out the \nmessage's real meaning. Currently, I have to `git blame' the source to \ndo that -- certainly something that few users would resort to.\n>> ---\n> Sign off?\nhttps://github.com/native-api/git/blob/master/Documentation/SubmittingPatches\nwasn't clear that this is required (TortoiseGit doesn't add it by \ndefault). Do I need to remake the patch or something?\n>> http.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/http.c b/http.c\n>> index 215bebe..26b3386 100644\n>> --- a/http.c\n>> +++ b/http.c\n>> @@ -802,7 +802,7 @@ static CURL *get_curl_handle(void)\n>> get_curl_allowed_protocols(-1));\n>> #else\n>> warning(\"protocol restrictions not applied to curl redirects because\\n\"\n>> - \"your curl version is too old (>= 7.19.4)\");\n>> + \"your libcurl version is too old (< 7.19.4)\");\n>> #endif\n> Between 'curl' and 'libcurl', the latter certainly is more\n> technically correct.  I have a feeling that it would be better to\n> spell out \">=\" as \"requires at least\" than replacing it with equally\n> cryptic \"<\" (it is OK to spell it out as \"your libcurl version is\n> older than minimum required 7.19.4\", too).\nI don't see how \"your version is too old (less that <version>)\" is unclear.\nAny wording with \"required\" would be incorrect because a newer version \nisn't really \"required\", git can work with an older one, too.\n> Thanks.\nYou're welcome :-)\n\n-- \nRegards,\nIvan\n\n"}]}