{"thread":{"id":"47424","subject":"How to begin an error/die string? Upper- or lower-case letter?","startedAt":"2017-12-11T10:23:55Z","lastAt":"2017-12-11T12:25:48Z","messageCount":2,"participants":["Lars Schneider","Thomas Gummerer"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"334593","messageId":"0ABBA110-59E9-423C-9A8E-9CF4BE2C4CA9@gmail.com","threadId":"47424","inReplyTo":null,"subject":"How to begin an error/die string? Upper- or lower-case letter?","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2017-12-11T10:23:45Z","receivedAt":"2017-12-11T10:23:55Z","isPatch":false,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"Hi,\n\nerror() and die() messages seems to begin with upper-case and \nlower-case letters in the Git code base:\n\n  git grep 'error(_' | perl -nE 'say /.*error\\(_\\(\"(.).*/' | sort | uniq -c\n  git grep 'die(_' | perl -nE 'say /.*die\\(_\\(\"(.).*/' | sort | uniq -c\n\nDo we prefer one way over the other?\n\nThanks,\nLars\n\n"},{"id":"334594","messageId":"CALgYhfN4NiQsaBZBU8jj4XBd48BjdWcEUqJCZH-rkHF-8QbdLQ@mail.gmail.com","threadId":"47424","inReplyTo":"0ABBA110-59E9-423C-9A8E-9CF4BE2C4CA9@gmail.com","subject":"Re: How to begin an error/die string? Upper- or lower-case letter?","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2017-12-11T12:25:40Z","receivedAt":"2017-12-11T12:25:48Z","isPatch":false,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"On Mon, Dec 11, 2017 at 10:23 AM, Lars Schneider\n<larsxschneider@gmail.com> wrote:\n> Hi,\n>\n> error() and die() messages seems to begin with upper-case and\n> lower-case letters in the Git code base:\n>\n>   git grep 'error(_' | perl -nE 'say /.*error\\(_\\(\"(.).*/' | sort | uniq -c\n>   git grep 'die(_' | perl -nE 'say /.*die\\(_\\(\"(.).*/' | sort | uniq -c\n>\n> Do we prefer one way over the other?\n\nThe coding guidelines mandate not capitalizing error messages:\n\n    $ git grep -A6 \"Error Messages\" Documentation/CodingGuidelines\n    Documentation/CodingGuidelines:Error Messages\n    Documentation/CodingGuidelines-\n    Documentation/CodingGuidelines- - Do not end error messages with a\nfull stop.\n    Documentation/CodingGuidelines-\n    Documentation/CodingGuidelines- - Do not capitalize (\"unable to\nopen %s\", not \"Unable to open %s\")\n    Documentation/CodingGuidelines-\n    Documentation/CodingGuidelines- - Say what the error is first\n(\"cannot open %s\", not \"%s: cannot open\")\n\nI guess those that are capitalized are just leftovers from before\nwe had that guideline in place, or slipped through review.\n\n> Thanks,\n> Lars\n>\n"}]}