{"thread":{"id":"47418","subject":"[PATCH] sequencer: make sign_off_header a file local symbol","startedAt":"2017-12-10T00:08:27Z","lastAt":"2017-12-10T00:08:27Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"334555","messageId":"8caabe3e-4dc3-657a-236d-6cf91e1e6d03@ramsayjones.plus.com","threadId":"47418","inReplyTo":null,"subject":"[PATCH] sequencer: make sign_off_header a file local symbol","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-12-10T00:08:18Z","receivedAt":"2017-12-10T00:08:27Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit d0aaa46fd3 (\"commit: move empty message checks to libgit\",\n2017-11-10) removes the last use of 'sign_off_header' outside of\nthe \"sequencer.c\" source file. Remove the extern declaration from\nthe header file and mark the definition of the symbol with the\nstatic keyword.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Junio,\n\nNow that the 'pw/sequencer-in-process-commit' branch has\ngraduated to 'next', the static-check.pl script is barking on\nthat branch. This patch applies to the next (and pu) branches\nwithout conflict. You mentioned that the previous version of\nthis patch (see [1]) conflicted with an in-flight patch series.\n('ot/pretty' and 'lb/rebase-i-short-command-names' have nearby\nchanges, but don't conflict).\n\nWas this an 'not in any integration branch, but I'm still holding\nonto it' topic branch? If it is still a problem, please just ignore\nthis patch.\n\nThanks!\n\n[1] https://public-inbox.org/git/%3Cd9d05477-5d2f-04fc-adee-10d18bc0947d@ramsayjones.plus.com%3E/\n\nATB,\nRamsay Jones\n\n\n sequencer.c | 2 +-\n sequencer.h | 2 --\n 2 files changed, 1 insertion(+), 3 deletions(-)\n\ndiff --git a/sequencer.c b/sequencer.c\nindex 0f17b4d32..8c2af94ed 100644\n--- a/sequencer.c\n+++ b/sequencer.c\n@@ -26,7 +26,7 @@\n \n #define GIT_REFLOG_ACTION \"GIT_REFLOG_ACTION\"\n \n-const char sign_off_header[] = \"Signed-off-by: \";\n+static const char sign_off_header[] = \"Signed-off-by: \";\n static const char cherry_picked_prefix[] = \"(cherry picked from commit \";\n \n GIT_PATH_FUNC(git_path_seq_dir, \"sequencer\")\ndiff --git a/sequencer.h b/sequencer.h\nindex 77cb174b2..688b0276d 100644\n--- a/sequencer.h\n+++ b/sequencer.h\n@@ -53,8 +53,6 @@ int check_todo_list(void);\n int skip_unnecessary_picks(void);\n int rearrange_squash(void);\n \n-extern const char sign_off_header[];\n-\n void append_signoff(struct strbuf *msgbuf, int ignore_footer, unsigned flag);\n void append_conflicts_hint(struct strbuf *msgbuf);\n int git_sequencer_config(const char *k, const char *v, void *cb);\n-- \n2.15.0\n"}]}