{"thread":{"id":"47405","subject":"[PATCH] docs/pretty-formats: mention commas in %(trailers) syntax","startedAt":"2017-12-08T05:16:43Z","lastAt":"2017-12-09T08:07:16Z","messageCount":7,"participants":["Jeff King","Eric Sunshine","Junio C Hamano","Taylor Blau","Jacob Keller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"334396","messageId":"20171208051636.GA24693@sigill.intra.peff.net","threadId":"47405","inReplyTo":null,"subject":"[PATCH] docs/pretty-formats: mention commas in %(trailers) syntax","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-12-08T05:16:36Z","receivedAt":"2017-12-08T05:16:43Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Commit 84ff053d47 (pretty.c: delimit \"%(trailers)\" arguments\nwith \",\", 2017-10-01) switched the syntax of the trailers\nplaceholder, but forgot to update the documentation in\npretty-formats.txt.\n\nThere's need to mention the old syntax; it was never in a\nreleased version of Git.\n\nSigned-off-by: Jeff King \n---\nThis should go on top of tb/delimit-pretty-trailers-args-with-comma.\n\n Documentation/pretty-formats.txt | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\nindex d433d50f81..e664c088a5 100644\n--- a/Documentation/pretty-formats.txt\n+++ b/Documentation/pretty-formats.txt\n@@ -204,11 +204,13 @@ endif::git-rev-list[]\n than given and there are spaces on its left, use those spaces\n - '%><()', '%><|()': similar to '% <()', '%<|()'\n respectively, but padding both sides (i.e. the text is centered)\n-- %(trailers): display the trailers of the body as interpreted by\n- linkgit:git-interpret-trailers[1]. If the `:only` option is given,\n- omit non-trailer lines from the trailer block. If the `:unfold`\n- option is given, behave as if interpret-trailer's `--unfold` option\n- was given. E.g., `%(trailers:only:unfold)` to do both.\n+- %(trailers[:options]): display the trailers of the body as interpreted\n+ by linkgit:git-interpret-trailers[1]. The `trailers` string may be\n+ followed by a colon and zero or more comma-separated options. If the\n+ `only` option is given, omit non-trailer lines from the trailer block.\n+ If the `unfold` option is given, behave as if interpret-trailer's\n+ `--unfold` option was given. E.g., `%(trailers:only,unfold)` to do\n+ both.\n \n NOTE: Some placeholders may depend on other options given to the\n revision traversal engine. For example, the `%g*` reflog options will\n-- \n2.15.1.659.g8bd2eae3ea\n"},{"id":"334398","messageId":"CAPig+cTdFSZziq9Mi7HHa+UcG3V9AwvWy1EpFoCLfT_9Fi+eKQ@mail.gmail.com","threadId":"47405","inReplyTo":"20171208051636.GA24693@sigill.intra.peff.net","subject":"Re: [PATCH] docs/pretty-formats: mention commas in %(trailers) syntax","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2017-12-08T08:10:34Z","receivedAt":"2017-12-08T08:10:40Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Dec 8, 2017 at 12:16 AM, Jeff King wrote:\n> Commit 84ff053d47 (pretty.c: delimit \"%(trailers)\" arguments\n> with \",\", 2017-10-01) switched the syntax of the trailers\n> placeholder, but forgot to update the documentation in\n> pretty-formats.txt.\n>\n> There's need to mention the old syntax; it was never in a\n\nI suppose you mean: s/need/no need/\n\n> released version of Git.\n>\n> Signed-off-by: Jeff King \n"},{"id":"334399","messageId":"20171208081356.GA24991@sigill.intra.peff.net","threadId":"47405","inReplyTo":"CAPig+cTdFSZziq9Mi7HHa+UcG3V9AwvWy1EpFoCLfT_9Fi+eKQ@mail.gmail.com","subject":"Re: [PATCH] docs/pretty-formats: mention commas in %(trailers) syntax","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-12-08T08:13:56Z","receivedAt":"2017-12-08T08:14:29Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Dec 08, 2017 at 03:10:34AM -0500, Eric Sunshine wrote:\n\n> On Fri, Dec 8, 2017 at 12:16 AM, Jeff King wrote:\n> > Commit 84ff053d47 (pretty.c: delimit \"%(trailers)\" arguments\n> > with \",\", 2017-10-01) switched the syntax of the trailers\n> > placeholder, but forgot to update the documentation in\n> > pretty-formats.txt.\n> >\n> > There's need to mention the old syntax; it was never in a\n> \n> I suppose you mean: s/need/no need/\n\nYes, indeed. Thanks.\n\n-Peff\n"},{"id":"334453","messageId":"xmqqk1xx9mut.fsf@gitster.mtv.corp.google.com","threadId":"47405","inReplyTo":"20171208051636.GA24693@sigill.intra.peff.net","subject":"Re: [PATCH] docs/pretty-formats: mention commas in %(trailers) syntax","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-12-08T16:59:54Z","receivedAt":"2017-12-08T17:00:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> Commit 84ff053d47 (pretty.c: delimit \"%(trailers)\" arguments\n> with \",\", 2017-10-01) switched the syntax of the trailers\n> placeholder, but forgot to update the documentation in\n> pretty-formats.txt.\n>\n> There's need to mention the old syntax; it was never in a\n> released version of Git.\n\nThere's or There's no?\n\n>\n> Signed-off-by: Jeff King \n> ---\n> This should go on top of tb/delimit-pretty-trailers-args-with-comma.\n>\n> Documentation/pretty-formats.txt | 12 +++++++-----\n> 1 file changed, 7 insertions(+), 5 deletions(-)\n>\n> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\n> index d433d50f81..e664c088a5 100644\n> --- a/Documentation/pretty-formats.txt\n> +++ b/Documentation/pretty-formats.txt\n> @@ -204,11 +204,13 @@ endif::git-rev-list[]\n> than given and there are spaces on its left, use those spaces\n> - '%><()', '%><|()': similar to '% <()', '%<|()'\n> respectively, but padding both sides (i.e. the text is centered)\n> -- %(trailers): display the trailers of the body as interpreted by\n> - linkgit:git-interpret-trailers[1]. If the `:only` option is given,\n> - omit non-trailer lines from the trailer block. If the `:unfold`\n> - option is given, behave as if interpret-trailer's `--unfold` option\n> - was given. E.g., `%(trailers:only:unfold)` to do both.\n> +- %(trailers[:options]): display the trailers of the body as interpreted\n> + by linkgit:git-interpret-trailers[1]. The `trailers` string may be\n> + followed by a colon and zero or more comma-separated options. If the\n> + `only` option is given, omit non-trailer lines from the trailer block.\n> + If the `unfold` option is given, behave as if interpret-trailer's\n> + `--unfold` option was given. E.g., `%(trailers:only,unfold)` to do\n> + both.\n> \n> NOTE: Some placeholders may depend on other options given to the\n> revision traversal engine. For example, the `%g*` reflog options will\n"},{"id":"334454","messageId":"xmqqfu8l9mtu.fsf@gitster.mtv.corp.google.com","threadId":"47405","inReplyTo":"20171208081356.GA24991@sigill.intra.peff.net","subject":"Re: [PATCH] docs/pretty-formats: mention commas in %(trailers) syntax","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-12-08T17:00:29Z","receivedAt":"2017-12-08T17:00:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Fri, Dec 08, 2017 at 03:10:34AM -0500, Eric Sunshine wrote:\n>\n>> On Fri, Dec 8, 2017 at 12:16 AM, Jeff King wrote:\n>> > Commit 84ff053d47 (pretty.c: delimit \"%(trailers)\" arguments\n>> > with \",\", 2017-10-01) switched the syntax of the trailers\n>> > placeholder, but forgot to update the documentation in\n>> > pretty-formats.txt.\n>> >\n>> > There's need to mention the old syntax; it was never in a\n>> \n>> I suppose you mean: s/need/no need/\n>\n> Yes, indeed. Thanks.\n\nAh, I probably should switch to 'read-only' mode until I finish my\ninbox.\n\n"},{"id":"334527","messageId":"20171209034436.GA43611@D-10-157-251-166.dhcp4.washington.edu","threadId":"47405","inReplyTo":"20171208051636.GA24693@sigill.intra.peff.net","subject":"Re: [PATCH] docs/pretty-formats: mention commas in %(trailers) syntax","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2017-12-09T03:44:36Z","receivedAt":"2017-12-09T03:44:49Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Fri, Dec 08, 2017 at 12:16:36AM -0500, Jeff King wrote:\n> Commit 84ff053d47 (pretty.c: delimit \"%(trailers)\" arguments\n> with \",\", 2017-10-01) switched the syntax of the trailers\n> placeholder, but forgot to update the documentation in\n> pretty-formats.txt.\n>\n> There's need to mention the old syntax; it was never in a\n> released version of Git.\n>\n> Signed-off-by: Jeff King \n\nMy mistake, and thank you for giving this your attention.\n"},{"id":"334529","messageId":"CA+P7+xr6XhnrxSk-jR0HyGksFsjBFkBuEr-RR8U-nEFUpJNJvg@mail.gmail.com","threadId":"47405","inReplyTo":"20171208051636.GA24693@sigill.intra.peff.net","subject":"Re: [PATCH] docs/pretty-formats: mention commas in %(trailers) syntax","fromName":"Jacob Keller","fromEmail":"jacob.keller@gmail.com","sentAt":"2017-12-09T08:06:49Z","receivedAt":"2017-12-09T08:07:16Z","isPatch":true,"sender":{"key":"jacob.keller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/874719?v=4"},"body":"On Thu, Dec 7, 2017 at 9:16 PM, Jeff King wrote:\n> Commit 84ff053d47 (pretty.c: delimit \"%(trailers)\" arguments\n> with \",\", 2017-10-01) switched the syntax of the trailers\n> placeholder, but forgot to update the documentation in\n> pretty-formats.txt.\n>\n> There's need to mention the old syntax; it was never in a\n> released version of Git.\n>\n> Signed-off-by: Jeff King \n> ---\n> This should go on top of tb/delimit-pretty-trailers-args-with-comma.\n>\n> Documentation/pretty-formats.txt | 12 +++++++-----\n> 1 file changed, 7 insertions(+), 5 deletions(-)\n>\n> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\n> index d433d50f81..e664c088a5 100644\n> --- a/Documentation/pretty-formats.txt\n> +++ b/Documentation/pretty-formats.txt\n> @@ -204,11 +204,13 @@ endif::git-rev-list[]\n> than given and there are spaces on its left, use those spaces\n> - '%><()', '%><|()': similar to '% <()', '%<|()'\n> respectively, but padding both sides (i.e. the text is centered)\n> -- %(trailers): display the trailers of the body as interpreted by\n> - linkgit:git-interpret-trailers[1]. If the `:only` option is given,\n> - omit non-trailer lines from the trailer block. If the `:unfold`\n> - option is given, behave as if interpret-trailer's `--unfold` option\n> - was given. E.g., `%(trailers:only:unfold)` to do both.\n> +- %(trailers[:options]): display the trailers of the body as interpreted\n> + by linkgit:git-interpret-trailers[1]. The `trailers` string may be\n> + followed by a colon and zero or more comma-separated options. If the\n> + `only` option is given, omit non-trailer lines from the trailer block.\n> + If the `unfold` option is given, behave as if interpret-trailer's\n> + `--unfold` option was given. E.g., `%(trailers:only,unfold)` to do\n> + both.\n>\n> NOTE: Some placeholders may depend on other options given to the\n> revision traversal engine. For example, the `%g*` reflog options will\n> --\n> 2.15.1.659.g8bd2eae3ea\n\nHAH. I was recently looking at this documentation and going to send a\npatch. Looks good besides the other reviewers comments.\n\nThanks,\nJake\n"}]}