{"thread":{"id":"47393","subject":"[PATCH] setup.c: fix comment about order of .git directory discovery","startedAt":"2017-12-07T09:00:08Z","lastAt":"2017-12-08T10:04:20Z","messageCount":2,"participants":["SZEDER Gábor","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"334310","messageId":"20171207085949.19519-1-szeder.dev@gmail.com","threadId":"47393","inReplyTo":null,"subject":"[PATCH] setup.c: fix comment about order of .git directory discovery","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2017-12-07T08:59:49Z","receivedAt":"2017-12-07T09:00:08Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Since gitfiles were introduced in b44ebb19e (Add platform-independent\n.git \"symlink\", 2008-02-20) the order of checks during .git directory\ndiscovery is: gitfile, gitdir, bare repo.  However, that commit did\nonly partially update the in-code comment describing this order,\nmissing the last line which still puts gitdir before gitfile.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\n---\n setup.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/setup.c b/setup.c\nindex 03f51e056..b168d25db 100644\n--- a/setup.c\n+++ b/setup.c\n@@ -921,7 +921,7 @@ static enum discovery_result setup_git_directory_gently_1(struct strbuf *dir,\n \t * - ../.git\n \t * - ../.git/\n \t * - ../ (bare)\n-\t * - ../../.git/\n+\t * - ../../.git\n \t *   etc.\n \t */\n \tone_filesystem = !git_env_bool(\"GIT_DISCOVERY_ACROSS_FILESYSTEM\", 0);\n-- \n2.15.1.338.g53352fef7\n\n"},{"id":"334406","messageId":"20171208100214.GB1899@sigill.intra.peff.net","threadId":"47393","inReplyTo":"20171207085949.19519-1-szeder.dev@gmail.com","subject":"Re: [PATCH] setup.c: fix comment about order of .git directory discovery","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-12-08T10:02:15Z","receivedAt":"2017-12-08T10:04:20Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Dec 07, 2017 at 09:59:49AM +0100, SZEDER Gábor wrote:\n\n> Since gitfiles were introduced in b44ebb19e (Add platform-independent\n> .git \"symlink\", 2008-02-20) the order of checks during .git directory\n> discovery is: gitfile, gitdir, bare repo.  However, that commit did\n> only partially update the in-code comment describing this order,\n> missing the last line which still puts gitdir before gitfile.\n\nI was confused at first, because your patch only changes to \".git/\" to\n\".git\". So there is no ordering change, only a swapping out of one for\nthe other. But that pushes done the \".git/\" into the \"etc.\" which is\nbelow.\n\nSo I think this makes sense.\n\nThanks.\n\n-Peff\n"}]}