{"thread":{"id":"47388","subject":"partial_clone_get_default_filter_spec has no callers","startedAt":"2017-12-06T17:39:40Z","lastAt":"2017-12-07T15:43:21Z","messageCount":5,"participants":["Ramsay Jones","Jeff Hostetler","Luc Van Oostenryck"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"334260","messageId":"ec83f2d9-0d87-9d6b-4860-f4cd7c19984e@ramsayjones.plus.com","threadId":"47388","inReplyTo":null,"subject":"partial_clone_get_default_filter_spec has no callers","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-12-06T17:39:32Z","receivedAt":"2017-12-06T17:39:40Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi Jeff,\n\ncommit f1862e8153 (\"partial-clone: define partial clone settings\nin config\", 2017-12-05), which is part of your 'jh/partial-clone'\nbranch, introduces the partial_clone_get_default_filter_spec()\nfunction without any callers. Could you please confirm that this\nis intentional and that, presumably, a future series will include\na call to this function.\n\nThanks!\n\nATB,\nRamsay Jones\n\n"},{"id":"334271","messageId":"89d06941-9bee-9334-d737-11ef7801cba2@jeffhostetler.com","threadId":"47388","inReplyTo":"ec83f2d9-0d87-9d6b-4860-f4cd7c19984e@ramsayjones.plus.com","subject":"Re: partial_clone_get_default_filter_spec has no callers","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2017-12-06T21:07:35Z","receivedAt":"2017-12-06T21:07:42Z","isPatch":false,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 12/6/2017 12:39 PM, Ramsay Jones wrote:\n> Hi Jeff,\n> \n> commit f1862e8153 (\"partial-clone: define partial clone settings\n> in config\", 2017-12-05), which is part of your 'jh/partial-clone'\n> branch, introduces the partial_clone_get_default_filter_spec()\n> function without any callers. Could you please confirm that this\n> is intentional and that, presumably, a future series will include\n> a call to this function.\n\nI'll double check.  Thanks.\n\nBTW is there another tool that you're using to find these?\nI know I ran make DEVELOPER=1 and make sparse on everything\nand didn't see that come up.\n\nJeff\n\n"},{"id":"334304","messageId":"44d0c556-d5ba-186f-7493-f9900eccb442@ramsayjones.plus.com","threadId":"47388","inReplyTo":"89d06941-9bee-9334-d737-11ef7801cba2@jeffhostetler.com","subject":"Re: partial_clone_get_default_filter_spec has no callers","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-12-07T01:59:26Z","receivedAt":"2017-12-07T01:59:38Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 06/12/17 21:07, Jeff Hostetler wrote:\n> \n> \n> On 12/6/2017 12:39 PM, Ramsay Jones wrote:\n>> Hi Jeff,\n>>\n>> commit f1862e8153 (\"partial-clone: define partial clone settings\n>> in config\", 2017-12-05), which is part of your 'jh/partial-clone'\n>> branch, introduces the partial_clone_get_default_filter_spec()\n>> function without any callers. Could you please confirm that this\n>> is intentional and that, presumably, a future series will include\n>> a call to this function.\n> \n> I'll double check.  Thanks.\n> \n> BTW is there another tool that you're using to find these?\n> I know I ran make DEVELOPER=1 and make sparse on everything\n> and didn't see that come up.\n\nIn addition to sparse (which finds some of these), I also run a perl\nscript over the object files after a given build. (The script was\nposted to the list by Junio, many moons ago, and I have made several\nchanges to my local copy).\n\nI am attaching a copy of the script (static-check.pl). Note that the\n'stop list' in the script (%def_ok) is _way_ out of date. However, the\nway I use the script, that does not matter; I run the script over the\nmaster->next->pu branches and (ignoring the master branch) diff the\nresult files from branch to branch. For example, tonight I have:\n\n  $ wc -l sc nsc psc\n    74 sc\n    73 nsc\n    75 psc\n   222 total\n  $ \n  $ diff sc nsc\n  44d43\n  < oidmap.o\t- oidmap_remove\n  $ \n  $ diff nsc psc\n  43a44\n  > list-objects-filter-options.o\t- partial_clone_get_default_filter_spec\n  58a60\n  > sequencer.o\t- sign_off_header\n  $ \n\nYou also have to be careful with leaving stale object files\nlaying around from previous builds ('make clean' sometimes\ndoesn't). Actually, it may be simpler to read a previous mailing\nlist thread on exactly this subject [1].\n\nBTW, if you are using a version of sparse post v0.5.1, you can\nget rid of the only sparse warning on Linux (assuming you don't\nbuild with NO_REGEX set), by using the -Wno-memcpy-max-count option;\nI have the following set in my config.mak:\n\n  $ tail -2 config.mak\n  pack-revindex.sp: SPARSE_FLAGS += -Wno-memcpy-max-count\n\n  $ \n\n[I haven't sent a proper patch, since the required version of\nsparse is not widely available yet.]\n\nATB,\nRamsay Jones\n\n[1] https://public-inbox.org/git/%3Cb21c8a92-4dd5-56d6-ec6a-5709028eaf5f@ramsayjones.plus.com%3E/\n"},{"id":"334313","messageId":"20171207092907.lrieior3ncwwc3wh@ltop.local","threadId":"47388","inReplyTo":"44d0c556-d5ba-186f-7493-f9900eccb442@ramsayjones.plus.com","subject":"Re: partial_clone_get_default_filter_spec has no callers","fromName":"Luc Van Oostenryck","fromEmail":"luc.vanoostenryck@gmail.com","sentAt":"2017-12-07T09:29:08Z","receivedAt":"2017-12-07T09:29:15Z","isPatch":false,"sender":{"key":"luc.vanoostenryck@gmail.com","avatar":"https://avatars.githubusercontent.com/u/16168334?v=4"},"body":"On Thu, Dec 07, 2017 at 01:59:26AM +0000, Ramsay Jones wrote:\n> \n> BTW, if you are using a version of sparse post v0.5.1, you can\n> get rid of the only sparse warning on Linux (assuming you don't\n> build with NO_REGEX set), by using the -Wno-memcpy-max-count option;\n> I have the following set in my config.mak:\n> \n>   $ tail -2 config.mak\n>   pack-revindex.sp: SPARSE_FLAGS += -Wno-memcpy-max-count\n> \n>   $ \n> \n> [I haven't sent a proper patch, since the required version of\n> sparse is not widely available yet.]\n\nNote that sparse simply ignore unknown options/flags, so adding\nit now won't create a problem and can already help those using\na recent vesion of sparse.\n\nRegards,\n-- Luc \n"},{"id":"334326","messageId":"7a7400a1-0743-152a-fa3b-740c3b2b8e04@jeffhostetler.com","threadId":"47388","inReplyTo":"44d0c556-d5ba-186f-7493-f9900eccb442@ramsayjones.plus.com","subject":"Re: partial_clone_get_default_filter_spec has no callers","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2017-12-07T15:43:02Z","receivedAt":"2017-12-07T15:43:21Z","isPatch":false,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 12/6/2017 8:59 PM, Ramsay Jones wrote:\n> \n> \n> On 06/12/17 21:07, Jeff Hostetler wrote:\n>>\n>>\n>> On 12/6/2017 12:39 PM, Ramsay Jones wrote:\n>>> Hi Jeff,\n>>>\n>>> commit f1862e8153 (\"partial-clone: define partial clone settings\n>>> in config\", 2017-12-05), which is part of your 'jh/partial-clone'\n>>> branch, introduces the partial_clone_get_default_filter_spec()\n>>> function without any callers. Could you please confirm that this\n>>> is intentional and that, presumably, a future series will include\n>>> a call to this function.\n>>\n>> I'll double check.  Thanks.\n>>\n>> BTW is there another tool that you're using to find these?\n>> I know I ran make DEVELOPER=1 and make sparse on everything\n>> and didn't see that come up.\n> \n> In addition to sparse (which finds some of these), I also run a perl\n> script over the object files after a given build. (The script was\n> posted to the list by Junio, many moons ago, and I have made several\n> changes to my local copy).\n> \n> I am attaching a copy of the script (static-check.pl). Note that the\n> 'stop list' in the script (%def_ok) is _way_ out of date. However, the\n> way I use the script, that does not matter; I run the script over the\n> master->next->pu branches and (ignoring the master branch) diff the\n> result files from branch to branch. For example, tonight I have:\n> \n>    $ wc -l sc nsc psc\n>      74 sc\n>      73 nsc\n>      75 psc\n>     222 total\n>    $\n>    $ diff sc nsc\n>    44d43\n>    < oidmap.o\t- oidmap_remove\n>    $\n>    $ diff nsc psc\n>    43a44\n>    > list-objects-filter-options.o\t- partial_clone_get_default_filter_spec\n>    58a60\n>    > sequencer.o\t- sign_off_header\n>    $\n> \n> You also have to be careful with leaving stale object files\n> laying around from previous builds ('make clean' sometimes\n> doesn't). Actually, it may be simpler to read a previous mailing\n> list thread on exactly this subject [1].\n> \n[...]\n> \n> ATB,\n> Ramsay Jones\n> \n> [1] https://public-inbox.org/git/%3Cb21c8a92-4dd5-56d6-ec6a-5709028eaf5f@ramsayjones.plus.com%3E/\n> \n\nthanks!  maybe you could post something (in contrib/ perhaps)\nthat would run your script on a pair of commits like t/perf/run.sh.\njust a thought.\n\nJeff\n\n"}]}