{"thread":{"id":"4737","subject":"[PATCH] Git.xs: older perl do not know const char *","startedAt":"2006-07-02T09:53:03Z","lastAt":"2006-07-02T22:39:26Z","messageCount":3,"participants":["Johannes Schindelin","Petr Baudis","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"23029","messageId":"Pine.LNX.4.63.0607021152200.29667@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4737","inReplyTo":null,"subject":"[PATCH] Git.xs: older perl do not know const char *","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-07-02T09:53:03Z","receivedAt":"2006-07-02T09:53:03Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nBoth of these casts _should_ be safe, since you do not want to muck around \nwith the version or the path anyway.\n\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n\n---\n\n perl/Git.xs |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/perl/Git.xs b/perl/Git.xs\nindex 51bfac3..c824210 100644\n--- a/perl/Git.xs\n+++ b/perl/Git.xs\n@@ -59,7 +59,7 @@ BOOT:\n # /* TODO: xs_call_gate(). See Git.pm. */\n \n \n-const char *\n+char *\n xs_version()\n CODE:\n {\n@@ -69,11 +69,11 @@ OUTPUT:\n \tRETVAL\n \n \n-const char *\n+char *\n xs_exec_path()\n CODE:\n {\n-\tRETVAL = git_exec_path();\n+\tRETVAL = (char *)git_exec_path();\n }\n OUTPUT:\n \tRETVAL\n"},{"id":"23057","messageId":"20060702215249.GK29115@pasky.or.cz","threadId":"4737","inReplyTo":"Pine.LNX.4.63.0607021152200.29667@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Git.xs: older perl do not know const char *","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-07-02T21:52:49Z","receivedAt":"2006-07-02T21:52:49Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Sun, Jul 02, 2006 at 11:53:03AM CEST, I got a letter\nwhere Johannes Schindelin <Johannes.Schindelin@gmx.de> said that...\n> Both of these casts _should_ be safe, since you do not want to muck around \n> with the version or the path anyway.\n> \n> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n\nAcked-by: Petr Baudis <pasky@suse.cz>\n\nIt isn't all that great but it seems everything xs does with this is to\nfeed it to sv_setpv() which AFAIK copies it around.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nSnow falling on Perl. White noise covering line noise.\nHides all the bugs too. -- J. Putnam\n"},{"id":"23060","messageId":"7v1wt33a3l.fsf@assigned-by-dhcp.cox.net","threadId":"4737","inReplyTo":"20060702215249.GK29115@pasky.or.cz","subject":"Re: [PATCH] Git.xs: older perl do not know const char *","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-07-02T22:39:26Z","receivedAt":"2006-07-02T22:39:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis <pasky@suse.cz> writes:\n\n> Dear diary, on Sun, Jul 02, 2006 at 11:53:03AM CEST, I got a letter\n> where Johannes Schindelin <Johannes.Schindelin@gmx.de> said that...\n>> Both of these casts _should_ be safe, since you do not want to muck around \n>> with the version or the path anyway.\n>> \n>> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n>\n> Acked-by: Petr Baudis <pasky@suse.cz>\n>\n> It isn't all that great but it seems everything xs does with this is to\n> feed it to sv_setpv() which AFAIK copies it around.\n\nThanks.  Already applied but not pushed out yet (I am working on\ntracking down unrelated breakage in tests).\n"}]}