{"thread":{"id":"47358","subject":"[PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","startedAt":"2017-12-01T02:32:48Z","lastAt":"2017-12-14T20:35:19Z","messageCount":17,"participants":["Todd Zullinger","Eric Wong","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"333881","messageId":"20171201023239.26153-1-tmz@pobox.com","threadId":"47358","inReplyTo":null,"subject":"[PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-01T02:32:37Z","receivedAt":"2017-12-01T02:32:48Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"These tests are not run by default nor are they enabled in travis-ci.  I\ndon't know how much testing they get in user or other packager builds.\n\nI've been slowly increasing the test suite usage in fedora builds.  I\nran into this while testing locally with parallel make test.  The\nofficial fedora builds don't run in parallel (yet), as even before I ran\ninto this issue, builds on the fedora builders randomly failed too\noften.  I'm hoping to eventually enable parallel tests by default\nthough, since it's so much faster.\n\nI'm not sure if there's any objection to changing the variable needed to\nenable the tests from SVNSERVE_PORT to GIT_TEST_SVNSERVE.  The way\nSVNSERVE_PORT is set in this patch should allow the port to be set\nexplicitly, in case someone requires that -- and they understand that it\ncan fail if running parallel tests, of course.  Whether that's a\nfeature or a bug, I'm not sure. :)\n\nThe indentation of lib-git-svn.sh didn't use tabs consistently, in only\na few places, so I cleaned that up first.  I can drop that change if\nit's unwanted.\n\nTodd Zullinger (2):\n  t/lib-git-svn: whitespace cleanup\n  t/lib-git-svn.sh: improve svnserve tests with parallel make test\n\n t/lib-git-svn.sh | 24 +++++++++++++-----------\n 1 file changed, 13 insertions(+), 11 deletions(-)\n\n-- \n2.15.1\n\n"},{"id":"333882","messageId":"20171201023239.26153-2-tmz@pobox.com","threadId":"47358","inReplyTo":"20171201023239.26153-1-tmz@pobox.com","subject":"[PATCH 1/2] t/lib-git-svn: whitespace cleanup","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-01T02:32:38Z","receivedAt":"2017-12-01T02:32:50Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Signed-off-by: Todd Zullinger <tmz@pobox.com>\n---\n t/lib-git-svn.sh | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh\nindex 688313ed5c..84366b2624 100644\n--- a/t/lib-git-svn.sh\n+++ b/t/lib-git-svn.sh\n@@ -17,8 +17,8 @@ SVN_TREE=$GIT_SVN_DIR/svn-tree\n svn >/dev/null 2>&1\n if test $? -ne 1\n then\n-    skip_all='skipping git svn tests, svn not found'\n-    test_done\n+\tskip_all='skipping git svn tests, svn not found'\n+\ttest_done\n fi\n \n svnrepo=$PWD/svnrepo\n@@ -110,18 +110,18 @@ EOF\n }\n \n require_svnserve () {\n-    if test -z \"$SVNSERVE_PORT\"\n-    then\n-\tskip_all='skipping svnserve test. (set $SVNSERVE_PORT to enable)'\n-        test_done\n-    fi\n+\tif test -z \"$SVNSERVE_PORT\"\n+\tthen\n+\t\tskip_all='skipping svnserve test. (set $SVNSERVE_PORT to enable)'\n+\t\ttest_done\n+\tfi\n }\n \n start_svnserve () {\n-    svnserve --listen-port $SVNSERVE_PORT \\\n-             --root \"$rawsvnrepo\" \\\n-             --listen-once \\\n-             --listen-host 127.0.0.1 &\n+\tsvnserve --listen-port $SVNSERVE_PORT \\\n+\t\t --root \"$rawsvnrepo\" \\\n+\t\t --listen-once \\\n+\t\t --listen-host 127.0.0.1 &\n }\n \n prepare_a_utf8_locale () {\n-- \n2.15.1\n\n"},{"id":"333883","messageId":"20171201023239.26153-3-tmz@pobox.com","threadId":"47358","inReplyTo":"20171201023239.26153-1-tmz@pobox.com","subject":"[PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-01T02:32:39Z","receivedAt":"2017-12-01T02:32:51Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Previously, setting SVNSERVE_PORT enabled several tests which require a\nlocal svnserve daemon to be run (in t9113 & t9126).  The tests share the\nsetup of the local svnserve via `start_svnserve()`.  The function uses\nthe svnserve option `--listen-once` which causes svnserve to accept one\nconnection on the port, serve it, and exit.  When running the tests in\nparallel this fails if one test tries to start svnserve while the other\nis still running.\n\nUse the test number as the svnserve port (similar to httpd tests) to\navoid port conflicts.  Set GIT_TEST_SVNSERVE to any value other than\n'false' or 'auto' to enable these tests.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\n t/lib-git-svn.sh | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh\nindex 84366b2624..4c1f81f167 100644\n--- a/t/lib-git-svn.sh\n+++ b/t/lib-git-svn.sh\n@@ -110,14 +110,16 @@ EOF\n }\n \n require_svnserve () {\n-\tif test -z \"$SVNSERVE_PORT\"\n+\ttest_tristate GIT_TEST_SVNSERVE\n+\tif ! test \"$GIT_TEST_SVNSERVE\" = true\n \tthen\n-\t\tskip_all='skipping svnserve test. (set $SVNSERVE_PORT to enable)'\n+\t\tskip_all='skipping svnserve test. (set $GIT_TEST_SVNSERVE to enable)'\n \t\ttest_done\n \tfi\n }\n \n start_svnserve () {\n+\tSVNSERVE_PORT=${SVNSERVE_PORT-${this_test#t}}\n \tsvnserve --listen-port $SVNSERVE_PORT \\\n \t\t --root \"$rawsvnrepo\" \\\n \t\t --listen-once \\\n-- \n2.15.1\n\n"},{"id":"333885","messageId":"20171201025600.GA29213@starla","threadId":"47358","inReplyTo":"20171201023239.26153-1-tmz@pobox.com","subject":"Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2017-12-01T02:56:00Z","receivedAt":"2017-12-01T02:56:05Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Todd Zullinger <tmz@pobox.com> wrote:\n> These tests are not run by default nor are they enabled in travis-ci.  I\n> don't know how much testing they get in user or other packager builds.\n> \n> I've been slowly increasing the test suite usage in fedora builds.  I\n> ran into this while testing locally with parallel make test.  The\n> official fedora builds don't run in parallel (yet), as even before I ran\n> into this issue, builds on the fedora builders randomly failed too\n> often.  I'm hoping to eventually enable parallel tests by default\n> though, since it's so much faster.\n\nCool.\n\n> I'm not sure if there's any objection to changing the variable needed to\n> enable the tests from SVNSERVE_PORT to GIT_TEST_SVNSERVE.  The way\n> SVNSERVE_PORT is set in this patch should allow the port to be set\n> explicitly, in case someone requires that -- and they understand that it\n> can fail if running parallel tests, of course.  Whether that's a\n> feature or a bug, I'm not sure. :)\n\nI'm fine with this for now.  Since svnserve (and git-daemon)\nboth support inetd behavior, I think we can eventually have a\ntest helper which binds random ports and pretends to be an\ninetd, letting the test run without any special setup.\n\nIt would let multiple test instances run in parallel, even.\n\n> The indentation of lib-git-svn.sh didn't use tabs consistently, in only\n> a few places, so I cleaned that up first.  I can drop that change if\n> it's unwanted.\n\nFine by me.\n"},{"id":"333886","messageId":"20171201030234.GF20640@aiede.mtv.corp.google.com","threadId":"47358","inReplyTo":"20171201023239.26153-3-tmz@pobox.com","subject":"Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-12-01T03:02:34Z","receivedAt":"2017-12-01T03:04:09Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nTodd Zullinger wrote:\n\n> Previously, setting SVNSERVE_PORT enabled several tests which require a\n> local svnserve daemon to be run (in t9113 & t9126).  The tests share the\n> setup of the local svnserve via `start_svnserve()`.  The function uses\n> the svnserve option `--listen-once` which causes svnserve to accept one\n> connection on the port, serve it, and exit.  When running the tests in\n> parallel this fails if one test tries to start svnserve while the other\n> is still running.\n\nI had trouble reading this because I didn't know what previous time it\nwas referring to.  Is it about how the option currently behaves?\n\n(Git's commit messages tend to use the present tense to describe the\nbehavior before the patch, like a bug report, and the imperative to\ndescribe the change the patch proposes to make, like an impolite bug\nreport. :))\n\n> Use the test number as the svnserve port (similar to httpd tests) to\n> avoid port conflicts.  Set GIT_TEST_SVNSERVE to any value other than\n> 'false' or 'auto' to enable these tests.\n\nThis uses imperative in two ways and also ended up confusing me.  The\nsecond one is a direction to me, not Git, right?  How about:\n\n\tUse the test number instead of $SVNSERVE_PORT as the svnserve\n\tport (similar to httpd tests) to avoid port conflicts.\n\tDevelopers can set GIT_TEST_SVNSERVE to any value other than\n\t'false' or 'auto' to enable these tests.\n>\n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n>  t/lib-git-svn.sh | 6 ++++--\n>  1 file changed, 4 insertions(+), 2 deletions(-)\n\nThe patch looks good.  Thanks.\n\n> diff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh\n> index 84366b2624..4c1f81f167 100644\n> --- a/t/lib-git-svn.sh\n> +++ b/t/lib-git-svn.sh\n> @@ -110,14 +110,16 @@ EOF\n>  }\n>  \n>  require_svnserve () {\n> -\tif test -z \"$SVNSERVE_PORT\"\n> +\ttest_tristate GIT_TEST_SVNSERVE\n> +\tif ! test \"$GIT_TEST_SVNSERVE\" = true\n>  \tthen\n> -\t\tskip_all='skipping svnserve test. (set $SVNSERVE_PORT to enable)'\n> +\t\tskip_all='skipping svnserve test. (set $GIT_TEST_SVNSERVE to enable)'\n>  \t\ttest_done\n>  \tfi\n>  }\n>  \n>  start_svnserve () {\n> +\tSVNSERVE_PORT=${SVNSERVE_PORT-${this_test#t}}\n>  \tsvnserve --listen-port $SVNSERVE_PORT \\\n>  \t\t --root \"$rawsvnrepo\" \\\n>  \t\t --listen-once \\\n> -- \n> 2.15.1\n> \n"},{"id":"333887","messageId":"20171201030453.GG20640@aiede.mtv.corp.google.com","threadId":"47358","inReplyTo":"20171201023239.26153-2-tmz@pobox.com","subject":"Re: [PATCH 1/2] t/lib-git-svn: whitespace cleanup","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-12-01T03:04:53Z","receivedAt":"2017-12-01T03:05:02Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Todd Zullinger wrote:\n\n> Subject: t/lib-git-svn: whitespace cleanup\n>\n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n>  t/lib-git-svn.sh | 22 +++++++++++-----------\n>  1 file changed, 11 insertions(+), 11 deletions(-)\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nThanks.\n\nnit: it would have been a tiny bit easier to review if the commit\nmessage mentioned that this is only changing the indentation from an\ninconsistent space/tab mixture to tabs and isn't making any other\nchanges.\n"},{"id":"333888","messageId":"20171201030727.GH20640@aiede.mtv.corp.google.com","threadId":"47358","inReplyTo":"20171201023239.26153-1-tmz@pobox.com","subject":"Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-12-01T03:07:27Z","receivedAt":"2017-12-01T03:07:34Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Todd Zullinger wrote:\n\n> These tests are not run by default nor are they enabled in travis-ci.  I\n> don't know how much testing they get in user or other packager builds.\n>\n> I've been slowly increasing the test suite usage in fedora builds.  I\n> ran into this while testing locally with parallel make test.  The\n> official fedora builds don't run in parallel (yet), as even before I ran\n> into this issue, builds on the fedora builders randomly failed too\n> often.  I'm hoping to eventually enable parallel tests by default\n> though, since it's so much faster.\n\nThis background could go in the commit message for patch 2, but it\nalso speaks for itself as an obviously good change so I could go\neither way.\n\n> I'm not sure if there's any objection to changing the variable needed to\n> enable the tests from SVNSERVE_PORT to GIT_TEST_SVNSERVE.  The way\n> SVNSERVE_PORT is set in this patch should allow the port to be set\n> explicitly, in case someone requires that -- and they understand that it\n> can fail if running parallel tests, of course.  Whether that's a\n> feature or a bug, I'm not sure. :)\n\nmicronit: can this just say something like\n\n\tPatch 2 is the important one --- see that one for rationale.\n\n\tPatch 1 is an optional preparatory style cleanup.\n\nnext time?  That way, you get an automatic guarantee that all the\nimportant information is available in \"git log\" output to people who\nneed it later.\n\nThanks,\nJonathan\n"},{"id":"333891","messageId":"20171201034006.GB3693@zaya.teonanacatl.net","threadId":"47358","inReplyTo":"20171201025600.GA29213@starla","subject":"Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-01T03:40:07Z","receivedAt":"2017-12-01T03:40:18Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Hi Eric,\n\nEric Wong wrote:\n> I'm fine with this for now.  Since svnserve (and git-daemon)\n> both support inetd behavior, I think we can eventually have a\n> test helper which binds random ports and pretends to be an\n> inetd, letting the test run without any special setup.\n>\n> It would let multiple test instances run in parallel, even.\n\nIndeed, that would be a nice general improvement. :)\n\nThanks,\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nSuppose I were a member of Congress, and suppose I were an idiot. But,\nI repeat myself.\n    -- Mark Twain\n\n"},{"id":"333892","messageId":"20171201034047.GC3693@zaya.teonanacatl.net","threadId":"47358","inReplyTo":"20171201030727.GH20640@aiede.mtv.corp.google.com","subject":"Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-01T03:40:47Z","receivedAt":"2017-12-01T03:40:54Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Hi Jonathan,\n\nJonathan Nieder wrote:\n> Todd Zullinger wrote:\n>\n>> These tests are not run by default nor are they enabled in travis-ci.  I\n>> don't know how much testing they get in user or other packager builds.\n>>\n>> I've been slowly increasing the test suite usage in fedora builds.  I\n>> ran into this while testing locally with parallel make test.  The\n>> official fedora builds don't run in parallel (yet), as even before I ran\n>> into this issue, builds on the fedora builders randomly failed too\n>> often.  I'm hoping to eventually enable parallel tests by default\n>> though, since it's so much faster.\n>\n> This background could go in the commit message for patch 2, but it\n> also speaks for itself as an obviously good change so I could go\n> either way.\n\nHeh.  If there's something in there in particular that seems useful, I\ncan certainly add it.  I'm not sure what parts of this text would be\nbeneficial to someone down the line though.\n\nI usually err on the 'too much information' side of commit messages.\nI'm happy that it's much harder to do that here.  I'd rather have to\nskim a long message than wonder about the motivation for a change.\n\n>> I'm not sure if there's any objection to changing the variable needed to\n>> enable the tests from SVNSERVE_PORT to GIT_TEST_SVNSERVE.  The way\n>> SVNSERVE_PORT is set in this patch should allow the port to be set\n>> explicitly, in case someone requires that -- and they understand that it\n>> can fail if running parallel tests, of course.  Whether that's a\n>> feature or a bug, I'm not sure. :)\n>\n> micronit: can this just say something like\n>\n> \tPatch 2 is the important one --- see that one for rationale.\n>\n> \tPatch 1 is an optional preparatory style cleanup.\n>\n> next time?  That way, you get an automatic guarantee that all the\n> important information is available in \"git log\" output to people who\n> need it later.\n\nYeah, I'll try to remember that.  I started this without the\nwhitespace cleanup and as I was writing in the single patch\ndescription that I didn't think the whitespace cleanup was warranted,\nI talked myself into doing it as the prep patch. :)\n\nThanks,\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nTradition: Just because you've always done it that way doesn't mean\nit's not incredibly stupid.\n    -- Demotivators (www.despair.com)\n\n"},{"id":"333894","messageId":"20171201034212.GD3693@zaya.teonanacatl.net","threadId":"47358","inReplyTo":"20171201030453.GG20640@aiede.mtv.corp.google.com","subject":"Re: [PATCH 1/2] t/lib-git-svn: whitespace cleanup","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-01T03:42:12Z","receivedAt":"2017-12-01T03:42:21Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Hi Jonathan,\n\nJonathan Nieder wrote:\n> nit: it would have been a tiny bit easier to review if the commit\n> message mentioned that this is only changing the indentation from an\n> inconsistent space/tab mixture to tabs and isn't making any other\n> changes.\n\nIf only you saw how many times I typed a subject and changed it\nbefore settling on the terse version...\n\nHow about:\n\n    t/lib-git-svn: cleanup inconsistent tab/space usage\n\n?\n\nThanks,\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nHow am I supposed to hallucinate with all these swirling colors\ndistracting me?\n    -- Lisa Simpson\n\n"},{"id":"333895","messageId":"20171201034519.GE3693@zaya.teonanacatl.net","threadId":"47358","inReplyTo":"20171201030234.GF20640@aiede.mtv.corp.google.com","subject":"Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-01T03:45:19Z","receivedAt":"2017-12-01T03:45:27Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Hi Jonathan,\n\nJonathan Nieder wrote:\n> Todd Zullinger wrote:\n>\n>> Previously, setting SVNSERVE_PORT enabled several tests which require a\n>> local svnserve daemon to be run (in t9113 & t9126).  The tests share the\n>> setup of the local svnserve via `start_svnserve()`.  The function uses\n>> the svnserve option `--listen-once` which causes svnserve to accept one\n>> connection on the port, serve it, and exit.  When running the tests in\n>> parallel this fails if one test tries to start svnserve while the other\n>> is still running.\n>\n> I had trouble reading this because I didn't know what previous time it\n> was referring to.  Is it about how the option currently behaves?\n>\n> (Git's commit messages tend to use the present tense to describe the\n> behavior before the patch, like a bug report, and the imperative to\n> describe the change the patch proposes to make, like an impolite bug\n> report. :))\n\nThis is what I get for skipping grammar classes to go hiking in my\nyouth.  But I'm sure I'd do it all again, if given the chance. ;)\n\n>> Use the test number as the svnserve port (similar to httpd tests) to\n>> avoid port conflicts.  Set GIT_TEST_SVNSERVE to any value other than\n>> 'false' or 'auto' to enable these tests.\n>\n> This uses imperative in two ways and also ended up confusing me.  The\n> second one is a direction to me, not Git, right?  How about:\n>\n> \tUse the test number instead of $SVNSERVE_PORT as the svnserve\n> \tport (similar to httpd tests) to avoid port conflicts.\n> \tDevelopers can set GIT_TEST_SVNSERVE to any value other than\n> \t'false' or 'auto' to enable these tests.\n\nMuch better, thank you.  How about this for the full commit message:\n\n    t/lib-git-svn.sh: improve svnserve tests with parallel make test\n\n    Setting SVNSERVE_PORT enables several tests which require a local\n    svnserve daemon to be run (in t9113 & t9126).  The tests share setup of\n    the local svnserve via `start_svnserve()`.  The function uses svnserve's\n    `--listen-once` option, which causes svnserve to accept one connection\n    on the port, serve it, and exit.  When running the tests in parallel\n    this fails if one test tries to start svnserve while the other is still\n    running.\n\n    Use the test number as the svnserve port (similar to httpd tests) to\n    avoid port conflicts.  Developers can set GIT_TEST_SVNSERVE to any value\n    other than 'false' or 'auto' to enable these tests.\n\n?\n\nThanks,\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nCuriosity killed the cat, but for awhile I was a suspect.\n    -- Steven Wright\n\n"},{"id":"333896","messageId":"20171201035340.GJ20640@aiede.mtv.corp.google.com","threadId":"47358","inReplyTo":"20171201034519.GE3693@zaya.teonanacatl.net","subject":"Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-12-01T03:53:40Z","receivedAt":"2017-12-01T03:53:47Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Todd Zullinger wrote:\n\n> Much better, thank you.  How about this for the full commit message:\n>\n>    t/lib-git-svn.sh: improve svnserve tests with parallel make test\n>\n>    Setting SVNSERVE_PORT enables several tests which require a local\n>    svnserve daemon to be run (in t9113 & t9126).  The tests share setup of\n>    the local svnserve via `start_svnserve()`.  The function uses svnserve's\n>    `--listen-once` option, which causes svnserve to accept one connection\n>    on the port, serve it, and exit.  When running the tests in parallel\n>    this fails if one test tries to start svnserve while the other is still\n>    running.\n>\n>    Use the test number as the svnserve port (similar to httpd tests) to\n>    avoid port conflicts.  Developers can set GIT_TEST_SVNSERVE to any value\n>    other than 'false' or 'auto' to enable these tests.\n>\n> ?\n\nYep, with this description it is\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks for putting up with my nits. :)\n\nJonathan\n"},{"id":"333897","messageId":"20171201035613.GK20640@aiede.mtv.corp.google.com","threadId":"47358","inReplyTo":"20171201034212.GD3693@zaya.teonanacatl.net","subject":"Re: [PATCH 1/2] t/lib-git-svn: whitespace cleanup","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-12-01T03:56:13Z","receivedAt":"2017-12-01T03:56:20Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Todd Zullinger wrote:\n> Jonathan Nieder wrote:\n\n>> nit: it would have been a tiny bit easier to review if the commit\n>> message mentioned that this is only changing the indentation from an\n>> inconsistent space/tab mixture to tabs and isn't making any other\n>> changes.\n>\n> If only you saw how many times I typed a subject and changed it\n> before settling on the terse version...\n\nHeh.  No worries, it was a really small nit.\n\n> How about:\n>\n>    t/lib-git-svn: cleanup inconsistent tab/space usage\n>\n> ?\n\nSure, looks good.\n\nThanks again,\nJonathan\n"},{"id":"333899","messageId":"20171201041133.GF3693@zaya.teonanacatl.net","threadId":"47358","inReplyTo":"20171201035340.GJ20640@aiede.mtv.corp.google.com","subject":"Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-01T04:11:34Z","receivedAt":"2017-12-01T04:11:43Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Jonathan Nieder wrote:\n> Yep, with this description it is \n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n>\n> Thanks for putting up with my nits. :)\n\nThank you for taking the time and looking at the details. :)\n\nI'll send a v2 with the changes in the morning, in case there are any \nother comments (but mostly because it's late and time for a swim).\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nIt is impossible to enjoy idling thoroughly unless one has plenty of\nwork to do.\n    -- Jerome K. Jerome\n\n"},{"id":"334817","messageId":"20171214181949.GC3693@zaya.teonanacatl.net","threadId":"47358","inReplyTo":"20171201023239.26153-1-tmz@pobox.com","subject":"[PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-14T18:19:49Z","receivedAt":"2017-12-14T18:19:58Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Hi Junio,\n\nI wanted to check if this minor patch series had slipped\nunder your radar.  If it's waiting patiently in your queue\nfor other topics to advance, that's fine, of course. :)\n\nFinished patches: <20171201155653.29553-1-tmz@pobox.com> and\n<20171201155653.29553-2-tmz@pobox.com>.\n\nThanks,\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nAnyone who is capable of getting themselves made President should on\nno account be allowed to do the job.\n    -- Douglas Adams, \"The Hitchhiker's Guide to the Galaxy\"\n\n"},{"id":"334821","messageId":"xmqqshcdtagw.fsf@gitster.mtv.corp.google.com","threadId":"47358","inReplyTo":"20171214181949.GC3693@zaya.teonanacatl.net","subject":"Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-12-14T18:45:19Z","receivedAt":"2017-12-14T18:45:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> I wanted to check if this minor patch series had slipped\n> under your radar.\n\nTotally.  Queued.\n\nAs they come with Ack by the area maintainer, I'll fast-track them\ndown to 'master' (other topics typically cook at least for a week in\n'next').\n\nThanks for pinging.\n"},{"id":"334828","messageId":"20171214203509.GD3693@zaya.teonanacatl.net","threadId":"47358","inReplyTo":"xmqqshcdtagw.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2017-12-14T20:35:09Z","receivedAt":"2017-12-14T20:35:19Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Junio C Hamano wrote:\n> Todd Zullinger <tmz@pobox.com> writes:\n>> I wanted to check if this minor patch series had slipped\n>> under your radar.\n> \n> Totally.  Queued.\n> \n> As they come with Ack by the area maintainer, I'll fast-track them\n> down to 'master' (other topics typically cook at least for a week in\n> 'next').\n> \n> Thanks for pinging.\n\nThank you, as always.\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nThere is considerable overlap between the intelligence of the smartest\nbears and the dumbest tourists.\n  -- Park ranger yro.slashdot.org/comments.pl?sid=191810&cid=15757347\n\n"}]}