{"thread":{"id":"47331","subject":"[PATCH] git-gui: Prevent double UTF-8 conversion","startedAt":"2017-11-28T10:22:01Z","lastAt":"2017-12-14T18:18:23Z","messageCount":11,"participants":["Łukasz Stelmach","Johannes Schindelin","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"333682","messageId":"20171128102126.20864-1-l.stelmach@samsung.com","threadId":"47331","inReplyTo":"CGME20171128102138eucas1p116ae54d723bb100202fae2c1aaf5a9d8@eucas1p1.samsung.com","subject":"[PATCH] git-gui: Prevent double UTF-8 conversion","fromName":"Łukasz Stelmach","fromEmail":"l.stelmach@samsung.com","sentAt":"2017-11-28T10:21:26Z","receivedAt":"2017-11-28T10:22:01Z","isPatch":true,"sender":{"key":"l.stelmach@samsung.com","avatar":"https://gravatar.com/avatar/b5f9262ad19b1b6f1e74b8eba816455e059742e8d980fdefa9321976071642fc?d=mp&s=160"},"body":"Set encoding to utf-8 for file descriptors used to receive data from\ngit commands.\n\nWith encoding on the file descriptor set to \"binary\" Tcl (8.6 in my case)\ndoes double conversion which breaks e.g. author name in amended commits.\n\nFor example \"\\305\\201ukasz\" (as written by git cat-file) becomes\n\"\\303\\205\\302\\201ukasz\".\n\nSigned-off-by: Łukasz Stelmach <l.stelmach@samsung.com>\n---\n git-gui/lib/commit.tcl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\nSo, this is the second attempt to draw some attention to this patch,\nsince the first one has somewhat failed.\n\nhttps://marc.info/?l=git&m=150331641702091&w=2\n\ndiff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\nindex 83620b7cb..bcb6499a0 100644\n--- a/git-gui/lib/commit.tcl\n+++ b/git-gui/lib/commit.tcl\n@@ -26,7 +26,7 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \tset parents [list]\n \tif {[catch {\n \t\t\tset fd [git_read cat-file commit $curHEAD]\n-\t\t\tfconfigure $fd -encoding binary -translation lf\n+\t\t\tfconfigure $fd -encoding utf-8 -translation lf\n \t\t\t# By default commits are assumed to be in utf-8\n \t\t\tset enc utf-8\n \t\t\twhile {[gets $fd line] > 0} {\n-- \n2.11.0\n\n"},{"id":"333691","messageId":"alpine.DEB.2.21.1.1711281524390.6482@virtualbox","threadId":"47331","inReplyTo":"20171128102126.20864-1-l.stelmach@samsung.com","subject":"Re: [PATCH] git-gui: Prevent double UTF-8 conversion","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-11-28T14:35:21Z","receivedAt":"2017-11-28T14:35:53Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Łukasz,\n\nOn Tue, 28 Nov 2017, Łukasz Stelmach wrote:\n\n> Set encoding to utf-8 for file descriptors used to receive data from git\n> commands.\n\nThe patch only changes it for the `cat-file` command used to read the\nlatest commit message for amending.\n\nMaybe the commit message should be adjusted to reflect as much?\n\n> With encoding on the file descriptor set to \"binary\" Tcl (8.6 in my\n> case) does double conversion which breaks e.g. author name in amended\n> commits.\n\nIs the problem in question occurring when a commit message contains\nnon-ASCII characters encoded in UTF-8 and you click the \"Amend Last\nCommit\" radio button on the right side above the \"Commit Message\" text\nbox?\n\nI tested this with Tcl/Tk 8.6.7-1 of Git for Windows' SDK, and with Tcl/Tk\n8.6.0+9 of Ubuntu 16.04.3 LTS, in both cases the encoding of a commit\nmessage 'äöü' was handled correctly with \"binary\"...\n\nCould you give more details about your system so it is easier for me to\nunderstand where the difference comes from?\n\nHaving said that, I also tested it *with* your patch, and it does not\nbreak anything.\n\n> So, this is the second attempt to draw some attention to this patch,\n> since the first one has somewhat failed.\n\nYeah, sadly Pat (who is still listed as the active Git GUI maintainer) has\nfallen very, very silent for over a year.\n\nPinging about the status of the patch was definitely the right thing to\ndo.\n\nCiao,\nJohannes"},{"id":"333952","messageId":"87k1y5mnaw.fsf%stlman@poczta.fm","threadId":"47331","inReplyTo":"alpine.DEB.2.21.1.1711281524390.6482@virtualbox","subject":"Re: [PATCH] git-gui: Prevent double UTF-8 conversion","fromName":"Łukasz Stelmach","fromEmail":"stlman@poczta.fm","sentAt":"2017-12-02T10:33:43Z","receivedAt":"2017-12-02T10:51:57Z","isPatch":true,"sender":{"key":"stlman@poczta.fm","avatar":"https://gravatar.com/avatar/f935fa2cd53deb6667c2c9d2d7fa70569dc64b87bfbb914d1bd1b01765d93a38?d=mp&s=160"},"body":"On Tue, 28 Nov 2017 15:35:21 +0100, Johannes Schindelin wrote:\n> On Tue, 28 Nov 2017, Łukasz Stelmach wrote:\n\n> > With encoding on the file descriptor set to \"binary\" Tcl (8.6 in my\n> > case) does double conversion which breaks e.g. author name in amended\n> > commits.\n>\n> Is the problem in question occurring when a commit message contains\n> non-ASCII characters encoded in UTF-8 and you click the \"Amend Last\n> Commit\" radio button on the right side above the \"Commit Message\" text\n> box?\n\nNo, only with the author data. That means there is a difference in how\nTcl handles input in with \"read\" (the message) and \"gets\" (headers\nincluding the author header).\n\nIndeed! A few lines below the message is converted from utf-8 and author\nis not. So the right thing to do is to convert author too and not change\nthe file descriptor settings.\n\nI am going back to the drawing board. Thanks. \n\n-- \nByło mi bardzo miło.                                  --- Rurku. --- ...\n>Łukasz<                                --- To dobrze, że mnie słuchasz.\n"},{"id":"333953","messageId":"20171202122046.6033-1-l.stelmach@samsung.com","threadId":"47331","inReplyTo":"20171128102126.20864-1-l.stelmach@samsung.com","subject":"[PATCH v2] git-gui: Prevent double UTF-8 conversion","fromName":"Łukasz Stelmach","fromEmail":"l.stelmach@samsung.com","sentAt":"2017-12-02T12:20:46Z","receivedAt":"2017-12-02T12:21:02Z","isPatch":true,"sender":{"key":"l.stelmach@samsung.com","avatar":"https://gravatar.com/avatar/b5f9262ad19b1b6f1e74b8eba816455e059742e8d980fdefa9321976071642fc?d=mp&s=160"},"body":"Convert author's name from the UTF-8 (or any other) encoding in\nload_last_commit function the same way commit message is converted.\n\nAmending commits in git-gui without such conversion breaks UTF-8\nstrings. For example, \"\\305\\201ukasz\" (as written by git cat-file) becomes\n\"\\303\\205\\302\\201ukasz\" in an amended commit.\n\nSigned-off-by: Łukasz Stelmach <l.stelmach@samsung.com>\n---\n git-gui/lib/commit.tcl | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\nindex 83620b7cb..f820c24bf 100644\n--- a/git-gui/lib/commit.tcl\n+++ b/git-gui/lib/commit.tcl\n@@ -34,9 +34,7 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \t\t\t\t\tlappend parents [string range $line 7 end]\n \t\t\t\t} elseif {[string match {encoding *} $line]} {\n \t\t\t\t\tset enc [string tolower [string range $line 9 end]]\n-\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n-\t\t\t\t\tset commit_author [list name $name email $email date $time]\n-\t\t\t\t}\n+\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} { }\n \t\t\t}\n \t\t\tset msg [read $fd]\n \t\t\tclose $fd\n@@ -44,7 +42,9 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \t\t\tset enc [tcl_encoding $enc]\n \t\t\tif {$enc ne {}} {\n \t\t\t\tset msg [encoding convertfrom $enc $msg]\n+\t\t\t\tset name [encoding convertfrom $enc $name]\n \t\t\t}\n+\t\t\tset commit_author [list name $name email $email date $time]\n \t\t\tset msg [string trim $msg]\n \t\t} err]} {\n \t\terror_popup [strcat [mc \"Error loading commit data for amend:\"] \"\\n\\n$err\"]\n-- \n2.11.0\n\n"},{"id":"334052","messageId":"alpine.DEB.2.21.1.1712041521330.98586@virtualbox","threadId":"47331","inReplyTo":"20171202122046.6033-1-l.stelmach@samsung.com","subject":"Re: [PATCH v2] git-gui: Prevent double UTF-8 conversion","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-12-04T14:31:22Z","receivedAt":"2017-12-04T14:31:49Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Łukasz,\n\nOn Sat, 2 Dec 2017, Łukasz Stelmach wrote:\n\n> Convert author's name from the UTF-8 (or any other) encoding in\n> load_last_commit function the same way commit message is converted.\n> \n> Amending commits in git-gui without such conversion breaks UTF-8\n> strings. For example, \"\\305\\201ukasz\" (as written by git cat-file) becomes\n> \"\\303\\205\\302\\201ukasz\" in an amended commit.\n\nOkay, that makes the issue a lot clearer to me (the explicit mention of\n\"author's name\", that is).\n\n> diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\n> index 83620b7cb..f820c24bf 100644\n> --- a/git-gui/lib/commit.tcl\n> +++ b/git-gui/lib/commit.tcl\n> @@ -34,9 +34,7 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n>  \t\t\t\t\tlappend parents [string range $line 7 end]\n>  \t\t\t\t} elseif {[string match {encoding *} $line]} {\n>  \t\t\t\t\tset enc [string tolower [string range $line 9 end]]\n> -\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n> -\t\t\t\t\tset commit_author [list name $name email $email date $time]\n> -\t\t\t\t}\n> +\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} { }\n>  \t\t\t}\n\nThis looks wrong, as the commit_author would now also be set if the header\nwas not found (mind you, this would make for an incorrect Git commit, but\nthe code explicitly tries to set commit_author only in the case that the\nauthor line was found.\n\nBut we cannot set commit_author here because the encoding is read as\nanother header line (and in a valid commit object, the encoding line (if\nany) has to be *below* the author line).\n\nSo it *has* to be this way. Maybe mention this in the commit message, to\navoid head-scratching?\n\nHowever, I would still recommend to `set name \"\"` before the loop parsing\nthe header, and...\n\n>  \t\t\tset msg [read $fd]\n>  \t\t\tclose $fd\n> @@ -44,7 +42,9 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n>  \t\t\tset enc [tcl_encoding $enc]\n>  \t\t\tif {$enc ne {}} {\n>  \t\t\t\tset msg [encoding convertfrom $enc $msg]\n> +\t\t\t\tset name [encoding convertfrom $enc $name]\n>  \t\t\t}\n> +\t\t\tset commit_author [list name $name email $email date $time]\n\nGuarding this assignment in an `if {$name ne \"\"} { ... }`, just in case.\n\n>  \t\t\tset msg [string trim $msg]\n>  \t\t} err]} {\n>  \t\terror_popup [strcat [mc \"Error loading commit data for amend:\"] \"\\n\\n$err\"]\n\nThanks,\nJohannes"},{"id":"334154","messageId":"20171205142326.6140-1-l.stelmach@samsung.com","threadId":"47331","inReplyTo":"20171202122046.6033-1-l.stelmach@samsung.com","subject":"[PATCH v3] git-gui: Prevent double UTF-8 conversion","fromName":"Łukasz Stelmach","fromEmail":"l.stelmach@samsung.com","sentAt":"2017-12-05T14:23:26Z","receivedAt":"2017-12-05T14:23:52Z","isPatch":true,"sender":{"key":"l.stelmach@samsung.com","avatar":"https://gravatar.com/avatar/b5f9262ad19b1b6f1e74b8eba816455e059742e8d980fdefa9321976071642fc?d=mp&s=160"},"body":"Convert author's name and e-mail address from the UTF-8 (or any other)\nencoding in load_last_commit function the same way commit message is\nconverted.\n\nAmending commits in git-gui without such conversion breaks UTF-8\nstrings. For example, \"\\305\\201ukasz\" (as written by git cat-file) becomes\n\"\\303\\205\\302\\201ukasz\" in an amended commit.\n\nSigned-off-by: Łukasz Stelmach <l.stelmach@samsung.com>\n---\n git-gui/lib/commit.tcl | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)\n\ndiff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\nindex 83620b7cb..75ea965da 100644\n--- a/git-gui/lib/commit.tcl\n+++ b/git-gui/lib/commit.tcl\n@@ -25,6 +25,8 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \tset msg {}\n \tset parents [list]\n \tif {[catch {\n+\t\t\tset name \"\"\n+\t\t\tset email \"\"\n \t\t\tset fd [git_read cat-file commit $curHEAD]\n \t\t\tfconfigure $fd -encoding binary -translation lf\n \t\t\t# By default commits are assumed to be in utf-8\n@@ -34,9 +36,7 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \t\t\t\t\tlappend parents [string range $line 7 end]\n \t\t\t\t} elseif {[string match {encoding *} $line]} {\n \t\t\t\t\tset enc [string tolower [string range $line 9 end]]\n-\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n-\t\t\t\t\tset commit_author [list name $name email $email date $time]\n-\t\t\t\t}\n+\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} { }\n \t\t\t}\n \t\t\tset msg [read $fd]\n \t\t\tclose $fd\n@@ -44,7 +44,13 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \t\t\tset enc [tcl_encoding $enc]\n \t\t\tif {$enc ne {}} {\n \t\t\t\tset msg [encoding convertfrom $enc $msg]\n+\t\t\t\tset name [encoding convertfrom $enc $name]\n+\t\t\t\tset email [encoding convertfrom $enc $email]\n \t\t\t}\n+\t\t\tif {$name ne {} && $email ne {}} {\n+\t\t\t\tset commit_author [list name $name email $email date $time]\n+\t\t\t}\n+\n \t\t\tset msg [string trim $msg]\n \t\t} err]} {\n \t\terror_popup [strcat [mc \"Error loading commit data for amend:\"] \"\\n\\n$err\"]\n-- \n2.11.0\n\n"},{"id":"334290","messageId":"alpine.DEB.2.21.1.1712070106160.98586@virtualbox","threadId":"47331","inReplyTo":"20171205142326.6140-1-l.stelmach@samsung.com","subject":"Re: [PATCH v3] git-gui: Prevent double UTF-8 conversion","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-12-07T00:06:53Z","receivedAt":"2017-12-07T00:07:20Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Łukasz,\n\nOn Tue, 5 Dec 2017, Łukasz Stelmach wrote:\n\n> Convert author's name and e-mail address from the UTF-8 (or any other)\n> encoding in load_last_commit function the same way commit message is\n> converted.\n> \n> Amending commits in git-gui without such conversion breaks UTF-8\n> strings. For example, \"\\305\\201ukasz\" (as written by git cat-file) becomes\n> \"\\303\\205\\302\\201ukasz\" in an amended commit.\n> \n> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>\n\nThis patch looks good to me.\n\nThanks,\nJohannes"},{"id":"334796","messageId":"20171214093257.15826-1-l.stelmach@samsung.com","threadId":"47331","inReplyTo":"20171205142326.6140-1-l.stelmach@samsung.com","subject":"[PATCH v4] git-gui: Prevent double UTF-8 conversion","fromName":"Łukasz Stelmach","fromEmail":"l.stelmach@samsung.com","sentAt":"2017-12-14T09:32:57Z","receivedAt":"2017-12-14T09:33:09Z","isPatch":true,"sender":{"key":"l.stelmach@samsung.com","avatar":"https://gravatar.com/avatar/b5f9262ad19b1b6f1e74b8eba816455e059742e8d980fdefa9321976071642fc?d=mp&s=160"},"body":"Convert author's name and e-mail address from the UTF-8 (or any other)\nencoding in load_last_commit function the same way commit message is\nconverted.\n\nAmending commits in git-gui without such conversion breaks UTF-8\nstrings. For example, \"\\305\\201ukasz\" (as written by git cat-file) becomes\n\"\\303\\205\\302\\201ukasz\" in an amended commit.\n\nSigned-off-by: Łukasz Stelmach <l.stelmach@samsung.com>\nReviewed-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n---\nChanges since v3:\n\n- Added Reviewed-by footer. Thank you Johannes Schindelin, for review.\n\n git-gui/lib/commit.tcl | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)\n\ndiff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\nindex 83620b7cb..75ea965da 100644\n--- a/git-gui/lib/commit.tcl\n+++ b/git-gui/lib/commit.tcl\n@@ -25,6 +25,8 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \tset msg {}\n \tset parents [list]\n \tif {[catch {\n+\t\t\tset name \"\"\n+\t\t\tset email \"\"\n \t\t\tset fd [git_read cat-file commit $curHEAD]\n \t\t\tfconfigure $fd -encoding binary -translation lf\n \t\t\t# By default commits are assumed to be in utf-8\n@@ -34,9 +36,7 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \t\t\t\t\tlappend parents [string range $line 7 end]\n \t\t\t\t} elseif {[string match {encoding *} $line]} {\n \t\t\t\t\tset enc [string tolower [string range $line 9 end]]\n-\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} {\n-\t\t\t\t\tset commit_author [list name $name email $email date $time]\n-\t\t\t\t}\n+\t\t\t\t} elseif {[regexp \"author (.*)\\\\s<(.*)>\\\\s(\\\\d.*$)\" $line all name email time]} { }\n \t\t\t}\n \t\t\tset msg [read $fd]\n \t\t\tclose $fd\n@@ -44,7 +44,13 @@ You are currently in the middle of a merge that has not been fully completed.  Y\n \t\t\tset enc [tcl_encoding $enc]\n \t\t\tif {$enc ne {}} {\n \t\t\t\tset msg [encoding convertfrom $enc $msg]\n+\t\t\t\tset name [encoding convertfrom $enc $name]\n+\t\t\t\tset email [encoding convertfrom $enc $email]\n \t\t\t}\n+\t\t\tif {$name ne {} && $email ne {}} {\n+\t\t\t\tset commit_author [list name $name email $email date $time]\n+\t\t\t}\n+\n \t\t\tset msg [string trim $msg]\n \t\t} err]} {\n \t\terror_popup [strcat [mc \"Error loading commit data for amend:\"] \"\\n\\n$err\"]\n-- \n2.11.0\n\n"},{"id":"334797","messageId":"CAPig+cTYYGRynG8r_2DR53u77eCFDGe1BEDcEK3_cJQxT3yncQ@mail.gmail.com","threadId":"47331","inReplyTo":"20171214093257.15826-1-l.stelmach@samsung.com","subject":"Re: [PATCH v4] git-gui: Prevent double UTF-8 conversion","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2017-12-14T09:42:22Z","receivedAt":"2017-12-14T09:42:29Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Dec 14, 2017 at 4:32 AM, Łukasz Stelmach <l.stelmach@samsung.com> wrote:\n> Convert author's name and e-mail address from the UTF-8 (or any other)\n> encoding in load_last_commit function the same way commit message is\n> converted.\n>\n> Amending commits in git-gui without such conversion breaks UTF-8\n> strings. For example, \"\\305\\201ukasz\" (as written by git cat-file) becomes\n> \"\\303\\205\\302\\201ukasz\" in an amended commit.\n>\n> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>\n> Reviewed-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n> ---\n> Changes since v3:\n>\n> - Added Reviewed-by footer. Thank you Johannes Schindelin, for review.\n\nNo need to re-send. If you consult Junio's latest \"What's cooking\"[1],\nyou'll find that your patch has already graduated from his 'pu' branch\nto 'next' and is slated to graduate to 'master' (at some point).\n\n[1]: https://public-inbox.org/git/xmqqzi6mutcc.fsf@gitster.mtv.corp.google.com/\n"},{"id":"334799","messageId":"87o9n16145.fsf%l.stelmach@samsung.com","threadId":"47331","inReplyTo":"CAPig+cTYYGRynG8r_2DR53u77eCFDGe1BEDcEK3_cJQxT3yncQ@mail.gmail.com","subject":"Re: [PATCH v4] git-gui: Prevent double UTF-8 conversion","fromName":"Łukasz Stelmach","fromEmail":"l.stelmach@samsung.com","sentAt":"2017-12-14T10:43:38Z","receivedAt":"2017-12-14T10:43:58Z","isPatch":true,"sender":{"key":"l.stelmach@samsung.com","avatar":"https://gravatar.com/avatar/b5f9262ad19b1b6f1e74b8eba816455e059742e8d980fdefa9321976071642fc?d=mp&s=160"},"body":"It was <2017-12-14 czw 10:42>, when Eric Sunshine wrote:\n> On Thu, Dec 14, 2017 at 4:32 AM, Łukasz Stelmach <l.stelmach@samsung.com> wrote:\n>> Convert author's name and e-mail address from the UTF-8 (or any other)\n>> encoding in load_last_commit function the same way commit message is\n>> converted.\n>>\n>> Amending commits in git-gui without such conversion breaks UTF-8\n>> strings. For example, \"\\305\\201ukasz\" (as written by git cat-file) becomes\n>> \"\\303\\205\\302\\201ukasz\" in an amended commit.\n>>\n>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>\n>> Reviewed-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n>> ---\n>> Changes since v3:\n>>\n>> - Added Reviewed-by footer. Thank you Johannes Schindelin, for review.\n>\n> No need to re-send. If you consult Junio's latest \"What's cooking\"[1],\n> you'll find that your patch has already graduated from his 'pu' branch\n> to 'next' and is slated to graduate to 'master' (at some point).\n>\n> [1]: https://public-inbox.org/git/xmqqzi6mutcc.fsf@gitster.mtv.corp.google.com/\n\nI am sorry. I didn't get any notifiaction by mail and I haven't studied\nDocumentation/SubmittingPatches throughly enough.\n\n-- \nŁukasz Stelmach\nSamsung R&D Institute Poland\nSamsung Electronics\n"},{"id":"334816","messageId":"CAPig+cR1AErh7b7RO+==W=QqkCS7vBkF5O9-cuwYK9MYDF2TNA@mail.gmail.com","threadId":"47331","inReplyTo":"87o9n16145.fsf%l.stelmach@samsung.com","subject":"Re: [PATCH v4] git-gui: Prevent double UTF-8 conversion","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2017-12-14T18:18:17Z","receivedAt":"2017-12-14T18:18:23Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Dec 14, 2017 at 5:43 AM, Łukasz Stelmach <l.stelmach@samsung.com> wrote:\n> It was <2017-12-14 czw 10:42>, when Eric Sunshine wrote:\n>> No need to re-send. If you consult Junio's latest \"What's cooking\"[1],\n>> you'll find that your patch has already graduated from his 'pu' branch\n>> to 'next' and is slated to graduate to 'master' (at some point).\n>>\n>> [1]: https://public-inbox.org/git/xmqqzi6mutcc.fsf@gitster.mtv.corp.google.com/\n>\n> I am sorry. I didn't get any notifiaction by mail and I haven't studied\n> Documentation/SubmittingPatches throughly enough.\n\nNo need for an apology. My response was just a simple informational\nmessage to help you (and perhaps other newcomers reading this thread)\nget up to speed.\n"}]}