{"thread":{"id":"47324","subject":"[PATCH v1 1/2] t/README: remove mention of adding copyright notices","startedAt":"2017-11-26T20:19:42Z","lastAt":"2017-12-08T20:45:59Z","messageCount":5,"participants":["Thomas Gummerer","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"333548","messageId":"20171126202100.1658-1-t.gummerer@gmail.com","threadId":"47324","inReplyTo":null,"subject":"[PATCH v1 1/2] t/README: remove mention of adding copyright notices","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2017-11-26T20:20:59Z","receivedAt":"2017-11-26T20:19:42Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"We generally no longer include copyright notices in new test scripts.\nHowever t/README still mentions it as something to include at the top of\nevery new script.\n\nRemove that mention as it's outdated.\n\nSigned-off-by: Thomas Gummerer \n---\n\nI read through some parts of t/README, while working on the tests for\nthe worktree dwim patches, and noticed some things that are outdated/a\nuseful function that's not documented anywhere. Here's a couple of\npatches to fix that.\n\n t/README | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)\n\ndiff --git a/t/README b/t/README\nindex 4b079e4494..448569b60e 100644\n--- a/t/README\n+++ b/t/README\n@@ -332,13 +332,10 @@ Writing Tests\n -------------\n \n The test script is written as a shell script. It should start\n-with the standard \"#!/bin/sh\" with copyright notices, and an\n+with the standard \"#!/bin/sh\", and an\n assignment to variable 'test_description', like this:\n \n \t#!/bin/sh\n-\t#\n-\t# Copyright (c) 2005 Junio C Hamano\n-\t#\n \n \ttest_description='xxx test (option --frotz)\n \n-- \n2.15.0.426.gb06021eeb\n\n"},{"id":"333549","messageId":"20171126202100.1658-2-t.gummerer@gmail.com","threadId":"47324","inReplyTo":"20171126202100.1658-1-t.gummerer@gmail.com","subject":"[PATCH v1 2/2] t/README: document test_cmp_rev","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2017-11-26T20:21:00Z","receivedAt":"2017-11-26T20:19:46Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"test_cmp_rev is a useful function that's used in quite a few test\nscripts. It is however not documented in t/README. Document it.\n\nSigned-off-by: Thomas Gummerer \n---\n t/README | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/t/README b/t/README\nindex 448569b60e..e867d1f8bd 100644\n--- a/t/README\n+++ b/t/README\n@@ -674,6 +674,11 @@ library for your script to use.\n file. This behaves like \"cmp\" but produces more\n helpful output when the test is run with \"-v\" option.\n \n+ - test_cmp_rev \n+\n+ Check whether the rev points to the same commit as the\n+ rev.\n+\n - test_line_count (= | -lt | -ge | ...) \n \n Check whether a file has the length it is expected to.\n-- \n2.15.0.426.gb06021eeb\n\n"},{"id":"334212","messageId":"20171205194645.GA8183@aiede.mtv.corp.google.com","threadId":"47324","inReplyTo":"20171126202100.1658-2-t.gummerer@gmail.com","subject":"Re: [PATCH v1 2/2] t/README: document test_cmp_rev","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-12-05T19:46:45Z","receivedAt":"2017-12-05T19:47:27Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nThomas Gummerer wrote:\n\n> test_cmp_rev is a useful function that's used in quite a few test\n> scripts. It is however not documented in t/README. Document it.\n>\n> Signed-off-by: Thomas Gummerer \n> ---\n> t/README | 5 +++++\n> 1 file changed, 5 insertions(+)\n\nReviewed-by: Jonathan Nieder \n\nI admit I usually go straight to t/test-lib-functions.sh when I want\nto find an appropriate helper. I think this kind of introductory\ndocumentation in t/README is still useful, though.\n\nThanks,\nJonathan\n"},{"id":"334214","messageId":"20171205194937.GB8183@aiede.mtv.corp.google.com","threadId":"47324","inReplyTo":"20171126202100.1658-1-t.gummerer@gmail.com","subject":"Re: [PATCH v1 1/2] t/README: remove mention of adding copyright notices","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-12-05T19:49:37Z","receivedAt":"2017-12-05T19:51:01Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nThomas Gummerer wrote:\n\n> We generally no longer include copyright notices in new test scripts.\n> However t/README still mentions it as something to include at the top of\n> every new script.\n\nWhere can I read more about this change? Was it a deliberate change\nor something that simply happened?\n\nThanks,\nJonathan\n"},{"id":"334496","messageId":"20171208204736.GA25616@hank","threadId":"47324","inReplyTo":"20171205194937.GB8183@aiede.mtv.corp.google.com","subject":"Re: [PATCH v1 1/2] t/README: remove mention of adding copyright notices","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2017-12-08T20:47:36Z","receivedAt":"2017-12-08T20:45:59Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"On 12/05, Jonathan Nieder wrote:\n> Hi,\n> \n> Thomas Gummerer wrote:\n> \n> > We generally no longer include copyright notices in new test scripts.\n> > However t/README still mentions it as something to include at the top of\n> > every new script.\n> \n> Where can I read more about this change? Was it a deliberate change\n> or something that simply happened?\n\nI'm not sure if it was a deliberate change, I just noticed that most\nnew test files don't have a copyright notice anymore.\n\n $ git grep \"Copyright (c)\" t/* | sed -E 's/.*?Copyright .c. ([[:digit:]]+).*?/\\1/' | sort | uniq -c\n 61 2005\n 40 2006\n 55 2007\n 32 2008\n 31 2009\n 30 2010\n 10 2011\n 14 2012\n 4 2013\n 3 2014\n 1 2015\n 5 2016\n\nWhile we may be adding less new test files, we definitely added a few\nin 2017, for example t/t7521-ignored-mode.sh in 371c80c746 (\"status:\ntest ignored modes\", 2017-10-30), or t/t0025-crlf-renormalize.sh in\n9472935d81 (\"add: introduce \"--renormalize\"\", 2017-11-16).\n\n\n> Thanks,\n> Jonathan\n"}]}