{"thread":{"id":"47319","subject":"[PATCH] submodule--helper.c: i18n: add a missing space in message","startedAt":"2017-11-25T19:55:32Z","lastAt":"2017-11-26T03:52:14Z","messageCount":3,"participants":["Jean-Noel Avila","Eric Sunshine","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"333483","messageId":"20171125195524.29162-1-jn.avila@free.fr","threadId":"47319","inReplyTo":null,"subject":"[PATCH] submodule--helper.c: i18n: add a missing space in message","fromName":"Jean-Noel Avila","fromEmail":"jn.avila@free.fr","sentAt":"2017-11-25T19:55:24Z","receivedAt":"2017-11-25T19:55:32Z","isPatch":true,"sender":{"key":"jn.avila@free.fr","avatar":"https://avatars.githubusercontent.com/u/156172?v=4"},"body":"The message spans over 2 lines but the C conconcatenation does not add\nthe needed space between the two lines.\n\nSigned-off-by: Jean-Noel Avila <jn.avila@free.fr>\n---\n builtin/submodule--helper.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\nindex 2086f0eb0..a5c4a8a69 100644\n--- a/builtin/submodule--helper.c\n+++ b/builtin/submodule--helper.c\n@@ -623,7 +623,7 @@ static void status_submodule(const char *path, const struct object_id *ce_oid,\n \n \t\tif (refs_head_ref(get_submodule_ref_store(path),\n \t\t\t\t  handle_submodule_head_ref, &oid))\n-\t\t\tdie(_(\"could not resolve HEAD ref inside the\"\n+\t\t\tdie(_(\"could not resolve HEAD ref inside the \"\n \t\t\t      \"submodule '%s'\"), path);\n \n \t\tprint_status(flags, '+', path, &oid, displaypath);\n-- \n2.15.0\n\n"},{"id":"333496","messageId":"CAPig+cTZcS0nk-grQaN7kXxJMRELd6fuhS459FtVVeOV1ZYODw@mail.gmail.com","threadId":"47319","inReplyTo":"20171125195524.29162-1-jn.avila@free.fr","subject":"Re: [PATCH] submodule--helper.c: i18n: add a missing space in message","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2017-11-25T23:51:11Z","receivedAt":"2017-11-25T23:51:17Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sat, Nov 25, 2017 at 2:55 PM, Jean-Noel Avila <jn.avila@free.fr> wrote:\n> The message spans over 2 lines but the C conconcatenation does not add\n\ns/conconcatenation/concatenation/\n\n> the needed space between the two lines.\n>\n> Signed-off-by: Jean-Noel Avila <jn.avila@free.fr>\n> ---\n> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\n> index 2086f0eb0..a5c4a8a69 100644\n> --- a/builtin/submodule--helper.c\n> +++ b/builtin/submodule--helper.c\n> @@ -623,7 +623,7 @@ static void status_submodule(const char *path, const struct object_id *ce_oid,\n>\n>                 if (refs_head_ref(get_submodule_ref_store(path),\n>                                   handle_submodule_head_ref, &oid))\n> -                       die(_(\"could not resolve HEAD ref inside the\"\n> +                       die(_(\"could not resolve HEAD ref inside the \"\n>                               \"submodule '%s'\"), path);\n>\n>                 print_status(flags, '+', path, &oid, displaypath);\n> --\n> 2.15.0\n"},{"id":"333518","messageId":"xmqqfu91itnb.fsf@gitster.mtv.corp.google.com","threadId":"47319","inReplyTo":"20171125195524.29162-1-jn.avila@free.fr","subject":"Re: [PATCH] submodule--helper.c: i18n: add a missing space in message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-11-26T03:52:08Z","receivedAt":"2017-11-26T03:52:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}