{"thread":{"id":"47272","subject":"[PATCH v2] doc: Add missing \"-n\" (dry-run) option to reflog man page","startedAt":"2017-11-21T15:41:22Z","lastAt":"2017-11-22T16:03:10Z","messageCount":6,"participants":["Robert P. J. Day","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"333101","messageId":"alpine.LFD.2.21.1711211038410.8568@DESKTOP-1GPMCEJ","threadId":"47272","inReplyTo":null,"subject":"[PATCH v2] doc: Add missing \"-n\" (dry-run) option to reflog man page","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2017-11-21T15:39:55Z","receivedAt":"2017-11-21T15:41:22Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"While the \"git reflog\" man page supports both \"--dry-run\" and \"-n\" for\na dry run, the man page mentions only the former, not the latter.\n\nSigned-off-by: Robert P. J. Day <rpjday@crashcourse.ca>\n\n---\n\n  sorry, i accidentally chopped off the leading lines of the patch in\nthe earlier post.\n\ndiff --git a/Documentation/git-reflog.txt b/Documentation/git-reflog.txt\nindex 44c736f1a..472a6808c 100644\n--- a/Documentation/git-reflog.txt\n+++ b/Documentation/git-reflog.txt\n@@ -20,9 +20,9 @@ depending on the subcommand:\n 'git reflog' ['show'] [log-options] [<ref>]\n 'git reflog expire' [--expire=<time>] [--expire-unreachable=<time>]\n \t[--rewrite] [--updateref] [--stale-fix]\n-\t[--dry-run] [--verbose] [--all | <refs>...]\n+\t[--dry-run | -n] [--verbose] [--all | <refs>...]\n 'git reflog delete' [--rewrite] [--updateref]\n-\t[--dry-run] [--verbose] ref@\\{specifier\\}...\n+\t[--dry-run | -n] [--verbose] ref@\\{specifier\\}...\n 'git reflog exists' <ref>\n\n Reference logs, or \"reflogs\", record when the tips of branches and\n\n\n-- \n\n========================================================================\nRobert P. J. Day                                 Ottawa, Ontario, CANADA\n                        http://crashcourse.ca\n\nTwitter:                                       http://twitter.com/rpjday\nLinkedIn:                               http://ca.linkedin.com/in/rpjday\n========================================================================\n"},{"id":"333230","messageId":"xmqqh8tnvvom.fsf@gitster.mtv.corp.google.com","threadId":"47272","inReplyTo":"alpine.LFD.2.21.1711211038410.8568@DESKTOP-1GPMCEJ","subject":"Re: [PATCH v2] doc: Add missing \"-n\" (dry-run) option to reflog man page","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-11-22T03:28:25Z","receivedAt":"2017-11-22T03:28:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Robert P. J. Day\" <rpjday@crashcourse.ca> writes:\n\n> While the \"git reflog\" man page supports both \"--dry-run\" and \"-n\" for\n> a dry run, the man page mentions only the former, not the latter.\n>\n> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>\n>\n> ---\n\nI have a suspicion that this was deliberately omitted in order to\nkeep the lines in the description short and concise.  Just adding\n5-columns may appear not to hurt too much, but these things tend to\naccumulate, so...\n\nQueued, so that I won't lose sight of it, but won't merge unless\nsomebody else strongly feels about it.\n\nThanks.\n\n>\n>   sorry, i accidentally chopped off the leading lines of the patch in\n> the earlier post.\n>\n> diff --git a/Documentation/git-reflog.txt b/Documentation/git-reflog.txt\n> index 44c736f1a..472a6808c 100644\n> --- a/Documentation/git-reflog.txt\n> +++ b/Documentation/git-reflog.txt\n> @@ -20,9 +20,9 @@ depending on the subcommand:\n>  'git reflog' ['show'] [log-options] [<ref>]\n>  'git reflog expire' [--expire=<time>] [--expire-unreachable=<time>]\n>  \t[--rewrite] [--updateref] [--stale-fix]\n> -\t[--dry-run] [--verbose] [--all | <refs>...]\n> +\t[--dry-run | -n] [--verbose] [--all | <refs>...]\n>  'git reflog delete' [--rewrite] [--updateref]\n> -\t[--dry-run] [--verbose] ref@\\{specifier\\}...\n> +\t[--dry-run | -n] [--verbose] ref@\\{specifier\\}...\n>  'git reflog exists' <ref>\n>\n>  Reference logs, or \"reflogs\", record when the tips of branches and\n"},{"id":"333255","messageId":"alpine.LFD.2.21.1711220249020.31052@localhost.localdomain","threadId":"47272","inReplyTo":"xmqqh8tnvvom.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH v2] doc: Add missing \"-n\" (dry-run) option to reflog man page","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2017-11-22T07:59:10Z","receivedAt":"2017-11-22T08:00:39Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"On Wed, 22 Nov 2017, Junio C Hamano wrote:\n\n> \"Robert P. J. Day\" <rpjday@crashcourse.ca> writes:\n>\n> > While the \"git reflog\" man page supports both \"--dry-run\" and \"-n\" for\n> > a dry run, the man page mentions only the former, not the latter.\n> >\n> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>\n> >\n> > ---\n>\n> I have a suspicion that this was deliberately omitted in order to\n> keep the lines in the description short and concise.  Just adding\n> 5-columns may appear not to hurt too much, but these things tend to\n> accumulate, so...\n>\n> Queued, so that I won't lose sight of it, but won't merge unless\n> somebody else strongly feels about it.\n\n  i appreciate the need for brevity, but this just takes us back to,\nis there a standard for man pages, given how they bounce around all\nover the place?\n\n  i tossed in that missing \"-n\" option for \"man git-reflog\" since it\nwas the *only* option missing from the SYNOPSIS, and it didn't mess up\nthe aesthetics. but there are other examples that clearly aren't worth\nthe trouble:\n\n  $ man git-clean\n  SYNOPSIS\n    git clean [-d] [-f] [-i] [-n] [-q] [-e <pattern>] [-x | -X] [--] <path>...\n\nwhere *only* the short forms are used in the SYNOPSIS.\n\n  and, finally, there are examples that mix and match, like:\n\n  $ man git-commit\n  SYNOPSIS\n    git commit [-a | --interactive | --patch] ...\n\nwhich uses \"-a\" instead of \"--all\", but \"--patch\" instead of \"-p\". i'm\nfine if someone says, \"there is no standard,\" but if there is, then\nthe docs should follow them.\n\n  thoughts?\n\nrday\n\n-- \n\n========================================================================\nRobert P. J. Day                                 Ottawa, Ontario, CANADA\n                        http://crashcourse.ca\n\nTwitter:                                       http://twitter.com/rpjday\nLinkedIn:                               http://ca.linkedin.com/in/rpjday\n========================================================================\n"},{"id":"333262","messageId":"xmqqy3mysii0.fsf@gitster.mtv.corp.google.com","threadId":"47272","inReplyTo":"alpine.LFD.2.21.1711220249020.31052@localhost.localdomain","subject":"Re: [PATCH v2] doc: Add missing \"-n\" (dry-run) option to reflog man page","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-11-22T10:41:27Z","receivedAt":"2017-11-22T10:41:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Robert P. J. Day\" <rpjday@crashcourse.ca> writes:\n\n>   i appreciate the need for brevity, but this just takes us back to,\n> is there a standard for man pages, given how they bounce around all\n> over the place?\n>\n>   i tossed in that missing \"-n\" option for \"man git-reflog\" since it\n> was the *only* option missing from the SYNOPSIS,...\n\nDon't we also take \"-v\" for \"--verbose\"?\n\nI am not sure what you meant by \"bounce around\", but by adding \"-n\"\nwithout adding \"-v\", doesn't this patch worsen the situation by\nmaking the result even locally inconsistent?\n\n\n"},{"id":"333264","messageId":"alpine.LFD.2.21.1711220543450.10299@DESKTOP-1GPMCEJ","threadId":"47272","inReplyTo":"xmqqy3mysii0.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH v2] doc: Add missing \"-n\" (dry-run) option to reflog man page","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2017-11-22T10:45:22Z","receivedAt":"2017-11-22T10:46:50Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"On Wed, 22 Nov 2017, Junio C Hamano wrote:\n\n> \"Robert P. J. Day\" <rpjday@crashcourse.ca> writes:\n>\n> >   i appreciate the need for brevity, but this just takes us back\n> > to, is there a standard for man pages, given how they bounce\n> > around all over the place?\n> >\n> >   i tossed in that missing \"-n\" option for \"man git-reflog\" since\n> > it was the *only* option missing from the SYNOPSIS,...\n>\n> Don't we also take \"-v\" for \"--verbose\"?\n>\n> I am not sure what you meant by \"bounce around\", but by adding \"-n\"\n> without adding \"-v\", doesn't this patch worsen the situation by\n> making the result even locally inconsistent?\n\n  i don't believe \"git reflog\" supports \"-v\", only \"--verbose\", or am\ni misreading the source?\n\nrday\n\n-- \n\n========================================================================\nRobert P. J. Day                                 Ottawa, Ontario, CANADA\n                        http://crashcourse.ca\n\nTwitter:                                       http://twitter.com/rpjday\nLinkedIn:                               http://ca.linkedin.com/in/rpjday\n========================================================================\n"},{"id":"333285","messageId":"xmqqine2s3m3.fsf@gitster.mtv.corp.google.com","threadId":"47272","inReplyTo":"alpine.LFD.2.21.1711220543450.10299@DESKTOP-1GPMCEJ","subject":"Re: [PATCH v2] doc: Add missing \"-n\" (dry-run) option to reflog man page","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-11-22T16:03:00Z","receivedAt":"2017-11-22T16:03:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Robert P. J. Day\" <rpjday@crashcourse.ca> writes:\n\n>   i don't believe \"git reflog\" supports \"-v\", only \"--verbose\", or am\n> i misreading the source?\n\nAh, then at least you are being (locally) consistent.  Sorry for a\nremembo.\n\nAs to (global) consistency, in the oldest time we tried to list\nevery options (but only in the fully spelled form, IIRC) in the\nsynopsis section, but later with the proliferation of options, it\nbecame more common to use the generic \"git subcmd <options>...\" form\nin synopsis and leave not just the description but also the\nenumeration of the options to the description part of the docs, so\nwe ended up with a mixture in the documentation set.  Aiming for\nglobal consistency is a very good thing, and we need to decide what\nmodel to adhere to and stick to it to the end.  If you want to carry\nthe torch and declare that we would list every option and every\nshort-hand (but not \"--v\", \"--ve\", \"--ver\", ...\"--verbose\" for\nobvious reasons), I personally am fine with that.\n"}]}