{"thread":{"id":"47261","subject":"[PATCH] list-objects-filter-options: fix up some sparse warnings","startedAt":"2017-11-20T23:39:14Z","lastAt":"2017-11-22T00:23:37Z","messageCount":5,"participants":["Ramsay Jones","Jonathan Nieder","Jeff Hostetler","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"333021","messageId":"b1037774-6ae6-630b-f330-e95b1c3d681d@ramsayjones.plus.com","threadId":"47261","inReplyTo":null,"subject":"[PATCH] list-objects-filter-options: fix up some sparse warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-11-20T23:39:05Z","receivedAt":"2017-11-20T23:39:14Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIn particular, sparse complains that the armor_{en,de}code_arg()\nfunctions are 'not declared - should they be static?'. Since the\narmor_decode_arg() symbol does not require more than file visibility,\nwe can simply mark the declaration with static. The armor_encode_arg()\nfunction has no callers, so we simply remove the (unused) definition.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Jeff,\n\nIf you need to re-roll your 'jh/object-filtering' branch, could you\nplease squash this (or something like it) into the relevant patch\n(commit bf0aedcbe1, \"list-objects: filter objects in traverse_commit_list\",\n16-11-2017).\n\nThanks!\n\nATB,\nRamsay Jones\n\n list-objects-filter-options.c | 14 +-------------\n 1 file changed, 1 insertion(+), 13 deletions(-)\n\ndiff --git a/list-objects-filter-options.c b/list-objects-filter-options.c\nindex 0e4ad70ab..bdbadd5a3 100644\n--- a/list-objects-filter-options.c\n+++ b/list-objects-filter-options.c\n@@ -34,19 +34,7 @@ static int arg_needs_armor(const char *arg)\n \treturn 0;\n }\n \n-void armor_encode_arg(struct strbuf *buf, const char *arg)\n-{\n-\tstatic const char hex[] = \"0123456789abcdef\";\n-\tconst unsigned char *p;\n-\n-\tfor (p = (const unsigned char *)arg; *p; p++) {\n-\t\tunsigned int val = *p;\n-\t\tstrbuf_addch(buf, hex[val >> 4]);\n-\t\tstrbuf_addch(buf, hex[val & 0xf]);\n-\t}\n-}\n-\n-int armor_decode_arg(struct strbuf *buf, const char *arg)\n+static int armor_decode_arg(struct strbuf *buf, const char *arg)\n {\n \tconst char *p;\n \n-- \n2.15.0\n"},{"id":"333036","messageId":"20171121011634.dw6tdgp2s7lpl2lm@aiede.mtv.corp.google.com","threadId":"47261","inReplyTo":"b1037774-6ae6-630b-f330-e95b1c3d681d@ramsayjones.plus.com","subject":"Re: [PATCH] list-objects-filter-options: fix up some sparse warnings","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-11-21T01:16:34Z","receivedAt":"2017-11-21T01:16:41Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nRamsay Jones wrote:\n\n> If you need to re-roll your 'jh/object-filtering' branch, could you\n> please squash this (or something like it) into the relevant patch\n> (commit bf0aedcbe1, \"list-objects: filter objects in traverse_commit_list\",\n> 16-11-2017).\n\nMicronit: can these messages use the ISO 8601 order 2017-11-16?\n\nThat way, the date can be read without confusion regardless of what\nlocale the reader is in.\n\nThanks,\nJonathan\n"},{"id":"333089","messageId":"b5a6ddb1-0971-92d1-4cfb-94366d8f14c3@ramsayjones.plus.com","threadId":"47261","inReplyTo":"20171121011634.dw6tdgp2s7lpl2lm@aiede.mtv.corp.google.com","subject":"Re: [PATCH] list-objects-filter-options: fix up some sparse warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-11-21T11:04:51Z","receivedAt":"2017-11-21T11:04:58Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 21/11/17 01:16, Jonathan Nieder wrote:\n> Hi,\n> \n> Ramsay Jones wrote:\n> \n>> If you need to re-roll your 'jh/object-filtering' branch, could you\n>> please squash this (or something like it) into the relevant patch\n>> (commit bf0aedcbe1, \"list-objects: filter objects in traverse_commit_list\",\n>> 16-11-2017).\n> \n> Micronit: can these messages use the ISO 8601 order 2017-11-16?\n\nHmm, I suppose I could try and train my fingers to use this unnatural\norder ... ;-)\n\n[It would probably be easier if I used git to output this for me, rather\nthan typing it into my email client!]\n\nATB,\nRamsay Jones\n\n"},{"id":"333092","messageId":"654367f1-bc59-d546-a37d-dcb8f13ca65e@jeffhostetler.com","threadId":"47261","inReplyTo":"b1037774-6ae6-630b-f330-e95b1c3d681d@ramsayjones.plus.com","subject":"Re: [PATCH] list-objects-filter-options: fix up some sparse warnings","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2017-11-21T12:36:04Z","receivedAt":"2017-11-21T12:36:12Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 11/20/2017 6:39 PM, Ramsay Jones wrote:\n> \n> In particular, sparse complains that the armor_{en,de}code_arg()\n> functions are 'not declared - should they be static?'. Since the\n> armor_decode_arg() symbol does not require more than file visibility,\n> we can simply mark the declaration with static. The armor_encode_arg()\n> function has no callers, so we simply remove the (unused) definition.\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi Jeff,\n> \n> If you need to re-roll your 'jh/object-filtering' branch, could you\n> please squash this (or something like it) into the relevant patch\n> (commit bf0aedcbe1, \"list-objects: filter objects in traverse_commit_list\",\n> 16-11-2017).\n> \n\nthanks for the note.\ni'm going to remove these functions completely in my next version.\nit was decided that we don't need to do encoding/decoding at this level.\n\nThanks,\nJeff\n\n"},{"id":"333202","messageId":"CAGZ79kaKWRMDFQLbeRtGmejOD7JD_RCjK5J_HOFqddReT6yOEA@mail.gmail.com","threadId":"47261","inReplyTo":"b5a6ddb1-0971-92d1-4cfb-94366d8f14c3@ramsayjones.plus.com","subject":"Re: [PATCH] list-objects-filter-options: fix up some sparse warnings","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-11-22T00:23:30Z","receivedAt":"2017-11-22T00:23:37Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"> [It would probably be easier if I used git to output this for me, rather\n> than typing it into my email client!]\n\ngit config alias.gcs \"show --date=short -s --pretty='format:%h (\"%s\", %ad)'\"\n\nwill make you the `git gcs` alias that I use to describe commits.\n"}]}