{"thread":{"id":"47169","subject":"[PATCH v3] bisect: mention \"view\" as an alternative to \"visualize\"","startedAt":"2017-11-11T13:40:17Z","lastAt":"2017-11-12T09:22:40Z","messageCount":3,"participants":["Robert P. J. Day","Junio C Hamano"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"332284","messageId":"alpine.LFD.2.21.1711110838060.9569@localhost.localdomain","threadId":"47169","inReplyTo":null,"subject":"[PATCH v3] bisect: mention \"view\" as an alternative to \"visualize\"","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2017-11-11T13:39:47Z","receivedAt":"2017-11-11T13:40:17Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"Tweak a number of files to mention \"view\" as an alternative to\n\"visualize\".\n\nSigned-off-by: Robert P. J. Day <rpjday@crashcourse.ca>\n\n---\n\n  ... converging slowly ...\n\ndiff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\nindex 6c42abf07..dde720552 100644\n--- a/Documentation/git-bisect.txt\n+++ b/Documentation/git-bisect.txt\n@@ -23,7 +23,7 @@ on the subcommand:\n  git bisect terms [--term-good | --term-bad]\n  git bisect skip [(<rev>|<range>)...]\n  git bisect reset [<commit>]\n- git bisect visualize\n+ git bisect (visualize|view)\n  git bisect replay <logfile>\n  git bisect log\n  git bisect run <cmd>...\n@@ -193,24 +193,23 @@ git bisect start --term-new fixed --term-old broken\n Then, use `git bisect <term-old>` and `git bisect <term-new>` instead\n of `git bisect good` and `git bisect bad` to mark commits.\n\n-Bisect visualize\n-~~~~~~~~~~~~~~~~\n+Bisect visualize/view\n+~~~~~~~~~~~~~~~~~~~~~\n\n To see the currently remaining suspects in 'gitk', issue the following\n-command during the bisection process:\n+command during the bisection process (the subcommand `view` can, in all\n+cases, be used as an alternative to `visualize`):\n\n ------------\n $ git bisect visualize\n ------------\n\n-`view` may also be used as a synonym for `visualize`.\n-\n If the `DISPLAY` environment variable is not set, 'git log' is used\n instead.  You can also give command-line options such as `-p` and\n `--stat`.\n\n ------------\n-$ git bisect view --stat\n+$ git bisect visualize --stat\n ------------\n\n Bisect log and bisect replay\ndiff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c\nindex 35d2105f9..4b5fadcbe 100644\n--- a/builtin/bisect--helper.c\n+++ b/builtin/bisect--helper.c\n@@ -46,7 +46,7 @@ static int check_term_format(const char *term, const char *orig_term)\n \t\treturn error(_(\"'%s' is not a valid term\"), term);\n\n \tif (one_of(term, \"help\", \"start\", \"skip\", \"next\", \"reset\",\n-\t\t\t\"visualize\", \"replay\", \"log\", \"run\", \"terms\", NULL))\n+\t\t\t\"visualize\", \"view\", \"replay\", \"log\", \"run\", \"terms\", NULL))\n \t\treturn error(_(\"can't use the builtin command '%s' as a term\"), term);\n\n \t/*\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex fdd984d34..52f68c922 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1162,7 +1162,7 @@ _git_bisect ()\n {\n \t__git_has_doubledash && return\n\n-\tlocal subcommands=\"start bad good skip reset visualize replay log run\"\n+\tlocal subcommands=\"start bad good skip reset visualize view replay log run\"\n \tlocal subcommand=\"$(__git_find_on_cmdline \"$subcommands\")\"\n \tif [ -z \"$subcommand\" ]; then\n \t\t__git_find_repo_path\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 0138a8860..a82256e34 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -1,6 +1,6 @@\n #!/bin/sh\n\n-USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'\n+USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|view|replay|log|run]'\n LONG_USAGE='git bisect help\n \tprint this long help message.\n git bisect start [--term-{old,good}=<term> --term-{new,bad}=<term>]\n@@ -20,7 +20,7 @@ git bisect next\n \tfind next bisection to test and check it out.\n git bisect reset [<commit>]\n \tfinish bisection search and go back to commit.\n-git bisect visualize\n+git bisect (visualize|view)\n \tshow bisect status in gitk.\n git bisect replay <logfile>\n \treplay bisection log.\n\n\n-- \n\n========================================================================\nRobert P. J. Day                                 Ottawa, Ontario, CANADA\n                        http://crashcourse.ca\n\nTwitter:                                       http://twitter.com/rpjday\nLinkedIn:                               http://ca.linkedin.com/in/rpjday\n========================================================================\n"},{"id":"332309","messageId":"xmqqefp4ca6r.fsf@gitster.mtv.corp.google.com","threadId":"47169","inReplyTo":"alpine.LFD.2.21.1711110838060.9569@localhost.localdomain","subject":"Re: [PATCH v3] bisect: mention \"view\" as an alternative to \"visualize\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-11-12T05:55:56Z","receivedAt":"2017-11-12T05:56:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Robert P. J. Day\" <rpjday@crashcourse.ca> writes:\n\n>  To see the currently remaining suspects in 'gitk', issue the following\n> -command during the bisection process:\n> +command during the bisection process (the subcommand `view` can, in all\n> +cases, be used as an alternative to `visualize`):\n\nI'd drop \", in all cases,\" if I were writing this.\n\nIf it were very common that some \"synonyms\" are only usable in\ncertain limited cases, singling this out and explicitly saying that\n\"'view', unlike many other 'synonyms', is truly a synonym to\nvisualize in all cases\" would make sense and would help readers, but\nI do not think that is the case.  An alternative by definition\nshould be usable \"in all cases\", so I do not think the phrase helps\nthe readers at all.\n\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index fdd984d34..52f68c922 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1162,7 +1162,7 @@ _git_bisect ()\n>  {\n>  \t__git_has_doubledash && return\n>\n> -\tlocal subcommands=\"start bad good skip reset visualize replay log run\"\n> +\tlocal subcommands=\"start bad good skip reset visualize view replay log run\"\n\nThis change makes the end user experience a lot worse, I am afraid.\n\nPeople used to be able to say \"bisect vi<TAB>\" and I'd imagine that\nmany are used to type exactly that.  Now they get two choices and\nhave to say 's' (or 'e') before hitting another <TAB>.\n"},{"id":"332312","messageId":"alpine.LFD.2.21.1711120421270.29376@localhost.localdomain","threadId":"47169","inReplyTo":"xmqqefp4ca6r.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH v3] bisect: mention \"view\" as an alternative to \"visualize\"","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2017-11-12T09:21:53Z","receivedAt":"2017-11-12T09:22:40Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"On Sun, 12 Nov 2017, Junio C Hamano wrote:\n\n> \"Robert P. J. Day\" <rpjday@crashcourse.ca> writes:\n>\n> >  To see the currently remaining suspects in 'gitk', issue the following\n> > -command during the bisection process:\n> > +command during the bisection process (the subcommand `view` can, in all\n> > +cases, be used as an alternative to `visualize`):\n>\n> I'd drop \", in all cases,\" if I were writing this.\n>\n> If it were very common that some \"synonyms\" are only usable in\n> certain limited cases, singling this out and explicitly saying that\n> \"'view', unlike many other 'synonyms', is truly a synonym to\n> visualize in all cases\" would make sense and would help readers, but\n> I do not think that is the case.  An alternative by definition\n> should be usable \"in all cases\", so I do not think the phrase helps\n> the readers at all.\n>\n> > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> > index fdd984d34..52f68c922 100644\n> > --- a/contrib/completion/git-completion.bash\n> > +++ b/contrib/completion/git-completion.bash\n> > @@ -1162,7 +1162,7 @@ _git_bisect ()\n> >  {\n> >  \t__git_has_doubledash && return\n> >\n> > -\tlocal subcommands=\"start bad good skip reset visualize replay log run\"\n> > +\tlocal subcommands=\"start bad good skip reset visualize view replay log run\"\n>\n> This change makes the end user experience a lot worse, I am afraid.\n>\n> People used to be able to say \"bisect vi<TAB>\" and I'd imagine that\n> many are used to type exactly that.  Now they get two choices and\n> have to say 's' (or 'e') before hitting another <TAB>.\n\n  good points, i'll re-roll and re-submit.\n\nrday\n\n-- \n\n========================================================================\nRobert P. J. Day                                 Ottawa, Ontario, CANADA\n                        http://crashcourse.ca\n\nTwitter:                                       http://twitter.com/rpjday\nLinkedIn:                               http://ca.linkedin.com/in/rpjday\n========================================================================\n"}]}