{"thread":{"id":"47141","subject":"Test failures on 'pu' branch","startedAt":"2017-11-08T20:28:55Z","lastAt":"2017-11-08T22:55:46Z","messageCount":5,"participants":["Ramsay Jones","Stefan Beller","Jeff Hostetler"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"332093","messageId":"cf38b57d-1424-0776-b67f-8cfd24e087bb@ramsayjones.plus.com","threadId":"47141","inReplyTo":null,"subject":"Test failures on 'pu' branch","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-11-08T20:28:48Z","receivedAt":"2017-11-08T20:28:55Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi Junio,\n\nYou are probably already aware, but just in case, the 'pu' branch\nfails the testsuite for me as follows:\n\n$ tail -18 ptest-out\nTest Summary Report\n-------------------\nt5300-pack-object.sh                             (Wstat: 256 Tests: 40 Failed: 2)\n  Failed tests:  36-37\n  Non-zero exit status: 1\nt5500-fetch-pack.sh                              (Wstat: 256 Tests: 355 Failed: 6)\n  Failed tests:  350-355\n  Non-zero exit status: 1\nt5601-clone.sh                                   (Wstat: 256 Tests: 102 Failed: 4)\n  Failed tests:  99-102\n  Non-zero exit status: 1\nFiles=800, Tests=16964, 462 wallclock secs ( 4.57 usr  0.78 sys + 57.93 cusr 24.16 csys = 87.44 CPU)\nResult: FAIL\nMakefile:45: recipe for target 'prove' failed\nmake[1]: *** [prove] Error 1\nmake[1]: Leaving directory '/home/ramsay/git/t'\nMakefile:2448: recipe for target 'test' failed\nmake: *** [test] Error 2\n$ \n\nLooking at the first test failure in each file, the failures seems\nto be related to the 'jh/partial-clone' branch.\n\nJust FYI. Thanks.\n\nATB,\nRamsay Jones\n\n"},{"id":"332095","messageId":"CAGZ79kb3NpuWW=BpTjF_DrdVhXHh3d_8aF77Jdpi+8yTxtAbVw@mail.gmail.com","threadId":"47141","inReplyTo":"cf38b57d-1424-0776-b67f-8cfd24e087bb@ramsayjones.plus.com","subject":"Re: Test failures on 'pu' branch","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-11-08T20:36:01Z","receivedAt":"2017-11-08T20:36:07Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Wed, Nov 8, 2017 at 12:28 PM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n\n> t5300-pack-object.sh                             (Wstat: 256 Tests: 40 Failed: 2)\n\n> t5500-fetch-pack.sh                              (Wstat: 256 Tests: 355 Failed: 6)\n\nThese are series\n\n> t5601-clone.sh                                   (Wstat: 256 Tests: 102 Failed: 4)\n\nThis one is a spurious test. I had that flake on me once in the last weeks, too.\nBut upon investigation I could not reproduce.\nSee https://public-inbox.org/git/xmqq376ipdpx.fsf@gitster.mtv.corp.google.com/\n"},{"id":"332097","messageId":"f61cff3c-0d2e-4d6d-4db3-3b419246a760@jeffhostetler.com","threadId":"47141","inReplyTo":"CAGZ79kb3NpuWW=BpTjF_DrdVhXHh3d_8aF77Jdpi+8yTxtAbVw@mail.gmail.com","subject":"Re: Test failures on 'pu' branch","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2017-11-08T22:10:44Z","receivedAt":"2017-11-08T22:10:52Z","isPatch":false,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 11/8/2017 3:36 PM, Stefan Beller wrote:\n> On Wed, Nov 8, 2017 at 12:28 PM, Ramsay Jones\n> <ramsay@ramsayjones.plus.com> wrote:\n> \n>> t5300-pack-object.sh                             (Wstat: 256 Tests: 40 Failed: 2)\n> \n>> t5500-fetch-pack.sh                              (Wstat: 256 Tests: 355 Failed: 6)\n> \n> These are series\n> \n>> t5601-clone.sh                                   (Wstat: 256 Tests: 102 Failed: 4)\n> \n> This one is a spurious test. I had that flake on me once in the last weeks, too.\n> But upon investigation I could not reproduce.\n> See https://public-inbox.org/git/xmqq376ipdpx.fsf@gitster.mtv.corp.google.com/\n> \n\nI suspect that the failures related to the jh/partial-clone-* branches\nare probably due to slight differences between yesterday's part-1 and\nlast week's version of part-2 and part-3.\n\nI'm going to be on vacation until Monday, so can we just pull those\nparts out of 'pu' until I can get you new versions of parts 2 and 3 ?\n\nThanks\nJeff\n"},{"id":"332099","messageId":"e2d10701-2deb-4f03-f4ce-3da7d48effa3@ramsayjones.plus.com","threadId":"47141","inReplyTo":"CAGZ79kb3NpuWW=BpTjF_DrdVhXHh3d_8aF77Jdpi+8yTxtAbVw@mail.gmail.com","subject":"Re: Test failures on 'pu' branch","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-11-08T22:34:49Z","receivedAt":"2017-11-08T22:34:57Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 08/11/17 20:36, Stefan Beller wrote:\n> On Wed, Nov 8, 2017 at 12:28 PM, Ramsay Jones\n> <ramsay@ramsayjones.plus.com> wrote:\n> \n>> t5300-pack-object.sh                             (Wstat: 256 Tests: 40 Failed: 2)\n> \n>> t5500-fetch-pack.sh                              (Wstat: 256 Tests: 355 Failed: 6)\n> \n> These are series\n> \n>> t5601-clone.sh                                   (Wstat: 256 Tests: 102 Failed: 4)\n> \n> This one is a spurious test. I had that flake on me once in the last weeks, too.\n> But upon investigation I could not reproduce.\n> See https://public-inbox.org/git/xmqq376ipdpx.fsf@gitster.mtv.corp.google.com/\n> \n\nNo, this is not related to that. In fact several tests start\nworking if I change the '--filter=blobs:limit=0' to instead\nread '--filter=blob:limit=0' (ie. change blob_s_ to blob).\n\nIn fact t5601 now works with the following patch:\n\n-- >8 --\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex f18d9454a..0074690f7 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -630,7 +630,7 @@ partial_clone () {\n \ttest_config -C \"$SERVER\" uploadpack.allowfilter 1 &&\n \ttest_config -C \"$SERVER\" uploadpack.allowanysha1inwant 1 &&\n \n-\tgit clone --filter=blobs:limit=0 \"$URL\" client &&\n+\tgit clone --filter=blob:limit=0 \"$URL\" client &&\n \n \tgit -C client fsck &&\n \n@@ -651,7 +651,7 @@ test_expect_success 'partial clone: warn if server does not support object filte\n \t\t     test_create_repo server &&\n \t\t     test_commit -C server one &&\n \n-\tgit clone --filter=blobs:limit=0 \"file://$(pwd)/server\" client 2> err &&\n+\tgit clone --filter=blob:limit=0 \"file://$(pwd)/server\" client 2> err &&\n \n \ttest_i18ngrep \"filtering not recognized by server\" err\n '\n@@ -673,7 +673,7 @@ test_expect_success 'batch missing blob request during checkout' '\n \ttest_config -C server uploadpack.allowfilter 1 &&\n \ttest_config -C server uploadpack.allowanysha1inwant 1 &&\n \n-\tgit clone --filter=blobs:limit=0 \"file://$(pwd)/server\" client &&\n+\tgit clone --filter=blob:limit=0 \"file://$(pwd)/server\" client &&\n \n \t# Ensure that there is only one negotiation by checking that there is\n \t# only \"done\" line sent. (\"done\" marks the end of negotiation.)\n@@ -705,7 +705,7 @@ test_expect_success 'batch missing blob request does not inadvertently try to fe\n \ttest_config -C server uploadpack.allowanysha1inwant 1 &&\n \n \t# Make sure that it succeeds\n-\tgit clone --filter=blobs:limit=0 \"file://$(pwd)/server\" client\n+\tgit clone --filter=blob:limit=0 \"file://$(pwd)/server\" client\n '\n \n . \"$TEST_DIRECTORY\"/lib-httpd.sh\n-- 8< --\n\nA similar patch to 't/t5300-pack-object.sh' gets one of the two\nfailing tests working. I haven't looked at 't/t5500-fetch-pack.sh'\nyet.\n\nATB,\nRamsay Jones\n\n\n"},{"id":"332101","messageId":"d4eb2005-aaf0-0ae4-e719-5dae25e7a254@ramsayjones.plus.com","threadId":"47141","inReplyTo":"e2d10701-2deb-4f03-f4ce-3da7d48effa3@ramsayjones.plus.com","subject":"Re: Test failures on 'pu' branch","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-11-08T22:55:36Z","receivedAt":"2017-11-08T22:55:46Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 08/11/17 22:34, Ramsay Jones wrote:\n> \n> \n> On 08/11/17 20:36, Stefan Beller wrote:\n>> On Wed, Nov 8, 2017 at 12:28 PM, Ramsay Jones\n>> <ramsay@ramsayjones.plus.com> wrote:\n>>\n>>> t5300-pack-object.sh                             (Wstat: 256 Tests: 40 Failed: 2)\n>>\n>>> t5500-fetch-pack.sh                              (Wstat: 256 Tests: 355 Failed: 6)\n>>\n>> These are series\n>>\n>>> t5601-clone.sh                                   (Wstat: 256 Tests: 102 Failed: 4)\n>>\n>> This one is a spurious test. I had that flake on me once in the last weeks, too.\n>> But upon investigation I could not reproduce.\n>> See https://public-inbox.org/git/xmqq376ipdpx.fsf@gitster.mtv.corp.google.com/\n>>\n> \n> No, this is not related to that. In fact several tests start\n> working if I change the '--filter=blobs:limit=0' to instead\n> read '--filter=blob:limit=0' (ie. change blob_s_ to blob).\n> \n> In fact t5601 now works with the following patch:\n\nOK, so the patch given below fixes all tests except t5300.37.\nAll the patch does is change 'blobs' to 'blob' in the --filter\nparameters.\n\nThe single failure looks like:\n\n  $ ./t5300-pack-object.sh -i -v\n  ...\n  Initialized empty Git repository in /home/ramsay/git/t/trash   directory.t5300-pack-object/server/.git/\n  [master (root-commit) a72904c] x\n   Author: A U Thor <author@example.com>\n   3 files changed, 3 insertions(+)\n   create mode 100644 .git-a\n   create mode 100644 a\n   create mode 100644 b\n  Counting objects: 2, done.\n  Compressing objects: 100% (2/2), done.\n  Total 2 (delta 0), reused 0 (delta 0)\n  ad26794874784493dafa81f1644b3dcfad05d843\n  not ok 37 - filtering by size never excludes special files\n  #\t\n  #\t\trm -rf server &&\n  #\t\tgit init server &&\n  #\t\tprintf a-very-long-file > server/a &&\n  #\t\tprintf a-very-long-file > server/.git-a &&\n  #\t\tprintf b-very-long-file > server/b &&\n  #\t\tgit -C server add a .git-a b &&\n  #\t\tgit -C server commit -m x &&\n  #\t\n  #\t\tgit -C server rev-parse HEAD >objects &&\n  #\t\tgit -C server pack-objects --revs --stdout --filter=blob:limit=10 <objects >my.pack &&\n  #\t\n  #\t\t# Ensure that the .git-a blob is in the packfile, despite also\n  #\t\t# appearing as a non-.git file\n  #\t\tgit index-pack my.pack &&\n  #\t\tgit verify-pack -v my.idx >objectlist &&\n  #\t\tgrep $(git hash-object server/a) objectlist\n  #\t\n  $ \n\nHope that helps.\n\nATB,\nRamsay Jones\n\n-- >8 --\ndiff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh\nindex 0739a0796..17c9ffdca 100755\n--- a/t/t5300-pack-object.sh\n+++ b/t/t5300-pack-object.sh\n@@ -472,7 +472,7 @@ test_expect_success 'filtering by size works with multiple excluded' '\n \tgit -C server commit -m x &&\n \n \tgit -C server rev-parse HEAD >objects &&\n-\tgit -C server pack-objects --revs --stdout --filter=blobs:limit=10 <objects >my.pack &&\n+\tgit -C server pack-objects --revs --stdout --filter=blob:limit=10 <objects >my.pack &&\n \n \t# Ensure that only the small blobs are in the packfile\n \tgit index-pack my.pack &&\n@@ -493,7 +493,7 @@ test_expect_success 'filtering by size never excludes special files' '\n \tgit -C server commit -m x &&\n \n \tgit -C server rev-parse HEAD >objects &&\n-\tgit -C server pack-objects --revs --stdout --filter=blobs:limit=10 <objects >my.pack &&\n+\tgit -C server pack-objects --revs --stdout --filter=blob:limit=10 <objects >my.pack &&\n \n \t# Ensure that the .git-a blob is in the packfile, despite also\n \t# appearing as a non-.git file\ndiff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh\nindex 86cf65323..08b7a32c7 100755\n--- a/t/t5500-fetch-pack.sh\n+++ b/t/t5500-fetch-pack.sh\n@@ -762,7 +762,7 @@ test_expect_success 'filtering by size' '\n \ttest_config -C server uploadpack.allowfilter 1 &&\n \n \ttest_create_repo client &&\n-\tgit -C client fetch-pack --filter=blobs:limit=0 ../server HEAD &&\n+\tgit -C client fetch-pack --filter=blob:limit=0 ../server HEAD &&\n \n \t# Ensure that object is not inadvertently fetched\n \ttest_must_fail git -C client cat-file -e $(git hash-object server/one.t)\n@@ -774,7 +774,7 @@ test_expect_success 'filtering by size has no effect if support for it is not ad\n \ttest_commit -C server one &&\n \n \ttest_create_repo client &&\n-\tgit -C client fetch-pack --filter=blobs:limit=0 ../server HEAD 2> err &&\n+\tgit -C client fetch-pack --filter=blob:limit=0 ../server HEAD 2> err &&\n \n \t# Ensure that object is fetched\n \tgit -C client cat-file -e $(git hash-object server/one.t) &&\n@@ -800,7 +800,7 @@ setup_blob_max_bytes () {\n do_blob_max_bytes() {\n \tSERVER=\"$1\" &&\n \n-\tgit -C client fetch --filter=blobs:limit=0 origin HEAD:somewhere &&\n+\tgit -C client fetch --filter=blob:limit=0 origin HEAD:somewhere &&\n \n \t# Ensure that commit is fetched, but blob is not\n \ttest_config -C client extensions.partialcloneremote \"arbitrary string\" &&\n@@ -816,7 +816,7 @@ test_expect_success 'fetch with filtering' '\n test_expect_success 'fetch respects configured filtering' '\n \tsetup_blob_max_bytes server server &&\n \n-\ttest_config -C client extensions.partialclonefilter blobs:limit=0 &&\n+\ttest_config -C client extensions.partialclonefilter blob:limit=0 &&\n \n \tgit -C client fetch origin HEAD:somewhere &&\n \n@@ -835,7 +835,7 @@ test_expect_success 'pull respects configured filtering' '\n \ttest_commit -C server three &&\n \n \ttest_config -C server uploadpack.allowanysha1inwant 1 &&\n-\ttest_config -C client extensions.partialclonefilter blobs:limit=0 &&\n+\ttest_config -C client extensions.partialclonefilter blob:limit=0 &&\n \n \tgit -C client pull origin &&\n \n@@ -852,7 +852,7 @@ test_expect_success 'clone configures filtering' '\n \ttest_commit -C server two &&\n \ttest_config -C server uploadpack.allowanysha1inwant 1 &&\n \n-\tgit clone --filter=blobs:limit=12345 server client &&\n+\tgit clone --filter=blob:limit=12345 server client &&\n \n \t# Ensure that we can, for example, checkout HEAD^\n \trm -rf client/.git/objects/* &&\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex f18d9454a..0074690f7 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -630,7 +630,7 @@ partial_clone () {\n \ttest_config -C \"$SERVER\" uploadpack.allowfilter 1 &&\n \ttest_config -C \"$SERVER\" uploadpack.allowanysha1inwant 1 &&\n \n-\tgit clone --filter=blobs:limit=0 \"$URL\" client &&\n+\tgit clone --filter=blob:limit=0 \"$URL\" client &&\n \n \tgit -C client fsck &&\n \n@@ -651,7 +651,7 @@ test_expect_success 'partial clone: warn if server does not support object filte\n \t\t     test_create_repo server &&\n \t\t     test_commit -C server one &&\n \n-\tgit clone --filter=blobs:limit=0 \"file://$(pwd)/server\" client 2> err &&\n+\tgit clone --filter=blob:limit=0 \"file://$(pwd)/server\" client 2> err &&\n \n \ttest_i18ngrep \"filtering not recognized by server\" err\n '\n@@ -673,7 +673,7 @@ test_expect_success 'batch missing blob request during checkout' '\n \ttest_config -C server uploadpack.allowfilter 1 &&\n \ttest_config -C server uploadpack.allowanysha1inwant 1 &&\n \n-\tgit clone --filter=blobs:limit=0 \"file://$(pwd)/server\" client &&\n+\tgit clone --filter=blob:limit=0 \"file://$(pwd)/server\" client &&\n \n \t# Ensure that there is only one negotiation by checking that there is\n \t# only \"done\" line sent. (\"done\" marks the end of negotiation.)\n@@ -705,7 +705,7 @@ test_expect_success 'batch missing blob request does not inadvertently try to fe\n \ttest_config -C server uploadpack.allowanysha1inwant 1 &&\n \n \t# Make sure that it succeeds\n-\tgit clone --filter=blobs:limit=0 \"file://$(pwd)/server\" client\n+\tgit clone --filter=blob:limit=0 \"file://$(pwd)/server\" client\n '\n \n . \"$TEST_DIRECTORY\"/lib-httpd.sh\n-- 8< --\n\n"}]}