{"thread":{"id":"47097","subject":"[PATCH] config: document blame configuration","startedAt":"2017-11-01T22:32:43Z","lastAt":"2017-11-06T01:14:32Z","messageCount":7,"participants":["Stefan Beller","SZEDER Gábor","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"331626","messageId":"20171101223234.14527-1-sbeller@google.com","threadId":"47097","inReplyTo":null,"subject":"[PATCH] config: document blame configuration","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-11-01T22:32:34Z","receivedAt":"2017-11-01T22:32:43Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"The options are currently only referenced by the git-blame man page,\nalso explain them in git-config, which is the canonical page to\ncontain all config options.\n\nSigned-off-by: Stefan Beller \n---\n Documentation/config.txt | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 1ac0ae6adb..b18cead6aa 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -949,6 +949,23 @@ apply.whitespace::\n \tTells 'git apply' how to handle whitespaces, in the same way\n \tas the `--whitespace` option. See linkgit:git-apply[1].\n \n+blame.root::\n+\tDo not treat root commits as boundaries in `git-blame`.\n+\tThis option defaults to false.\n+\n+blame.blankboundary::\n+\tShow blank SHA-1 for boundary commits in `git-blame`.\n+\tThis option defaults to false.\n+\n+blame.showemail::\n+\tShow the author email instead of author name in `git-blame`.\n+\tThis option defaults to false.\n+\n+blame.date::\n+\tSpecifies the format used to output dates in `git-blame`.\n+\tIf unset the iso format is used. For supported values,\n+\tsee the discussion of the --date option at linkgit:git-log[1].\n+\n branch.autoSetupMerge::\n \tTells 'git branch' and 'git checkout' to set up new branches\n \tso that linkgit:git-pull[1] will appropriately merge from the\n-- \n2.15.0.7.g980e40477f\n\n"},{"id":"331632","messageId":"20171102000722.1503-1-szeder.dev@gmail.com","threadId":"47097","inReplyTo":"20171101223234.14527-1-sbeller@google.com","subject":"Re: [PATCH] config: document blame configuration","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2017-11-02T00:07:22Z","receivedAt":"2017-11-02T00:07:34Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"> The options are currently only referenced by the git-blame man page,\n> also explain them in git-config, which is the canonical page to\n> contain all config options.\n\nGood idea.\n\n> Signed-off-by: Stefan Beller \n> ---\n> Documentation/config.txt | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n> \n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index 1ac0ae6adb..b18cead6aa 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -949,6 +949,23 @@ apply.whitespace::\n> \tTells 'git apply' how to handle whitespaces, in the same way\n> \tas the `--whitespace` option. See linkgit:git-apply[1].\n> \n> +blame.root::\n\nThis is blame.showRoot, isn't it?\n\n> +\tDo not treat root commits as boundaries in `git-blame`.\n\nYou consistently write `git-blame`, i.e. with dash and between\nbackticks. The patch context mentions five git commands: two of them\nare linkgit macros, but the other three are all written without dash\nand between single quotes. I think it should be written without dash,\nbut I'm not sure about single quotes vs. backticks. grep tells me\nthey are both widespread for enclosing git commands.\n\n> +\tThis option defaults to false.\n> +\n> +blame.blankboundary::\n\nConfig variables are usually written in camelCase in the\ndocumentation, see e.g. branch.autoSetupMerge in the patch context\nbelow.\n\n> +\tShow blank SHA-1 for boundary commits in `git-blame`.\n\nPerhaps \"Show blank object ID\", since we're moving away from SHA-1?\n\n> +\tThis option defaults to false.\n> +\n> +blame.showemail::\n\nAgain camelCase.\n\n> +\tShow the author email instead of author name in `git-blame`.\n> +\tThis option defaults to false.\n> +\n> +blame.date::\n> +\tSpecifies the format used to output dates in `git-blame`.\n> +\tIf unset the iso format is used. For supported values,\n> +\tsee the discussion of the --date option at linkgit:git-log[1].\n\nShould '--date' be enclosed in... single quotes or backticks? I don't\nknow.\n\n> +\n> branch.autoSetupMerge::\n> \tTells 'git branch' and 'git checkout' to set up new branches\n> \tso that linkgit:git-pull[1] will appropriately merge from the\n> -- \n> 2.15.0.7.g980e40477f\n> \n> \n"},{"id":"331682","messageId":"20171102181048.16417-1-sbeller@google.com","threadId":"47097","inReplyTo":"20171102000722.1503-1-szeder.dev@gmail.com","subject":"[PATCHv2] config: document blame configuration","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-11-02T18:10:48Z","receivedAt":"2017-11-02T18:10:58Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"The options are currently only referenced by the git-blame man page,\nalso explain them in git-config, which is the canonical page to\ncontain all config options.\n\nSigned-off-by: Stefan Beller \n---\n\n * correct option to blame.showRoot\n * camelCased other options\n * use linkgit:git-[1] instead of `git-cmd` as that\n is correct, but maybe overused.\n * --date is `backticked` now.\n\n Documentation/config.txt | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 1ac0ae6adb..ba0156b1e8 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -949,6 +949,23 @@ apply.whitespace::\n \tTells 'git apply' how to handle whitespaces, in the same way\n \tas the `--whitespace` option. See linkgit:git-apply[1].\n \n+blame.showRoot::\n+\tDo not treat root commits as boundaries in linkgit:git-blame[1].\n+\tThis option defaults to false.\n+\n+blame.blankBoundary::\n+\tShow blank SHA-1 for boundary commits in linkgit:git-blame[1].\n+\tThis option defaults to false.\n+\n+blame.showEmail::\n+\tShow the author email instead of author name in linkgit:git-blame[1].\n+\tThis option defaults to false.\n+\n+blame.date::\n+\tSpecifies the format used to output dates in linkgit:git-blame[1].\n+\tIf unset the iso format is used. For supported values,\n+\tsee the discussion of the `--date` option at linkgit:git-log[1].\n+\n branch.autoSetupMerge::\n \tTells 'git branch' and 'git checkout' to set up new branches\n \tso that linkgit:git-pull[1] will appropriately merge from the\n-- \n2.15.0.7.g980e40477f\n\n"},{"id":"331754","messageId":"CAM0VKjn7=eCZpz-naWv5SjrpjXFs+wVCOXLN852cfvSoZTuJrg@mail.gmail.com","threadId":"47097","inReplyTo":"20171102181048.16417-1-sbeller@google.com","subject":"Re: [PATCHv2] config: document blame configuration","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2017-11-03T01:26:27Z","receivedAt":"2017-11-03T01:26:34Z","isPatch":false,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Thu, Nov 2, 2017 at 7:10 PM, Stefan Beller wrote:\n\n> +blame.blankBoundary::\n> + Show blank SHA-1 for boundary commits in linkgit:git-blame[1].\n\nThis is still SHA-1 instead of object id (or perhaps \"commit object\nname\" would be even better).\nNot sure whether oversight or intentional.\n"},{"id":"331758","messageId":"CAGZ79kZaCwU8S8R-nAzCcV=izpTnsbZsBjJLpoWkid2AF54f9g@mail.gmail.com","threadId":"47097","inReplyTo":"CAM0VKjn7=eCZpz-naWv5SjrpjXFs+wVCOXLN852cfvSoZTuJrg@mail.gmail.com","subject":"Re: [PATCHv2] config: document blame configuration","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-11-03T02:27:30Z","receivedAt":"2017-11-03T02:27:35Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Thu, Nov 2, 2017 at 6:26 PM, SZEDER Gábor wrote:\n> On Thu, Nov 2, 2017 at 7:10 PM, Stefan Beller wrote:\n>\n>> +blame.blankBoundary::\n>> + Show blank SHA-1 for boundary commits in linkgit:git-blame[1].\n>\n> This is still SHA-1 instead of object id (or perhaps \"commit object\n> name\" would be even better).\n> Not sure whether oversight or intentional.\n\ndefinitely oversight.\n"},{"id":"331802","messageId":"20171103192158.1669-1-sbeller@google.com","threadId":"47097","inReplyTo":"CAGZ79kZaCwU8S8R-nAzCcV=izpTnsbZsBjJLpoWkid2AF54f9g@mail.gmail.com","subject":"[PATCH] config: document blame configuration","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-11-03T19:21:58Z","receivedAt":"2017-11-03T19:22:08Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"The options are currently only referenced by the git-blame man page,\nalso explain them in git-config, which is the canonical page to\ncontain all config options.\n\nSigned-off-by: Stefan Beller \n---\n\n Now with 'commit object name'.\n Thanks!\n \n Documentation/config.txt | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 1ac0ae6adb..9593bfabaa 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -949,6 +949,23 @@ apply.whitespace::\n \tTells 'git apply' how to handle whitespaces, in the same way\n \tas the `--whitespace` option. See linkgit:git-apply[1].\n \n+blame.showRoot::\n+\tDo not treat root commits as boundaries in linkgit:git-blame[1].\n+\tThis option defaults to false.\n+\n+blame.blankBoundary::\n+\tShow blank commit object name for boundary commits in\n+\tlinkgit:git-blame[1]. This option defaults to false.\n+\n+blame.showEmail::\n+\tShow the author email instead of author name in linkgit:git-blame[1].\n+\tThis option defaults to false.\n+\n+blame.date::\n+\tSpecifies the format used to output dates in linkgit:git-blame[1].\n+\tIf unset the iso format is used. For supported values,\n+\tsee the discussion of the `--date` option at linkgit:git-log[1].\n+\n branch.autoSetupMerge::\n \tTells 'git branch' and 'git checkout' to set up new branches\n \tso that linkgit:git-pull[1] will appropriately merge from the\n-- \n2.15.0.7.g980e40477f\n\n"},{"id":"331894","messageId":"xmqq1slcky31.fsf@gitster.mtv.corp.google.com","threadId":"47097","inReplyTo":"20171103192158.1669-1-sbeller@google.com","subject":"Re: [PATCH] config: document blame configuration","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-11-06T01:14:26Z","receivedAt":"2017-11-06T01:14:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller writes:\n\n> The options are currently only referenced by the git-blame man page,\n> also explain them in git-config, which is the canonical page to\n> contain all config options.\n>\n> Signed-off-by: Stefan Beller \n> ---\n\nExcellent. Will queue. Thanks.\n"}]}