{"thread":{"id":"47095","subject":"Git 2.15.0 on OSX 10.12.6: gui multi-select stage","startedAt":"2017-11-01T18:59:37Z","lastAt":"2018-01-06T12:20:15Z","messageCount":7,"participants":["Matthew Orres","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"331592","messageId":"CAKbB5OwxQ4XtLXuu2w3QmuKryA=3iHupz=y0m2E1NH+Dwzd8Xw@mail.gmail.com","threadId":"47095","inReplyTo":null,"subject":"Git 2.15.0 on OSX 10.12.6: gui multi-select stage","fromName":"Matthew Orres","fromEmail":"matthew.orres@gmail.com","sentAt":"2017-11-01T18:59:28Z","receivedAt":"2017-11-01T18:59:37Z","isPatch":false,"sender":{"key":"matthew.orres@gmail.com","avatar":"https://gravatar.com/avatar/7a281238d7b65dc0c34074c83c1a070913e30fb3eff1f3904f1c62e0fdfe4b1e?d=mp&s=160"},"body":"Using 2.15.0 on OSX 10.12.6, when I open git gui, and then attempt to\nstage multiple files as such:\n\n* Left click first file\n* CMD+Shift+Click last file to multi-select all files\n* CMT+T (shortcut for Stage to Commit)\n\nOnly the file I selected with the first Left Click is staged and my\nselection disappears.\n\nI'd be happy to provide more system-level info if there's issues with\nreproducing this on other machines.\n"},{"id":"331616","messageId":"alpine.DEB.2.21.1.1711012254380.6482@virtualbox","threadId":"47095","inReplyTo":"CAKbB5OwxQ4XtLXuu2w3QmuKryA=3iHupz=y0m2E1NH+Dwzd8Xw@mail.gmail.com","subject":"Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-11-01T21:58:20Z","receivedAt":"2017-11-01T21:58:30Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Matthew,\n\nOn Wed, 1 Nov 2017, Matthew Orres wrote:\n\n> Using 2.15.0 on OSX 10.12.6, when I open git gui, and then attempt to\n> stage multiple files as such:\n> \n> * Left click first file\n> * CMD+Shift+Click last file to multi-select all files\n> * CMT+T (shortcut for Stage to Commit)\n> \n> Only the file I selected with the first Left Click is staged and my\n> selection disappears.\n> \n> I'd be happy to provide more system-level info if there's issues with\n> reproducing this on other machines.\n\nMaybe you'll be also happy to test things?\n\nI believe that we carry a fix for this in Git for Windows:\nhttps://github.com/git-for-windows/git/commit/3a5640fd3f0aa57edecc8dab455a97c5a15e6626\n\nThe easiest way to test this would be to simply build Git from the\n`master` branch of https://github.com/git-for-windows/git (I try to keep\nit building and passing the test suite at all times not only on Windows,\nbut also on Linux, it should also work on macOS).\n\nCiao,\nJohannes\n\nP.S.: If you test this, and can confirm that it fixes your issue, I'll get\nthis patch submitted properly to the Git mailing list (sadly, it seems\nthat the https://github.com/patthoyts/git-gui project is sleeping beauty\nmode for a while now, otherwise I would add PRs there).\n"},{"id":"335966","messageId":"CAKbB5OxZ1Mua0zNMpe8nt8cQbasUyfz0uNzOXL9FJXWrsqPN-g@mail.gmail.com","threadId":"47095","inReplyTo":"alpine.DEB.2.21.1.1711012254380.6482@virtualbox","subject":"Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage","fromName":"Matthew Orres","fromEmail":"matthew.orres@gmail.com","sentAt":"2018-01-05T20:26:27Z","receivedAt":"2018-01-05T20:26:34Z","isPatch":false,"sender":{"key":"matthew.orres@gmail.com","avatar":"https://gravatar.com/avatar/7a281238d7b65dc0c34074c83c1a070913e30fb3eff1f3904f1c62e0fdfe4b1e?d=mp&s=160"},"body":"I'd be glad to give it a try - but am unfamiliar with how portable a\nmanual build of Git can be used along side the version I have\ninstalled via Homebrew - do I just use full paths to reference the\ncompiled executable from within my repository folder?\n\nThanks!\n\nOn Wed, Nov 1, 2017 at 5:58 PM, Johannes Schindelin\n<Johannes.Schindelin@gmx.de> wrote:\n> Hi Matthew,\n>\n> On Wed, 1 Nov 2017, Matthew Orres wrote:\n>\n>> Using 2.15.0 on OSX 10.12.6, when I open git gui, and then attempt to\n>> stage multiple files as such:\n>>\n>> * Left click first file\n>> * CMD+Shift+Click last file to multi-select all files\n>> * CMT+T (shortcut for Stage to Commit)\n>>\n>> Only the file I selected with the first Left Click is staged and my\n>> selection disappears.\n>>\n>> I'd be happy to provide more system-level info if there's issues with\n>> reproducing this on other machines.\n>\n> Maybe you'll be also happy to test things?\n>\n> I believe that we carry a fix for this in Git for Windows:\n> https://github.com/git-for-windows/git/commit/3a5640fd3f0aa57edecc8dab455a97c5a15e6626\n>\n> The easiest way to test this would be to simply build Git from the\n> `master` branch of https://github.com/git-for-windows/git (I try to keep\n> it building and passing the test suite at all times not only on Windows,\n> but also on Linux, it should also work on macOS).\n>\n> Ciao,\n> Johannes\n>\n> P.S.: If you test this, and can confirm that it fixes your issue, I'll get\n> this patch submitted properly to the Git mailing list (sadly, it seems\n> that the https://github.com/patthoyts/git-gui project is sleeping beauty\n> mode for a while now, otherwise I would add PRs there).\n"},{"id":"336011","messageId":"nycvar.QRO.7.76.6.1801052209330.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet","threadId":"47095","inReplyTo":"CAKbB5OxZ1Mua0zNMpe8nt8cQbasUyfz0uNzOXL9FJXWrsqPN-g@mail.gmail.com","subject":"Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-01-05T21:10:42Z","receivedAt":"2018-01-05T21:10:50Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Matthew,\n\nOn Fri, 5 Jan 2018, Matthew Orres wrote:\n\n> I'd be glad to give it a try - but am unfamiliar with how portable a\n> manual build of Git can be used along side the version I have\n> installed via Homebrew - do I just use full paths to reference the\n> compiled executable from within my repository folder?\n\nNo. If you want to avoid installing Git, and instead want to run it\nin-place after building it, you have to use --exec-path, like so:\n\n$HOME/my-git-checkout/git --exec-path=$HOME/my-git-checkout gui\n\nCiao,\nJohannes\n"},{"id":"336020","messageId":"CAKbB5OwoO22vA3r9J9WAgzxGGScyDE7xM+msGCU_qn2XHU+nbQ@mail.gmail.com","threadId":"47095","inReplyTo":"nycvar.QRO.7.76.6.1801052240440.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet","subject":"Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage","fromName":"Matthew Orres","fromEmail":"matthew.orres@gmail.com","sentAt":"2018-01-05T21:50:34Z","receivedAt":"2018-01-05T21:50:40Z","isPatch":false,"sender":{"key":"matthew.orres@gmail.com","avatar":"https://gravatar.com/avatar/7a281238d7b65dc0c34074c83c1a070913e30fb3eff1f3904f1c62e0fdfe4b1e?d=mp&s=160"},"body":"Beautiful!\n\nPulled down that commit, was able to build and can confirm the issue\nis fixed in git gui!\n\nThis has been a thorn in my side, so I appreciate your help! I look\nforward to it being included in the next release for git in Homebrew!\n:)\n\nOn Fri, Jan 5, 2018 at 4:41 PM, Johannes Schindelin <schindelin@wisc.edu> wrote:\n> Hi Matthew,\n>\n> On Fri, 5 Jan 2018, Matthew Orres wrote:\n>\n>> builtin/checkout.c:24:10: fatal error: 'fscache.h' file not found\n>> #include \"fscache.h\"\n>>          ^~~~~~~~~~~\n>> 1 error generated.\n>\n> I already had pushed a fix for this, have you re-pulled?\n>\n> Ciao,\n> Johannes\n"},{"id":"336048","messageId":"nycvar.QRO.7.76.6.1801061311250.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet","threadId":"47095","inReplyTo":"CAKbB5OwoO22vA3r9J9WAgzxGGScyDE7xM+msGCU_qn2XHU+nbQ@mail.gmail.com","subject":"Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-01-06T12:13:06Z","receivedAt":"2018-01-06T12:13:17Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Matthew,\n\nOn Fri, 5 Jan 2018, Matthew Orres wrote:\n\n> Beautiful!\n> \n> Pulled down that commit, was able to build and can confirm the issue\n> is fixed in git gui!\n> \n> This has been a thorn in my side, so I appreciate your help! I look\n> forward to it being included in the next release for git in Homebrew!\n> :)\n\nWell, a little bit more help from your side would be nice. For example,\nyou could report back *to the Git mailing list* that it helped you.\nOtherwise, how is the Git maintainer to know that these commits help\nanything?\n\nAlso: it is *quite* late in the release cycle right now. We are at\nv2.16.0-rc1, there will be one more release candidate in the coming week,\nand then the final v2.16.0 in the next week.\n\nI highly doubt that the patches (which I still have to identify) will make\nit into that release.\n\nCiao,\nJohannes\n"},{"id":"336050","messageId":"nycvar.QRO.7.76.6.1801061319170.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet","threadId":"47095","inReplyTo":"nycvar.QRO.7.76.6.1801061311250.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet","subject":"Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-01-06T12:20:09Z","receivedAt":"2018-01-06T12:20:15Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 6 Jan 2018, Johannes Schindelin wrote:\n\n> On Fri, 5 Jan 2018, Matthew Orres wrote:\n> \n> > Beautiful!\n> > \n> > Pulled down that commit, was able to build and can confirm the issue\n> > is fixed in git gui!\n> > \n> > This has been a thorn in my side, so I appreciate your help! I look\n> > forward to it being included in the next release for git in Homebrew!\n> > :)\n> \n> Well, a little bit more help from your side would be nice. For example,\n> you could report back *to the Git mailing list* that it helped you.\n> Otherwise, how is the Git maintainer to know that these commits help\n> anything?\n\nSorry, I probably need to take out my eyes and screw them in right, I\ntotally did not see that you Cc:ed the Git mailing list. Sorry.\n\n> Also: it is *quite* late in the release cycle right now. We are at\n> v2.16.0-rc1, there will be one more release candidate in the coming week,\n> and then the final v2.16.0 in the next week.\n> \n> I highly doubt that the patches (which I still have to identify) will make\n> it into that release.\n\nThis is still true, though.\n\nCiao,\nJohannes\n"}]}