{"thread":{"id":"46951","subject":"Unable to use --patch with git add","startedAt":"2017-10-11T17:47:04Z","lastAt":"2017-10-12T03:06:05Z","messageCount":8,"participants":["Ayush Goel","Santiago Torres","Jeff King","Kevin Daudt","Jonathan Nieder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"330185","messageId":"CAEBs8jLnU44n2fhE8tGommqfEpFPdd0FLUtmeZXZ+qhB1RV6XQ@mail.gmail.com","threadId":"46951","inReplyTo":null,"subject":"Unable to use --patch with git add","fromName":"Ayush Goel","fromEmail":"ayushgoel111@gmail.com","sentAt":"2017-10-11T17:46:39Z","receivedAt":"2017-10-11T17:47:04Z","isPatch":false,"sender":{"key":"ayushgoel111@gmail.com","avatar":"https://gravatar.com/avatar/520086e03265ae8ba03ef658da6344327d880db719bff4b9234009cb05d3c328?d=mp&s=160"},"body":"$ git --version\ngit version 2.14.2\n\nWhat more details can I provide to help debug this?\n\n-- \nRegards,\nAyush Goel\n"},{"id":"330186","messageId":"20171011174952.almye3qa2tmyrmol@LykOS.localdomain","threadId":"46951","inReplyTo":"CAEBs8jLnU44n2fhE8tGommqfEpFPdd0FLUtmeZXZ+qhB1RV6XQ@mail.gmail.com","subject":"Re: Unable to use --patch with git add","fromName":"Santiago Torres","fromEmail":"santiago@nyu.edu","sentAt":"2017-10-11T17:49:52Z","receivedAt":"2017-10-11T17:49:33Z","isPatch":false,"sender":{"key":"santiago@nyu.edu","avatar":"https://avatars.githubusercontent.com/u/3579933?v=4"},"body":"It'd be helpful to know:\n\n- What did you do?\n- What did you expect to happen?\n- What happened instead?\n\nI suspect you are using --patch with a new file, so you probably need to first\nadd it with -N or so. This is just a shot in the dark though...\n\nThanks,\n-Santiago.\n\nOn Wed, Oct 11, 2017 at 11:16:39PM +0530, Ayush Goel wrote:\n> $ git --version\n> git version 2.14.2\n> \n> What more details can I provide to help debug this?\n> \n> -- \n> Regards,\n> Ayush Goel\n"},{"id":"330187","messageId":"CAEBs8jKAsb3B-6WJ=ptL2AsGvDRFVPYLCsztpdTN6KCBLOo1XA@mail.gmail.com","threadId":"46951","inReplyTo":"20171011174952.almye3qa2tmyrmol@LykOS.localdomain","subject":"Re: Unable to use --patch with git add","fromName":"Ayush Goel","fromEmail":"ayushgoel111@gmail.com","sentAt":"2017-10-11T17:55:52Z","receivedAt":"2017-10-11T17:56:17Z","isPatch":false,"sender":{"key":"ayushgoel111@gmail.com","avatar":"https://gravatar.com/avatar/520086e03265ae8ba03ef658da6344327d880db719bff4b9234009cb05d3c328?d=mp&s=160"},"body":"Hello Santiago,\n\nThank you for picking this up.\n\n\nOn Wed, Oct 11, 2017 at 11:19 PM, Santiago Torres <santiago@nyu.edu> wrote:\n> It'd be helpful to know:\n>\n> - What did you do?\n\nI have recently updated to git version 2.14.2. The problem started\nhappening after that.\nMade changes to a file. Tried `git add -p`.\n\n> - What did you expect to happen?\n\nEnter the patch add mode of git.\n\n> - What happened instead?\n\nUsual git patch mode is that it shows a patch and expects user to\nadd/skip/split etc. Instead it never stops to take input from me.\n\nSee this ->\n\n\ngit add -p\ndiff --git a/Tests/OSXTests/TDTStreamingTests.m\nb/Tests/OSXTests/TDTStreamingTests.m\nindex 35757bc..525fe56 100644\n--- a/Tests/OSXTests/TDTStreamingTests.m\n+++ b/Tests/OSXTests/TDTStreamingTests.m\n@@ -116,7 +116,7 @@ static NSTask *compressionServerTask;\n }\n\n - (void)breathe {\n-  NSDate *date = [NSDate dateWithTimeIntervalSinceNow:0.1];\n+  NSDate *date = [NSDate dateWithTimeIntervalSinceNow:0.01];\n   [[NSRunLoop currentRunLoop] runUntilDate:date];\n }\n\n#### Expecting git input mode to stop the process here #####\n#### Instead git exits without any error #####\n\n>\n> I suspect you are using --patch with a new file, so you probably need to first\n> add it with -N or so. This is just a shot in the dark though...\n>\n\nNot adding new file.\n\n> Thanks,\n> -Santiago.\n>\n> On Wed, Oct 11, 2017 at 11:16:39PM +0530, Ayush Goel wrote:\n>> $ git --version\n>> git version 2.14.2\n>>\n>> What more details can I provide to help debug this?\n>>\n>> --\n>> Regards,\n>> Ayush Goel\n\n\n\n-- \nRegards,\nAyush Goel\n"},{"id":"330188","messageId":"20171011180015.mqn5xkj5z4yjdrhm@sigill.intra.peff.net","threadId":"46951","inReplyTo":"CAEBs8jKAsb3B-6WJ=ptL2AsGvDRFVPYLCsztpdTN6KCBLOo1XA@mail.gmail.com","subject":"Re: Unable to use --patch with git add","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-10-11T18:00:15Z","receivedAt":"2017-10-11T18:00:24Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Oct 11, 2017 at 11:25:52PM +0530, Ayush Goel wrote:\n\n> On Wed, Oct 11, 2017 at 11:19 PM, Santiago Torres <santiago@nyu.edu> wrote:\n> > It'd be helpful to know:\n> >\n> > - What did you do?\n> \n> I have recently updated to git version 2.14.2. The problem started\n> happening after that.\n> Made changes to a file. Tried `git add -p`.\n\nThis is a known issue in v2.14.2 with having \"color.ui\" set to \"always\"\nin your config.\n\nThere's a fix in v2.15.0-rc1. You can either upgrade to that, or as a\nworkaround set \"color.ui\" to \"auto\" (or remove it completely from your\nconfig, as \"auto\" is the default).\n\n-Peff\n"},{"id":"330193","messageId":"CAEBs8jLyvyE+t=9mDHkD0nUY2SBYymg44BeQbUF0Li4CSZhMWg@mail.gmail.com","threadId":"46951","inReplyTo":"20171011180015.mqn5xkj5z4yjdrhm@sigill.intra.peff.net","subject":"Re: Unable to use --patch with git add","fromName":"Ayush Goel","fromEmail":"ayushgoel111@gmail.com","sentAt":"2017-10-11T18:13:46Z","receivedAt":"2017-10-11T18:14:12Z","isPatch":false,"sender":{"key":"ayushgoel111@gmail.com","avatar":"https://gravatar.com/avatar/520086e03265ae8ba03ef658da6344327d880db719bff4b9234009cb05d3c328?d=mp&s=160"},"body":"Hey Jeff,\n\nThank you for your mail. It works :)\n\nFor future reference, is there a page for known issues of git?\n\nOn Wed, Oct 11, 2017 at 11:30 PM, Jeff King <peff@peff.net> wrote:\n> On Wed, Oct 11, 2017 at 11:25:52PM +0530, Ayush Goel wrote:\n>\n>> On Wed, Oct 11, 2017 at 11:19 PM, Santiago Torres <santiago@nyu.edu> wrote:\n>> > It'd be helpful to know:\n>> >\n>> > - What did you do?\n>>\n>> I have recently updated to git version 2.14.2. The problem started\n>> happening after that.\n>> Made changes to a file. Tried `git add -p`.\n>\n> This is a known issue in v2.14.2 with having \"color.ui\" set to \"always\"\n> in your config.\n>\n> There's a fix in v2.15.0-rc1. You can either upgrade to that, or as a\n> workaround set \"color.ui\" to \"auto\" (or remove it completely from your\n> config, as \"auto\" is the default).\n>\n> -Peff\n\n\n\n-- \nRegards,\nAyush Goel\n"},{"id":"330194","messageId":"20171011182709.be6qwvbsdnam66u7@sigill.intra.peff.net","threadId":"46951","inReplyTo":"CAEBs8jLyvyE+t=9mDHkD0nUY2SBYymg44BeQbUF0Li4CSZhMWg@mail.gmail.com","subject":"Re: Unable to use --patch with git add","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-10-11T18:27:09Z","receivedAt":"2017-10-11T18:27:16Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Oct 11, 2017 at 11:43:46PM +0530, Ayush Goel wrote:\n\n> Thank you for your mail. It works :)\n> \n> For future reference, is there a page for known issues of git?\n\nNo, there's just the mailing list archive. But you can search it. E.g.:\n\n  https://public-inbox.org/git/?q=%22add+-p%22\n\nfinds the relevant threads.\n\n-Peff\n"},{"id":"330197","messageId":"20171011184907.GD16800@alpha.vpn.ikke.info","threadId":"46951","inReplyTo":"CAEBs8jLnU44n2fhE8tGommqfEpFPdd0FLUtmeZXZ+qhB1RV6XQ@mail.gmail.com","subject":"Re: Unable to use --patch with git add","fromName":"Kevin Daudt","fromEmail":"me@ikke.info","sentAt":"2017-10-11T18:49:07Z","receivedAt":"2017-10-11T18:49:15Z","isPatch":false,"sender":{"key":"me@ikke.info","avatar":"https://avatars.githubusercontent.com/u/135698?v=4"},"body":"On Wed, Oct 11, 2017 at 11:16:39PM +0530, Ayush Goel wrote:\n> $ git --version\n> git version 2.14.2\n> \n> What more details can I provide to help debug this?\n> \n\nHello Ayush,\n\nRun:\n\n  git config --global color.ui auto\n  git config --unset --local color.ui #in case it's set locally\n\nThis is a known 'breakage' because people have set color.ui to always\n(which should not be used anyway).\n\nKind regards, Kevin\n"},{"id":"330230","messageId":"20171012030543.GA155740@aiede.mtv.corp.google.com","threadId":"46951","inReplyTo":"CAEBs8jLyvyE+t=9mDHkD0nUY2SBYymg44BeQbUF0Li4CSZhMWg@mail.gmail.com","subject":"Re: Unable to use --patch with git add","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-10-12T03:05:43Z","receivedAt":"2017-10-12T03:06:05Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi Ayush,\n\nAyush Goel wrote:\n\n> Thank you for your mail. It works :)\n>\n> For future reference, is there a page for known issues of git?\n\nWe usually try not to have known issues that would require such a\nwarning for long.  And when we fail, reminders like yours are very\nwelcome, though a search through the mailing list archive for an\nexisting thread to reply to instead of starting a new one is always\nwelcome.\n\nSorry for the trouble.\n\nSincerely,\nJonathan\n"}]}