{"thread":{"id":"46928","subject":"[bug] git add -p breaks, if color.ui is set to \"always\"","startedAt":"2017-10-06T14:37:36Z","lastAt":"2017-10-06T15:42:46Z","messageCount":2,"participants":["Alexander Gehrke","Kevin Daudt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"329892","messageId":"20171006124730.onetucvpt3btlali@wheatley.informatik.uni-wuerzburg.de","threadId":"46928","inReplyTo":null,"subject":"[bug] git add -p breaks, if color.ui is set to \"always\"","fromName":"Alexander Gehrke","fromEmail":"alexander.gehrke@qwertyuiop.de","sentAt":"2017-10-06T12:47:30Z","receivedAt":"2017-10-06T14:37:36Z","isPatch":false,"sender":{"key":"alexander.gehrke@qwertyuiop.de","avatar":null},"body":"After an update to version 2.14.2 from 2.14.1 \"git add --patch\" stopped working\nfor me, just producing the same output as \"git diff\", but not prompting to stage\nanything.\n\nI found that unsetting the config key color.ui, which was set to \"always\" fixed\nthe problem.\n\nFrom the manpage, color.ui should not have that effect and \"always\" should be a\nlegal value.\n\nRegards\nAlexander Gehrke\n"},{"id":"329899","messageId":"20171006154239.GA9299@alpha.vpn.ikke.info","threadId":"46928","inReplyTo":"20171006124730.onetucvpt3btlali@wheatley.informatik.uni-wuerzburg.de","subject":"Re: [bug] git add -p breaks, if color.ui is set to \"always\"","fromName":"Kevin Daudt","fromEmail":"me@ikke.info","sentAt":"2017-10-06T15:42:39Z","receivedAt":"2017-10-06T15:42:46Z","isPatch":false,"sender":{"key":"me@ikke.info","avatar":"https://avatars.githubusercontent.com/u/135698?v=4"},"body":"On Fri, Oct 06, 2017 at 02:47:30PM +0200, Alexander Gehrke wrote:\n> After an update to version 2.14.2 from 2.14.1 \"git add --patch\" stopped working\n> for me, just producing the same output as \"git diff\", but not prompting to stage\n> anything.\n> \n> I found that unsetting the config key color.ui, which was set to \"always\" fixed\n> the problem.\n> \n> From the manpage, color.ui should not have that effect and \"always\" should be a\n> legal value.\n> \n> Regards\n> Alexander Gehrke\n\nHello Alexander,\n\nThere have been a few mailing-list posts[0] about this already. While\ngit add -p should probably not have broken by this, setting ui.color to\nalways itself does not make a lot of sense either.\n\nYou are telling git to always output color, even when the target is\nsomething that does not know what to do with the color codes. Setting it\nto 'auto' would make more sense.\n\nThe thread I posted to discusses some changes that might get introduced\nto improve the situation though.\n\nKevin.\n\n[0}:https://public-inbox.org/git/20171003093157.gq7za2fwcqsouire@sigill.intra.peff.net/T/\n"}]}