{"thread":{"id":"46896","subject":"[PATCH] test-list-objects: mark file-local symbols as static","startedAt":"2017-10-03T21:51:14Z","lastAt":"2017-10-04T13:40:21Z","messageCount":2,"participants":["Ramsay Jones","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"329611","messageId":"5b3d8899-d4c5-c145-7128-21c8aaa4f38f@ramsayjones.plus.com","threadId":"46896","inReplyTo":null,"subject":"[PATCH] test-list-objects: mark file-local symbols as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-10-03T21:51:03Z","receivedAt":"2017-10-03T21:51:14Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones \n---\n\nHi Derrick,\n\nIf you need to re-roll your 'ds/find-unique-abbrev-optim' branch,\ncould you please squash this into the relevant patch (commit 3792c78ba0,\n\"test-list-objects: list a subset of object ids\", 01-10-2017).\n\nThanks!\n\nATB,\nRamsay Jones\n\n t/helper/test-list-objects.c | 32 ++++++++++++++++----------------\n 1 file changed, 16 insertions(+), 16 deletions(-)\n\ndiff --git a/t/helper/test-list-objects.c b/t/helper/test-list-objects.c\nindex 22bc9b4e6..5c5d3c03f 100644\n--- a/t/helper/test-list-objects.c\n+++ b/t/helper/test-list-objects.c\n@@ -6,43 +6,43 @@ struct count {\n \tint select_mod;\n };\n \n-int count_loose(const struct object_id *oid,\n-\t\tconst char *path,\n-\t\tvoid *data)\n+static int count_loose(const struct object_id *oid,\n+\t\t const char *path,\n+\t\t void *data)\n {\n \t((struct count*)data)->total++;\n \treturn 0;\n }\n \n-int count_packed(const struct object_id *oid,\n-\t\t struct packed_git *pack,\n-\t\t uint32_t pos,\n-\t\t void* data)\n+static int count_packed(const struct object_id *oid,\n+\t\t\tstruct packed_git *pack,\n+\t\t\tuint32_t pos,\n+\t\t\tvoid* data)\n {\n \t((struct count*)data)->total++;\n \treturn 0;\n }\n \n-void output(const struct object_id *oid,\n-\t struct count *c)\n+static void output(const struct object_id *oid,\n+\t\t struct count *c)\n {\n \tif (!(c->total % c->select_mod))\n \t\tprintf(\"%s\\n\", oid_to_hex(oid));\n \tc->total--;\n }\n \n-int output_loose(const struct object_id *oid,\n-\t\t const char *path,\n-\t\t void *data)\n+static int output_loose(const struct object_id *oid,\n+\t\t\tconst char *path,\n+\t\t\tvoid *data)\n {\n \toutput(oid, (struct count*)data);\n \treturn 0;\n }\n \n-int output_packed(const struct object_id *oid,\n-\t\t struct packed_git *pack,\n-\t\t uint32_t pos,\n-\t\t void* data)\n+static int output_packed(const struct object_id *oid,\n+\t\t\t struct packed_git *pack,\n+\t\t\t uint32_t pos,\n+\t\t\t void* data)\n {\n \toutput(oid, (struct count*)data);\n \treturn 0;\n-- \n2.14.0\n"},{"id":"329687","messageId":"de2c43ca-2b5c-62e5-80a7-a8513a946558@gmail.com","threadId":"46896","inReplyTo":"5b3d8899-d4c5-c145-7128-21c8aaa4f38f@ramsayjones.plus.com","subject":"Re: [PATCH] test-list-objects: mark file-local symbols as static","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2017-10-04T13:40:15Z","receivedAt":"2017-10-04T13:40:21Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 10/3/2017 5:51 PM, Ramsay Jones wrote:\n> Signed-off-by: Ramsay Jones \n> ---\n>\n> Hi Derrick,\n>\n> If you need to re-roll your 'ds/find-unique-abbrev-optim' branch,\n> could you please squash this into the relevant patch (commit 3792c78ba0,\n> \"test-list-objects: list a subset of object ids\", 01-10-2017).\n>\n> Thanks!\n>\n> ATB,\n> Ramsay Jones\n>\n> t/helper/test-list-objects.c | 32 ++++++++++++++++----------------\n> 1 file changed, 16 insertions(+), 16 deletions(-)\n>\n> diff --git a/t/helper/test-list-objects.c b/t/helper/test-list-objects.c\n> index 22bc9b4e6..5c5d3c03f 100644\n> --- a/t/helper/test-list-objects.c\n> +++ b/t/helper/test-list-objects.c\n> @@ -6,43 +6,43 @@ struct count {\n> \tint select_mod;\n> };\n> \n> -int count_loose(const struct object_id *oid,\n> -\t\tconst char *path,\n> -\t\tvoid *data)\n> +static int count_loose(const struct object_id *oid,\n> +\t\t const char *path,\n> +\t\t void *data)\n> {\n> \t((struct count*)data)->total++;\n> \treturn 0;\n> }\n> \n> -int count_packed(const struct object_id *oid,\n> -\t\t struct packed_git *pack,\n> -\t\t uint32_t pos,\n> -\t\t void* data)\n> +static int count_packed(const struct object_id *oid,\n> +\t\t\tstruct packed_git *pack,\n> +\t\t\tuint32_t pos,\n> +\t\t\tvoid* data)\n> {\n> \t((struct count*)data)->total++;\n> \treturn 0;\n> }\n> \n> -void output(const struct object_id *oid,\n> -\t struct count *c)\n> +static void output(const struct object_id *oid,\n> +\t\t struct count *c)\n> {\n> \tif (!(c->total % c->select_mod))\n> \t\tprintf(\"%s\\n\", oid_to_hex(oid));\n> \tc->total--;\n> }\n> \n> -int output_loose(const struct object_id *oid,\n> -\t\t const char *path,\n> -\t\t void *data)\n> +static int output_loose(const struct object_id *oid,\n> +\t\t\tconst char *path,\n> +\t\t\tvoid *data)\n> {\n> \toutput(oid, (struct count*)data);\n> \treturn 0;\n> }\n> \n> -int output_packed(const struct object_id *oid,\n> -\t\t struct packed_git *pack,\n> -\t\t uint32_t pos,\n> -\t\t void* data)\n> +static int output_packed(const struct object_id *oid,\n> +\t\t\t struct packed_git *pack,\n> +\t\t\t uint32_t pos,\n> +\t\t\t void* data)\n> {\n> \toutput(oid, (struct count*)data);\n> \treturn 0;\nThanks, Ramsay. I applied these changes locally. I'll remember \"static\" \nin the future.\n\nThanks,\n-Stolee\n"}]}