{"thread":{"id":"46773","subject":"[PATCH] protocol: make parse_protocol_version() private","startedAt":"2017-09-17T16:53:54Z","lastAt":"2017-09-18T16:38:18Z","messageCount":2,"participants":["Ramsay Jones","Brandon Williams"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"328266","messageId":"1cb7d40d-3f11-71a0-6e53-dced7810a0ca@ramsayjones.plus.com","threadId":"46773","inReplyTo":null,"subject":"[PATCH] protocol: make parse_protocol_version() private","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-09-17T16:53:47Z","receivedAt":"2017-09-17T16:53:54Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Brandon,\n\nIf you need to re-roll your 'bw/protocol-v1' branch, could you please\nsquash this into the relevant patch (commit 45954f179e, \"protocol:\nintroduce protocol extention mechanisms\", 13-09-2017).\n\nThis assumes you agree that this symbol does not need to be public; if\nnot, then please just ignore! ;-)\n\nThanks!\n\nATB,\nRamsay Jones\n\n protocol.c | 2 +-\n protocol.h | 1 -\n 2 files changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/protocol.c b/protocol.c\nindex 1b16c7b9a..369503065 100644\n--- a/protocol.c\n+++ b/protocol.c\n@@ -2,7 +2,7 @@\n #include \"config.h\"\n #include \"protocol.h\"\n \n-enum protocol_version parse_protocol_version(const char *value)\n+static enum protocol_version parse_protocol_version(const char *value)\n {\n \tif (!strcmp(value, \"0\"))\n \t\treturn protocol_v0;\ndiff --git a/protocol.h b/protocol.h\nindex 2fa6486d0..18f9a5235 100644\n--- a/protocol.h\n+++ b/protocol.h\n@@ -7,7 +7,6 @@ enum protocol_version {\n \tprotocol_v1 = 1,\n };\n \n-extern enum protocol_version parse_protocol_version(const char *value);\n extern enum protocol_version get_protocol_version_config(void);\n extern enum protocol_version determine_protocol_version_server(void);\n extern enum protocol_version determine_protocol_version_client(const char *server_response);\n-- \n2.14.0\n"},{"id":"328303","messageId":"20170918163810.GA144331@google.com","threadId":"46773","inReplyTo":"1cb7d40d-3f11-71a0-6e53-dced7810a0ca@ramsayjones.plus.com","subject":"Re: [PATCH] protocol: make parse_protocol_version() private","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2017-09-18T16:38:10Z","receivedAt":"2017-09-18T16:38:18Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On 09/17, Ramsay Jones wrote:\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi Brandon,\n> \n> If you need to re-roll your 'bw/protocol-v1' branch, could you please\n> squash this into the relevant patch (commit 45954f179e, \"protocol:\n> introduce protocol extention mechanisms\", 13-09-2017).\n> \n> This assumes you agree that this symbol does not need to be public; if\n> not, then please just ignore! ;-)\n\nThanks!  I've updated my local version of the series to reflect this.\n\n> \n> Thanks!\n> \n> ATB,\n> Ramsay Jones\n> \n>  protocol.c | 2 +-\n>  protocol.h | 1 -\n>  2 files changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/protocol.c b/protocol.c\n> index 1b16c7b9a..369503065 100644\n> --- a/protocol.c\n> +++ b/protocol.c\n> @@ -2,7 +2,7 @@\n>  #include \"config.h\"\n>  #include \"protocol.h\"\n>  \n> -enum protocol_version parse_protocol_version(const char *value)\n> +static enum protocol_version parse_protocol_version(const char *value)\n>  {\n>  \tif (!strcmp(value, \"0\"))\n>  \t\treturn protocol_v0;\n> diff --git a/protocol.h b/protocol.h\n> index 2fa6486d0..18f9a5235 100644\n> --- a/protocol.h\n> +++ b/protocol.h\n> @@ -7,7 +7,6 @@ enum protocol_version {\n>  \tprotocol_v1 = 1,\n>  };\n>  \n> -extern enum protocol_version parse_protocol_version(const char *value);\n>  extern enum protocol_version get_protocol_version_config(void);\n>  extern enum protocol_version determine_protocol_version_server(void);\n>  extern enum protocol_version determine_protocol_version_client(const char *server_response);\n> -- \n> 2.14.0\n\n-- \nBrandon Williams\n"}]}