{"thread":{"id":"46772","subject":"[PATCH] test-drop-caches: mark file local symbols with static","startedAt":"2017-09-17T16:14:57Z","lastAt":"2017-09-18T12:32:52Z","messageCount":2,"participants":["Ramsay Jones","Ben Peart"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"328265","messageId":"762d317b-8174-1809-a077-38b036850d3f@ramsayjones.plus.com","threadId":"46772","inReplyTo":null,"subject":"[PATCH] test-drop-caches: mark file local symbols with static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-09-17T16:14:47Z","receivedAt":"2017-09-17T16:14:57Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Ben,\n\nIf you need to re-roll your 'bp/fsmonitor' branch, could you please\nsquash this into the relevant patch (commit c6b5a28941, \"fsmonitor:\nadd a performance test\", 15-09-2017).\n\nThanks!\n\nATB,\nRamsay Jones\n\n t/helper/test-drop-caches.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)\n\ndiff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c\nindex 717079865..17590170f 100644\n--- a/t/helper/test-drop-caches.c\n+++ b/t/helper/test-drop-caches.c\n@@ -2,7 +2,7 @@\n \n #if defined(GIT_WINDOWS_NATIVE)\n \n-int cmd_sync(void)\n+static int cmd_sync(void)\n {\n \tchar Buffer[MAX_PATH];\n \tDWORD dwRet;\n@@ -49,7 +49,7 @@ typedef enum _SYSTEM_MEMORY_LIST_COMMAND {\n \tMemoryCommandMax\n } SYSTEM_MEMORY_LIST_COMMAND;\n \n-BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)\n+static BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)\n {\n \tBOOL bResult;\n \tDWORD dwBufferLength;\n@@ -77,7 +77,7 @@ BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)\n \treturn bResult;\n }\n \n-int cmd_dropcaches(void)\n+static int cmd_dropcaches(void)\n {\n \tHANDLE hProcess = GetCurrentProcess();\n \tHANDLE hToken;\n@@ -118,36 +118,36 @@ int cmd_dropcaches(void)\n \n #elif defined(__linux__)\n \n-int cmd_sync(void)\n+static int cmd_sync(void)\n {\n \treturn system(\"sync\");\n }\n \n-int cmd_dropcaches(void)\n+static int cmd_dropcaches(void)\n {\n \treturn system(\"echo 3 | sudo tee /proc/sys/vm/drop_caches\");\n }\n \n #elif defined(__APPLE__)\n \n-int cmd_sync(void)\n+static int cmd_sync(void)\n {\n \treturn system(\"sync\");\n }\n \n-int cmd_dropcaches(void)\n+static int cmd_dropcaches(void)\n {\n \treturn system(\"sudo purge\");\n }\n \n #else\n \n-int cmd_sync(void)\n+static int cmd_sync(void)\n {\n \treturn 0;\n }\n \n-int cmd_dropcaches(void)\n+static int cmd_dropcaches(void)\n {\n \treturn error(\"drop caches not implemented on this platform\");\n }\n-- \n2.14.0\n"},{"id":"328285","messageId":"756cf0ba-aad8-3fdb-298a-f174394e5895@gmail.com","threadId":"46772","inReplyTo":"762d317b-8174-1809-a077-38b036850d3f@ramsayjones.plus.com","subject":"Re: [PATCH] test-drop-caches: mark file local symbols with static","fromName":"Ben Peart","fromEmail":"peartben@gmail.com","sentAt":"2017-09-18T12:32:43Z","receivedAt":"2017-09-18T12:32:52Z","isPatch":true,"sender":{"key":"benpeart@microsoft.com","avatar":"https://avatars.githubusercontent.com/u/15252029?v=4"},"body":"\n\nOn 9/17/2017 12:14 PM, Ramsay Jones wrote:\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi Ben,\n> \n> If you need to re-roll your 'bp/fsmonitor' branch, could you please\n> squash this into the relevant patch (commit c6b5a28941, \"fsmonitor:\n> add a performance test\", 15-09-2017).\n\nAbsolutely.  Thanks!\n\nI'd really appreciate some feedback on whether this works properly on \nplatform other than Windows.\n\n> \n> Thanks!\n> \n> ATB,\n> Ramsay Jones\n> \n>   t/helper/test-drop-caches.c | 18 +++++++++---------\n>   1 file changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c\n> index 717079865..17590170f 100644\n> --- a/t/helper/test-drop-caches.c\n> +++ b/t/helper/test-drop-caches.c\n> @@ -2,7 +2,7 @@\n>   \n>   #if defined(GIT_WINDOWS_NATIVE)\n>   \n> -int cmd_sync(void)\n> +static int cmd_sync(void)\n>   {\n>   \tchar Buffer[MAX_PATH];\n>   \tDWORD dwRet;\n> @@ -49,7 +49,7 @@ typedef enum _SYSTEM_MEMORY_LIST_COMMAND {\n>   \tMemoryCommandMax\n>   } SYSTEM_MEMORY_LIST_COMMAND;\n>   \n> -BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)\n> +static BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)\n>   {\n>   \tBOOL bResult;\n>   \tDWORD dwBufferLength;\n> @@ -77,7 +77,7 @@ BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)\n>   \treturn bResult;\n>   }\n>   \n> -int cmd_dropcaches(void)\n> +static int cmd_dropcaches(void)\n>   {\n>   \tHANDLE hProcess = GetCurrentProcess();\n>   \tHANDLE hToken;\n> @@ -118,36 +118,36 @@ int cmd_dropcaches(void)\n>   \n>   #elif defined(__linux__)\n>   \n> -int cmd_sync(void)\n> +static int cmd_sync(void)\n>   {\n>   \treturn system(\"sync\");\n>   }\n>   \n> -int cmd_dropcaches(void)\n> +static int cmd_dropcaches(void)\n>   {\n>   \treturn system(\"echo 3 | sudo tee /proc/sys/vm/drop_caches\");\n>   }\n>   \n>   #elif defined(__APPLE__)\n>   \n> -int cmd_sync(void)\n> +static int cmd_sync(void)\n>   {\n>   \treturn system(\"sync\");\n>   }\n>   \n> -int cmd_dropcaches(void)\n> +static int cmd_dropcaches(void)\n>   {\n>   \treturn system(\"sudo purge\");\n>   }\n>   \n>   #else\n>   \n> -int cmd_sync(void)\n> +static int cmd_sync(void)\n>   {\n>   \treturn 0;\n>   }\n>   \n> -int cmd_dropcaches(void)\n> +static int cmd_dropcaches(void)\n>   {\n>   \treturn error(\"drop caches not implemented on this platform\");\n>   }\n> \n"}]}