{"thread":{"id":"46706","subject":"[PATCH] config: remove git_config_maybe_bool","startedAt":"2017-09-05T18:40:26Z","lastAt":"2017-09-07T00:49:03Z","messageCount":2,"participants":["Martin Ågren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"327597","messageId":"20170905183959.22454-1-martin.agren@gmail.com","threadId":"46706","inReplyTo":null,"subject":"[PATCH] config: remove git_config_maybe_bool","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2017-09-05T18:39:59Z","receivedAt":"2017-09-05T18:40:26Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"The function was deprecated in commit 89576613 (\"treewide: deprecate\ngit_config_maybe_bool, use git_parse_maybe_bool\", 2017-08-07) and has no\nusers.\n\nSigned-off-by: Martin Ågren <martin.agren@gmail.com>\n---\nma/parse-maybe-bool has been in master for some time and I cannot find\nany inflight topics which rely on git_config_maybe_bool (neither in pu,\nnor on the list). Indeed, it would have been easier to kill this\nfunction immediately instead of deprecating it.\n\n Documentation/technical/api-config.txt | 4 ----\n config.h                               | 1 -\n config.c                               | 5 -----\n 3 files changed, 10 deletions(-)\n\ndiff --git a/Documentation/technical/api-config.txt b/Documentation/technical/api-config.txt\nindex 7a83a3a6e..9a778b0ca 100644\n--- a/Documentation/technical/api-config.txt\n+++ b/Documentation/technical/api-config.txt\n@@ -186,10 +186,6 @@ parsing is successful, the return value is the result.\n Same as `git_config_bool`, except that integers are returned as-is, and\n an `is_bool` flag is unset.\n \n-`git_config_maybe_bool`::\n-Deprecated. Use `git_parse_maybe_bool` instead. They are exactly the\n-same, except this function takes an unused argument `name`.\n-\n `git_parse_maybe_bool`::\n Same as `git_config_bool`, except that it returns -1 on error rather\n than dying.\ndiff --git a/config.h b/config.h\nindex 97471b887..456b3d134 100644\n--- a/config.h\n+++ b/config.h\n@@ -56,7 +56,6 @@ extern unsigned long git_config_ulong(const char *, const char *);\n extern ssize_t git_config_ssize_t(const char *, const char *);\n extern int git_config_bool_or_int(const char *, const char *, int *);\n extern int git_config_bool(const char *, const char *);\n-extern int git_config_maybe_bool(const char *, const char *);\n extern int git_config_string(const char **, const char *, const char *);\n extern int git_config_pathname(const char **, const char *, const char *);\n extern int git_config_set_in_file_gently(const char *, const char *, const char *);\ndiff --git a/config.c b/config.c\nindex d0d8ce823..f627657cf 100644\n--- a/config.c\n+++ b/config.c\n@@ -956,11 +956,6 @@ int git_parse_maybe_bool(const char *value)\n \treturn -1;\n }\n \n-int git_config_maybe_bool(const char *name, const char *value)\n-{\n-\treturn git_parse_maybe_bool(value);\n-}\n-\n int git_config_bool_or_int(const char *name, const char *value, int *is_bool)\n {\n \tint v = git_parse_maybe_bool_text(value);\n-- \n2.14.1.460.g848a19d64\n\n"},{"id":"327683","messageId":"xmqqfubz2v0o.fsf@gitster.mtv.corp.google.com","threadId":"46706","inReplyTo":"20170905183959.22454-1-martin.agren@gmail.com","subject":"Re: [PATCH] config: remove git_config_maybe_bool","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-09-07T00:48:55Z","receivedAt":"2017-09-07T00:49:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Ågren <martin.agren@gmail.com> writes:\n\n> The function was deprecated in commit 89576613 (\"treewide: deprecate\n> git_config_maybe_bool, use git_parse_maybe_bool\", 2017-08-07) and has no\n> users.\n>\n> Signed-off-by: Martin Ågren <martin.agren@gmail.com>\n> ---\n\nThanks.  Will queue.\n"}]}