{"thread":{"id":"46678","subject":"[PATCH] Add t/helper/test-write-cache to .gitignore","startedAt":"2017-08-28T20:06:30Z","lastAt":"2017-09-20T18:48:01Z","messageCount":3,"participants":["Jonathan Tan","Brandon Williams","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"327288","messageId":"20170828200618.27569-1-jonathantanmy@google.com","threadId":"46678","inReplyTo":null,"subject":"[PATCH] Add t/helper/test-write-cache to .gitignore","fromName":"Jonathan Tan","fromEmail":"jonathantanmy@google.com","sentAt":"2017-08-28T20:06:18Z","receivedAt":"2017-08-28T20:06:30Z","isPatch":true,"sender":{"key":"jonathantanmy@fastmail.com","avatar":null},"body":"This new binary was introduced in commit 3921a0b (\"perf: add test for\nwriting the index\", 2017-08-21), but a .gitignore entry was not added\nfor it. Add that entry.\n\nSigned-off-by: Jonathan Tan <jonathantanmy@google.com>\n---\n t/helper/.gitignore | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/t/helper/.gitignore b/t/helper/.gitignore\nindex 721650256..7c9d28a83 100644\n--- a/t/helper/.gitignore\n+++ b/t/helper/.gitignore\n@@ -35,3 +35,4 @@\n /test-svn-fe\n /test-urlmatch-normalization\n /test-wildmatch\n+/test-write-cache\n-- \n2.14.1.581.gf28d330327-goog\n\n"},{"id":"327296","messageId":"20170828210939.GA71562@google.com","threadId":"46678","inReplyTo":"20170828200618.27569-1-jonathantanmy@google.com","subject":"Re: [PATCH] Add t/helper/test-write-cache to .gitignore","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2017-08-28T21:09:39Z","receivedAt":"2017-08-28T21:09:46Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On 08/28, Jonathan Tan wrote:\n> This new binary was introduced in commit 3921a0b (\"perf: add test for\n> writing the index\", 2017-08-21), but a .gitignore entry was not added\n> for it. Add that entry.\n> \n> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>\n\nLooks good to me\n\n> ---\n>  t/helper/.gitignore | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/t/helper/.gitignore b/t/helper/.gitignore\n> index 721650256..7c9d28a83 100644\n> --- a/t/helper/.gitignore\n> +++ b/t/helper/.gitignore\n> @@ -35,3 +35,4 @@\n>  /test-svn-fe\n>  /test-urlmatch-normalization\n>  /test-wildmatch\n> +/test-write-cache\n> -- \n> 2.14.1.581.gf28d330327-goog\n> \n\n-- \nBrandon Williams\n"},{"id":"328481","messageId":"20170920184753.GC27425@aiede.mtv.corp.google.com","threadId":"46678","inReplyTo":"20170828210939.GA71562@google.com","subject":"Re: [PATCH] Add t/helper/test-write-cache to .gitignore","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-09-20T18:47:53Z","receivedAt":"2017-09-20T18:48:01Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Brandon Williams wrote:\n> On 08/28, Jonathan Tan wrote:\n\n>> This new binary was introduced in commit 3921a0b (\"perf: add test for\n>> writing the index\", 2017-08-21), but a .gitignore entry was not added\n>> for it. Add that entry.\n>>\n>> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>\n>\n> Looks good to me\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nas well.\n\nI wonder if we can automate this a little.  Some thoughts:\n\n A. We could include a test that all the binaries named in\n    TEST_PROGRAMS_NEED_X are also named in t/helper/.gitignore.  That\n    way tests would fail if this ever falls out of date again.\n\n B. Even better would be if we could have /t/helper/test-* in\n    .gitignore.  E.g. if we rename test-*.c to *.c (e.g.\n    t/helper/ctype.c instead of t/helper/test-ctype.c), then the test\n    helper source file names would be easier to type and maintaining\n    this .gitignore would become a problem of the past.\n\nWhat do you think?\nJonathan\n"}]}