{"thread":{"id":"46665","subject":"[PATCH] sha1-lookup: remove sha1_entry_pos() from header file","startedAt":"2017-08-25T07:36:34Z","lastAt":"2017-08-25T14:03:35Z","messageCount":2,"participants":["Christian Couder","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"327173","messageId":"20170825073613.13853-1-chriscool@tuxfamily.org","threadId":"46665","inReplyTo":null,"subject":"[PATCH] sha1-lookup: remove sha1_entry_pos() from header file","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2017-08-25T07:36:13Z","receivedAt":"2017-08-25T07:36:34Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Since f1068efefe (sha1_file: drop experimental GIT_USE_LOOKUP search, 2017-08-09)\nthe definition of sha1_entry_pos() has been removed from \"sha1-lookup.c\", so\nthere is no need anymore for its declaration in \"sha1-lookup.h\".\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n sha1-lookup.h | 6 ------\n 1 file changed, 6 deletions(-)\n\ndiff --git a/sha1-lookup.h b/sha1-lookup.h\nindex 20af285681..cf5314f402 100644\n--- a/sha1-lookup.h\n+++ b/sha1-lookup.h\n@@ -7,10 +7,4 @@ extern int sha1_pos(const unsigned char *sha1,\n \t\t    void *table,\n \t\t    size_t nr,\n \t\t    sha1_access_fn fn);\n-\n-extern int sha1_entry_pos(const void *table,\n-\t\t\t  size_t elem_size,\n-\t\t\t  size_t key_offset,\n-\t\t\t  unsigned lo, unsigned hi, unsigned nr,\n-\t\t\t  const unsigned char *key);\n #endif\n-- \n2.14.1.326.g3dc57ebfbd.dirty\n\n"},{"id":"327185","messageId":"20170825140326.lkjqkdevaaelwyyg@sigill.intra.peff.net","threadId":"46665","inReplyTo":"20170825073613.13853-1-chriscool@tuxfamily.org","subject":"Re: [PATCH] sha1-lookup: remove sha1_entry_pos() from header file","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-08-25T14:03:27Z","receivedAt":"2017-08-25T14:03:35Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Aug 25, 2017 at 09:36:13AM +0200, Christian Couder wrote:\n\n> Since f1068efefe (sha1_file: drop experimental GIT_USE_LOOKUP search, 2017-08-09)\n> the definition of sha1_entry_pos() has been removed from \"sha1-lookup.c\", so\n> there is no need anymore for its declaration in \"sha1-lookup.h\".\n\nDoh, thanks for catching.\n\nPatch is obviously good.\n\n-Peff\n"}]}