{"thread":{"id":"46652","subject":"[PATCH] vcs-svn/repo_tree.h: remove repo_init declaration","startedAt":"2017-08-22T21:35:09Z","lastAt":"2017-08-23T01:10:16Z","messageCount":6,"participants":["Stefan Beller","Junio C Hamano","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"326971","messageId":"20170822213501.5928-1-sbeller@google.com","threadId":"46652","inReplyTo":null,"subject":"[PATCH] vcs-svn/repo_tree.h: remove repo_init declaration","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-08-22T21:35:01Z","receivedAt":"2017-08-22T21:35:09Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"The svn specific declaration of repo_init was not used since 723b7a2789\n(vcs-svn: eliminate repo_tree structure, 2010-12-10).\n\nThis was noticed when including repository.h via cache.h as that has the\nsame function with a different signature.\n\nHelped-by: Jonathan Nieder \nSigned-off-by: Stefan Beller \n---\n vcs-svn/repo_tree.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/vcs-svn/repo_tree.h b/vcs-svn/repo_tree.h\nindex 889c6a3c95..8592beb59b 100644\n--- a/vcs-svn/repo_tree.h\n+++ b/vcs-svn/repo_tree.h\n@@ -17,7 +17,6 @@ void repo_commit(uint32_t revision, const char *author,\n \t\tconst struct strbuf *log, const char *uuid, const char *url,\n \t\tlong unsigned timestamp);\n void repo_diff(uint32_t r1, uint32_t r2);\n-void repo_init(void);\n void repo_reset(void);\n \n #endif\n-- \n2.14.0.rc0.3.g6c2e499285\n\n"},{"id":"326983","messageId":"xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com","threadId":"46652","inReplyTo":"20170822213501.5928-1-sbeller@google.com","subject":"Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-08-22T22:18:25Z","receivedAt":"2017-08-22T22:18:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller writes:\n\n\n> The svn specific declaration of repo_init was not used since 723b7a2789\n> (vcs-svn: eliminate repo_tree structure, 2010-12-10).\n>\n> This was noticed when including repository.h via cache.h as that has the\n> same function with a different signature.\n>\n> Helped-by: Jonathan Nieder \n> Signed-off-by: Stefan Beller \n> ---\n\nIt looks to me that this is a reduced duplicate of what brian posted\nyesterday. The first two patches in the 6-patch series that you\ncommented on, I think, covers what this change wants to achieve and\nprobably a lot more. I've merged those two already to 'next' and\nwas about to push the result out.\n\nThanks.\n\n\n> vcs-svn/repo_tree.h | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/vcs-svn/repo_tree.h b/vcs-svn/repo_tree.h\n> index 889c6a3c95..8592beb59b 100644\n> --- a/vcs-svn/repo_tree.h\n> +++ b/vcs-svn/repo_tree.h\n> @@ -17,7 +17,6 @@ void repo_commit(uint32_t revision, const char *author,\n> \t\tconst struct strbuf *log, const char *uuid, const char *url,\n> \t\tlong unsigned timestamp);\n> void repo_diff(uint32_t r1, uint32_t r2);\n> -void repo_init(void);\n> void repo_reset(void);\n> \n> #endif\n"},{"id":"326984","messageId":"CAGZ79kbMc+kVsc2-fBfOHVZvvABWnDpQfs-hqLCxb2FTTr8YCQ@mail.gmail.com","threadId":"46652","inReplyTo":"xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-08-22T22:24:19Z","receivedAt":"2017-08-22T22:24:27Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Aug 22, 2017 at 3:18 PM, Junio C Hamano wrote:\n> Stefan Beller writes:\n>\n>\n>> The svn specific declaration of repo_init was not used since 723b7a2789\n>> (vcs-svn: eliminate repo_tree structure, 2010-12-10).\n>>\n>> This was noticed when including repository.h via cache.h as that has the\n>> same function with a different signature.\n>>\n>> Helped-by: Jonathan Nieder \n>> Signed-off-by: Stefan Beller \n>> ---\n>\n> It looks to me that this is a reduced duplicate of what brian posted\n> yesterday. The first two patches in the 6-patch series that you\n> commented on, I think, covers what this change wants to achieve and\n> probably a lot more. I've merged those two already to 'next' and\n> was about to push the result out.\n>\n> Thanks.\n>\n\nOk, thanks. I did not remember reviewing those.\n(I just wanted to fix my odd compile error here,\nand currently I build a series on top of jt/packmigrate\nso I shot off a quick one liner)\n\nSorry for the noise.\n"},{"id":"326988","messageId":"20170822225405.GV13924@aiede.mtv.corp.google.com","threadId":"46652","inReplyTo":"xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-08-22T22:54:05Z","receivedAt":"2017-08-22T22:54:14Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n> Stefan Beller writes:\n\n>> The svn specific declaration of repo_init was not used since 723b7a2789\n>> (vcs-svn: eliminate repo_tree structure, 2010-12-10).\n>>\n>> This was noticed when including repository.h via cache.h as that has the\n>> same function with a different signature.\n>>\n>> Helped-by: Jonathan Nieder \n>> Signed-off-by: Stefan Beller \n>\n> It looks to me that this is a reduced duplicate of what brian posted\n> yesterday. The first two patches in the 6-patch series that you\n> commented on, I think, covers what this change wants to achieve and\n> probably a lot more. I've merged those two already to 'next' and\n> was about to push the result out.\n\nThanks for the pointer. I believe you're referring to\nhttps://public-inbox.org/git/20170821000022.26729-2-sandals@crustytoothpaste.net/.\n\nFrom Stefan's verbal report I was about to send a patch just like\nBrian's plus some more patches on top to get rid of the rest of repo_tree.h.\nI can build on top of Brian's patch if that's more convenient.\n\nRegards,\nJonathan\n"},{"id":"327000","messageId":"20170822234553.GC13924@aiede.mtv.corp.google.com","threadId":"46652","inReplyTo":"xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-08-22T23:45:53Z","receivedAt":"2017-08-22T23:46:00Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n> Stefan Beller writes:\n\n>> The svn specific declaration of repo_init was not used since 723b7a2789\n>> (vcs-svn: eliminate repo_tree structure, 2010-12-10).\n>>\n>> This was noticed when including repository.h via cache.h as that has the\n>> same function with a different signature.\n>>\n>> Helped-by: Jonathan Nieder \n>> Signed-off-by: Stefan Beller \n>> ---\n>\n> It looks to me that this is a reduced duplicate of what brian posted\n> yesterday. The first two patches in the 6-patch series that you\n> commented on, I think, covers what this change wants to achieve and\n> probably a lot more. I've merged those two already to 'next' and\n> was about to push the result out.\n\nI just sent\nhttps://public-inbox.org/git/20170822233732.GX13924@aiede.mtv.corp.google.com/\nto fix this more thoroughly. I can rebase on top of bc/vcs-svn-cleanup\nif that is helpful --- just say the word.\n\nThanks,\nJonathan\n"},{"id":"327008","messageId":"xmqqa82r1441.fsf@gitster.mtv.corp.google.com","threadId":"46652","inReplyTo":"20170822234553.GC13924@aiede.mtv.corp.google.com","subject":"Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-08-23T01:10:06Z","receivedAt":"2017-08-23T01:10:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder writes:\n\n> Junio C Hamano wrote:\n> ...\n>> It looks to me that this is a reduced duplicate of what brian posted\n>> yesterday. The first two patches in the 6-patch series that you\n>> commented on, I think, covers what this change wants to achieve and\n>> probably a lot more. I've merged those two already to 'next' and\n>> was about to push the result out.\n>\n> I just sent\n> https://public-inbox.org/git/20170822233732.GX13924@aiede.mtv.corp.google.com/\n> to fix this more thoroughly. I can rebase on top of bc/vcs-svn-cleanup\n> if that is helpful --- just say the word.\n\nYup, as I merged those two preliminary clean-up separately to 'next'\nalready, it would be more efficient to build on top. I do not know\nwhat you are planning with the other patches (I only saw Stefan's\none, not your series) so do not yet have suggestion on how to work\nwell with Brian's series that builds on his two clean-up patches.\nHopefully they are orthogonal?\n\nThanks.\n"}]}