{"thread":{"id":"46613","subject":"[PATCH] t5526: fix some broken && chains","startedAt":"2017-08-17T10:36:23Z","lastAt":"2017-08-17T17:44:07Z","messageCount":2,"participants":["Heiko Voigt","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"326597","messageId":"20170817103613.GB52233@book.hvoigt.net","threadId":"46613","inReplyTo":null,"subject":"[PATCH] t5526: fix some broken && chains","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2017-08-17T10:36:13Z","receivedAt":"2017-08-17T10:36:23Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>\n---\n t/t5526-fetch-submodules.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh\nindex ce788e9..22a7358 100755\n--- a/t/t5526-fetch-submodules.sh\n+++ b/t/t5526-fetch-submodules.sh\n@@ -193,7 +193,7 @@ test_expect_success \"recurseSubmodules=true propagates into submodules\" '\n \tadd_upstream_commit &&\n \t(\n \t\tcd downstream &&\n-\t\tgit config fetch.recurseSubmodules true\n+\t\tgit config fetch.recurseSubmodules true &&\n \t\tgit fetch >../actual.out 2>../actual.err\n \t) &&\n \ttest_must_be_empty actual.out &&\n@@ -218,7 +218,7 @@ test_expect_success \"--no-recurse-submodules overrides config setting\" '\n \tadd_upstream_commit &&\n \t(\n \t\tcd downstream &&\n-\t\tgit config fetch.recurseSubmodules true\n+\t\tgit config fetch.recurseSubmodules true &&\n \t\tgit fetch --no-recurse-submodules >../actual.out 2>../actual.err\n \t) &&\n \t! test -s actual.out &&\n@@ -232,7 +232,7 @@ test_expect_success \"Recursion doesn't happen when no new commits are fetched in\n \t\t\tcd submodule &&\n \t\t\tgit config --unset fetch.recurseSubmodules\n \t\t) &&\n-\t\tgit config --unset fetch.recurseSubmodules\n+\t\tgit config --unset fetch.recurseSubmodules &&\n \t\tgit fetch >../actual.out 2>../actual.err\n \t) &&\n \t! test -s actual.out &&\n@@ -312,7 +312,7 @@ test_expect_success \"Recursion picks up all submodules when necessary\" '\n \t\t) &&\n \t\thead1=$(git rev-parse --short HEAD^) &&\n \t\tgit add subdir/deepsubmodule &&\n-\t\tgit commit -m \"new deepsubmodule\"\n+\t\tgit commit -m \"new deepsubmodule\" &&\n \t\thead2=$(git rev-parse --short HEAD) &&\n \t\techo \"Fetching submodule submodule\" > ../expect.err.sub &&\n \t\techo \"From $pwd/submodule\" >> ../expect.err.sub &&\n-- \n2.0.0.274.g6b2cd91\n\n"},{"id":"326615","messageId":"CAGZ79kY2xc+-63m7upVLrEkHLVgL3hGtTKOKnJPjgReCO_Aj2g@mail.gmail.com","threadId":"46613","inReplyTo":"20170817103613.GB52233@book.hvoigt.net","subject":"Re: [PATCH] t5526: fix some broken && chains","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-08-17T17:44:01Z","receivedAt":"2017-08-17T17:44:07Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Thu, Aug 17, 2017 at 3:36 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:\n> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>\n\nReviewed-by: Stefan Beller <sbeller@google.com>\n\nThanks,\nStefan\n\n> ---\n>  t/t5526-fetch-submodules.sh | 8 ++++----\n>  1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh\n> index ce788e9..22a7358 100755\n> --- a/t/t5526-fetch-submodules.sh\n> +++ b/t/t5526-fetch-submodules.sh\n> @@ -193,7 +193,7 @@ test_expect_success \"recurseSubmodules=true propagates into submodules\" '\n>         add_upstream_commit &&\n>         (\n>                 cd downstream &&\n> -               git config fetch.recurseSubmodules true\n> +               git config fetch.recurseSubmodules true &&\n>                 git fetch >../actual.out 2>../actual.err\n>         ) &&\n>         test_must_be_empty actual.out &&\n> @@ -218,7 +218,7 @@ test_expect_success \"--no-recurse-submodules overrides config setting\" '\n>         add_upstream_commit &&\n>         (\n>                 cd downstream &&\n> -               git config fetch.recurseSubmodules true\n> +               git config fetch.recurseSubmodules true &&\n>                 git fetch --no-recurse-submodules >../actual.out 2>../actual.err\n>         ) &&\n>         ! test -s actual.out &&\n> @@ -232,7 +232,7 @@ test_expect_success \"Recursion doesn't happen when no new commits are fetched in\n>                         cd submodule &&\n>                         git config --unset fetch.recurseSubmodules\n>                 ) &&\n> -               git config --unset fetch.recurseSubmodules\n> +               git config --unset fetch.recurseSubmodules &&\n>                 git fetch >../actual.out 2>../actual.err\n>         ) &&\n>         ! test -s actual.out &&\n> @@ -312,7 +312,7 @@ test_expect_success \"Recursion picks up all submodules when necessary\" '\n>                 ) &&\n>                 head1=$(git rev-parse --short HEAD^) &&\n>                 git add subdir/deepsubmodule &&\n> -               git commit -m \"new deepsubmodule\"\n> +               git commit -m \"new deepsubmodule\" &&\n>                 head2=$(git rev-parse --short HEAD) &&\n>                 echo \"Fetching submodule submodule\" > ../expect.err.sub &&\n>                 echo \"From $pwd/submodule\" >> ../expect.err.sub &&\n> --\n> 2.0.0.274.g6b2cd91\n>\n"}]}