{"thread":{"id":"46543","subject":"[PATCH] builtin/add: add a missing newline to an stderr message","startedAt":"2017-08-08T21:36:40Z","lastAt":"2017-08-09T05:38:00Z","messageCount":7,"participants":["Ramsay Jones","René Scharfe","Junio C Hamano","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"325862","messageId":"4b0d092f-5a1b-73c7-38fe-48455099bcff@ramsayjones.plus.com","threadId":"46543","inReplyTo":null,"subject":"[PATCH] builtin/add: add a missing newline to an stderr message","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-08-08T21:36:32Z","receivedAt":"2017-08-08T21:36:40Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones \n---\n\nHi Junio,\n\nI noticed this while looking into the t3700 failure on cygwin tonight.\nAlso, I couldn't decide whether or not to add the i18n '_()' brackets\naround the message. In the end I didn't, but will happily add them\nif you think I should.\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/add.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/add.c b/builtin/add.c\nindex e888fb8c5..385b53ae7 100644\n--- a/builtin/add.c\n+++ b/builtin/add.c\n@@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)\n \t\t\tcontinue;\n \n \t\tif (chmod_cache_entry(ce, force_mode) < 0)\n-\t\t\tfprintf(stderr, \"cannot chmod '%s'\", ce->name);\n+\t\t\tfprintf(stderr, \"cannot chmod '%s'\\n\", ce->name);\n \t}\n }\n \n-- \n2.14.0\n"},{"id":"325863","messageId":"2821200b-0428-a5dd-9680-f291cee0ec47@web.de","threadId":"46543","inReplyTo":"4b0d092f-5a1b-73c7-38fe-48455099bcff@ramsayjones.plus.com","subject":"Re: [PATCH] builtin/add: add a missing newline to an stderr message","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2017-08-08T21:45:11Z","receivedAt":"2017-08-08T21:45:25Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Am 08.08.2017 um 23:36 schrieb Ramsay Jones:\n> \n> Signed-off-by: Ramsay Jones \n> ---\n> \n> Hi Junio,\n> \n> I noticed this while looking into the t3700 failure on cygwin tonight.\n> Also, I couldn't decide whether or not to add the i18n '_()' brackets\n> around the message. In the end I didn't, but will happily add them\n> if you think I should.\n> \n> Thanks!\n> \n> ATB,\n> Ramsay Jones\n> \n> builtin/add.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/builtin/add.c b/builtin/add.c\n> index e888fb8c5..385b53ae7 100644\n> --- a/builtin/add.c\n> +++ b/builtin/add.c\n> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)\n> \t\t\tcontinue;\n> \n> \t\tif (chmod_cache_entry(ce, force_mode) < 0)\n> -\t\t\tfprintf(stderr, \"cannot chmod '%s'\", ce->name);\n> +\t\t\tfprintf(stderr, \"cannot chmod '%s'\\n\", ce->name);\n> \t}\n> }\n> \n\nFYI: I brought this up yesterday in the original thread, along with a\nfew other observations:\n\n https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/\n\nNot sure if the discussion can or should be revived after all this\ntime, though; just sending patches like yours might be the way to go.\n\nRené\n"},{"id":"325867","messageId":"xmqqefslaerf.fsf@gitster.mtv.corp.google.com","threadId":"46543","inReplyTo":"2821200b-0428-a5dd-9680-f291cee0ec47@web.de","subject":"Re: [PATCH] builtin/add: add a missing newline to an stderr message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-08-08T22:14:28Z","receivedAt":"2017-08-08T22:14:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"René Scharfe writes:\n\n>> diff --git a/builtin/add.c b/builtin/add.c\n>> index e888fb8c5..385b53ae7 100644\n>> --- a/builtin/add.c\n>> +++ b/builtin/add.c\n>> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)\n>> \t\t\tcontinue;\n>> \n>> \t\tif (chmod_cache_entry(ce, force_mode) < 0)\n>> -\t\t\tfprintf(stderr, \"cannot chmod '%s'\", ce->name);\n>> +\t\t\tfprintf(stderr, \"cannot chmod '%s'\\n\", ce->name);\n>> \t}\n>> }\n>\n> FYI: I brought this up yesterday in the original thread, along with a\n> few other observations:\n>\n> https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/\n>\n> Not sure if the discussion can or should be revived after all this\n> time, though; just sending patches like yours might be the way to go.\n\nThanks, so it should become\n\n\tfprintf(stderr, \"cannot chmod %c '%s'\\n\", force_mode, ce->name);\n\nin the final version to be queued?\n\n"},{"id":"325872","messageId":"20170808223407.GB169894@aiede.mtv.corp.google.com","threadId":"46543","inReplyTo":"xmqqefslaerf.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] builtin/add: add a missing newline to an stderr message","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-08-08T22:34:07Z","receivedAt":"2017-08-08T22:34:17Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n> René Scharfe writes:\n\n>>> diff --git a/builtin/add.c b/builtin/add.c\n>>> index e888fb8c5..385b53ae7 100644\n>>> --- a/builtin/add.c\n>>> +++ b/builtin/add.c\n>>> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)\n>>> \t\t\tcontinue;\n>>> \n>>> \t\tif (chmod_cache_entry(ce, force_mode) < 0)\n>>> -\t\t\tfprintf(stderr, \"cannot chmod '%s'\", ce->name);\n>>> +\t\t\tfprintf(stderr, \"cannot chmod '%s'\\n\", ce->name);\n>>> \t}\n>>> }\n>>\n>> FYI: I brought this up yesterday in the original thread, along with a\n>> few other observations:\n>>\n>> https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/\n>>\n>> Not sure if the discussion can or should be revived after all this\n>> time, though; just sending patches like yours might be the way to go.\n>\n> Thanks, so it should become\n>\n> \tfprintf(stderr, \"cannot chmod %c '%s'\\n\", force_mode, ce->name);\n>\n> in the final version to be queued?\n\nI don't believe the force_mode without an 'x' provides a clear signal\nto the end user. Perhaps you meant %cx?\n\nThanks,\nJonathan\n"},{"id":"325873","messageId":"20170808223433.GC169894@aiede.mtv.corp.google.com","threadId":"46543","inReplyTo":"4b0d092f-5a1b-73c7-38fe-48455099bcff@ramsayjones.plus.com","subject":"Re: [PATCH] builtin/add: add a missing newline to an stderr message","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-08-08T22:34:33Z","receivedAt":"2017-08-08T22:34:42Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ramsay Jones wrote:\n\n> Signed-off-by: Ramsay Jones \n\nReviewed-by: Jonathan Nieder \n\nThanks for catching it.\n"},{"id":"325882","messageId":"a04808d5-8a53-d9d7-0168-55a9aa79cf7b@ramsayjones.plus.com","threadId":"46543","inReplyTo":"2821200b-0428-a5dd-9680-f291cee0ec47@web.de","subject":"Re: [PATCH] builtin/add: add a missing newline to an stderr message","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-08-08T23:55:09Z","receivedAt":"2017-08-08T23:55:16Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 08/08/17 22:45, René Scharfe wrote:\n> Am 08.08.2017 um 23:36 schrieb Ramsay Jones:\n>>\n>> Signed-off-by: Ramsay Jones \n>> ---\n>>\n>> Hi Junio,\n>>\n>> I noticed this while looking into the t3700 failure on cygwin tonight.\n>> Also, I couldn't decide whether or not to add the i18n '_()' brackets\n>> around the message. In the end I didn't, but will happily add them\n>> if you think I should.\n>>\n>> Thanks!\n>>\n>> ATB,\n>> Ramsay Jones\n>>\n>> builtin/add.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/builtin/add.c b/builtin/add.c\n>> index e888fb8c5..385b53ae7 100644\n>> --- a/builtin/add.c\n>> +++ b/builtin/add.c\n>> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)\n>> \t\t\tcontinue;\n>> \n>> \t\tif (chmod_cache_entry(ce, force_mode) < 0)\n>> -\t\t\tfprintf(stderr, \"cannot chmod '%s'\", ce->name);\n>> +\t\t\tfprintf(stderr, \"cannot chmod '%s'\\n\", ce->name);\n>> \t}\n>> }\n>> \n> \n> FYI: I brought this up yesterday in the original thread, along with a\n> few other observations:\n> \n> https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/\n\nAh, I missed that.\n\nHmm, I just looked at the code in builtin/update-index.c. Yes, it\nwould probably be a good idea to harmonize the messages - but just\nwhere did 'flip' come from? ;-)\n\nATB,\nRamsay Jones\n\n"},{"id":"325917","messageId":"xmqqlgmt8fo3.fsf@gitster.mtv.corp.google.com","threadId":"46543","inReplyTo":"20170808223407.GB169894@aiede.mtv.corp.google.com","subject":"Re: [PATCH] builtin/add: add a missing newline to an stderr message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-08-09T05:37:48Z","receivedAt":"2017-08-09T05:38:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder writes:\n\n> I don't believe the force_mode without an 'x' provides a clear signal\n> to the end user. Perhaps you meant %cx?\n\nIndeed you are right. I think I saw Ramsay's v2 that has the 'x',\nso let's use that version.\n\nThanks.\n"}]}