{"thread":{"id":"46516","subject":"[PATCH] git svn fetch: Create correct commit timestamp when using --localtime","startedAt":"2017-08-05T00:15:10Z","lastAt":"2017-08-08T19:00:15Z","messageCount":5,"participants":["Urs Thuermann","Junio C Hamano","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"325635","messageId":"ygf8tiyx480.fsf@tehran.isnogud.escape.de","threadId":"46516","inReplyTo":null,"subject":"[PATCH] git svn fetch: Create correct commit timestamp when using --localtime","fromName":"Urs Thuermann","fromEmail":"urs@isnogud.escape.de","sentAt":"2017-08-05T00:12:15Z","receivedAt":"2017-08-05T00:15:10Z","isPatch":true,"sender":{"key":"urs@isnogud.escape.de","avatar":"https://avatars.githubusercontent.com/u/11499339?v=4"},"body":"In parse_svn_date() prepend the correct UTC offset to the timestamp\nreturned.  This is the offset in effect at the commit time instead of\nthe offset in effect at calling time.\n\nSigned-off-by: Urs Thuermann <urs@isnogud.escape.de>\n---\n perl/Git/SVN.pm | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm\nindex 98518f4..bc4eed3 100644\n--- a/perl/Git/SVN.pm\n+++ b/perl/Git/SVN.pm\n@@ -1416,7 +1416,7 @@ sub parse_svn_date {\n \t\t\tdelete $ENV{TZ};\n \t\t}\n \n-\t\tmy $our_TZ = get_tz_offset();\n+\t\tmy $our_TZ = get_tz_offset($epoch_in_UTC);\n \n \t\t# This converts $epoch_in_UTC into our local timezone.\n \t\tmy ($sec, $min, $hour, $mday, $mon, $year,\n-- \n2.1.4\n"},{"id":"325768","messageId":"xmqqlgmvni8x.fsf@gitster.mtv.corp.google.com","threadId":"46516","inReplyTo":"ygf8tiyx480.fsf@tehran.isnogud.escape.de","subject":"Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-08-07T22:08:30Z","receivedAt":"2017-08-07T22:08:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Urs Thuermann <urs@isnogud.escape.de> writes:\n\n> In parse_svn_date() prepend the correct UTC offset to the timestamp\n> returned.  This is the offset in effect at the commit time instead of\n> the offset in effect at calling time.\n>\n> Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>\n> ---\n>  perl/Git/SVN.pm | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks; sounds sensible.  \n\nEric?\n\n>\n> diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm\n> index 98518f4..bc4eed3 100644\n> --- a/perl/Git/SVN.pm\n> +++ b/perl/Git/SVN.pm\n> @@ -1416,7 +1416,7 @@ sub parse_svn_date {\n>  \t\t\tdelete $ENV{TZ};\n>  \t\t}\n>  \n> -\t\tmy $our_TZ = get_tz_offset();\n> +\t\tmy $our_TZ = get_tz_offset($epoch_in_UTC);\n>  \n>  \t\t# This converts $epoch_in_UTC into our local timezone.\n>  \t\tmy ($sec, $min, $hour, $mday, $mon, $year,\n"},{"id":"325779","messageId":"20170808024239.GA2915@starla","threadId":"46516","inReplyTo":"xmqqlgmvni8x.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2017-08-08T02:42:39Z","receivedAt":"2017-08-08T02:42:50Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano <gitster@pobox.com> wrote:\n> Urs Thuermann <urs@isnogud.escape.de> writes:\n> \n> > In parse_svn_date() prepend the correct UTC offset to the timestamp\n> > returned.  This is the offset in effect at the commit time instead of\n> > the offset in effect at calling time.\n> >\n> > Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>\n> > ---\n> >  perl/Git/SVN.pm | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> Thanks; sounds sensible.  \n> \n> Eric?\n\nYep, seems alright.  Can you apply directly?\nBeen a bit preoccupied as of late.  Thanks.\n"},{"id":"325814","messageId":"xmqqfud2c80z.fsf@gitster.mtv.corp.google.com","threadId":"46516","inReplyTo":"20170808024239.GA2915@starla","subject":"Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-08-08T16:57:00Z","receivedAt":"2017-08-08T16:57:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong <e@80x24.org> writes:\n\n> Junio C Hamano <gitster@pobox.com> wrote:\n>> Urs Thuermann <urs@isnogud.escape.de> writes:\n>> \n>> > In parse_svn_date() prepend the correct UTC offset to the timestamp\n>> > returned.  This is the offset in effect at the commit time instead of\n>> > the offset in effect at calling time.\n>> >\n>> > Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>\n>> > ---\n>> >  perl/Git/SVN.pm | 2 +-\n>> >  1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> Thanks; sounds sensible.  \n>> \n>> Eric?\n>\n> Yep, seems alright.  Can you apply directly?\n> Been a bit preoccupied as of late.  Thanks.\n\nSurely, I'll just add your Reviewed-by: myself ;-)\n\nThanks.\n"},{"id":"325830","messageId":"ygfinhxzy55.fsf@tehran.isnogud.escape.de","threadId":"46516","inReplyTo":"xmqqfud2c80z.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime","fromName":"Urs Thuermann","fromEmail":"urs@isnogud.escape.de","sentAt":"2017-08-08T18:56:38Z","receivedAt":"2017-08-08T19:00:15Z","isPatch":true,"sender":{"key":"urs@isnogud.escape.de","avatar":"https://avatars.githubusercontent.com/u/11499339?v=4"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> > Yep, seems alright.  Can you apply directly?\n> > Been a bit preoccupied as of late.  Thanks.\n> \n> Surely, I'll just add your Reviewed-by: myself ;-)\n\nOK, thanks.  This will fix the bug I've reported here a week or so ago\n(see the References header).\n\nurs\n"}]}