{"thread":{"id":"46479","subject":"[PATCH] doc: remove unsupported parameter from patch-id","startedAt":"2017-07-27T22:54:33Z","lastAt":"2017-07-28T00:55:39Z","messageCount":2,"participants":["Andreas Heiduk","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"325210","messageId":"20170727224616.7216-1-asheiduk@gmail.com","threadId":"46479","inReplyTo":null,"subject":"[PATCH] doc: remove unsupported parameter from patch-id","fromName":"Andreas Heiduk","fromEmail":"asheiduk@gmail.com","sentAt":"2017-07-27T22:46:16Z","receivedAt":"2017-07-27T22:54:33Z","isPatch":true,"sender":{"key":"asheiduk@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9371344?v=4"},"body":"The patch is read from standard input and not from a parameter.\n\nSigned-off-by: Andreas Heiduk <asheiduk@gmail.com>\n---\n Documentation/git-patch-id.txt | 3 ---\n 1 file changed, 3 deletions(-)\n\ndiff --git a/Documentation/git-patch-id.txt b/Documentation/git-patch-id.txt\nindex cf71fba1c..442caff8a 100644\n--- a/Documentation/git-patch-id.txt\n+++ b/Documentation/git-patch-id.txt\n@@ -56,9 +56,6 @@ OPTIONS\n \n \tThis is the default.\n \n-<patch>::\n-\tThe diff to create the ID of.\n-\n GIT\n ---\n Part of the linkgit:git[1] suite\n-- \n2.13.3\n\n"},{"id":"325213","messageId":"20170728005532.5q5x2ur5alu2pora@sigill.intra.peff.net","threadId":"46479","inReplyTo":"20170727224616.7216-1-asheiduk@gmail.com","subject":"Re: [PATCH] doc: remove unsupported parameter from patch-id","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-07-28T00:55:32Z","receivedAt":"2017-07-28T00:55:39Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jul 28, 2017 at 12:46:16AM +0200, Andreas Heiduk wrote:\n\n> The patch is read from standard input and not from a parameter.\n> \n> Signed-off-by: Andreas Heiduk <asheiduk@gmail.com>\n> ---\n>  Documentation/git-patch-id.txt | 3 ---\n>  1 file changed, 3 deletions(-)\n> \n> diff --git a/Documentation/git-patch-id.txt b/Documentation/git-patch-id.txt\n> index cf71fba1c..442caff8a 100644\n> --- a/Documentation/git-patch-id.txt\n> +++ b/Documentation/git-patch-id.txt\n> @@ -56,9 +56,6 @@ OPTIONS\n>  \n>  \tThis is the default.\n>  \n> -<patch>::\n> -\tThe diff to create the ID of.\n> -\n\nHeh, I think this is a leftover from 33e8fc874 (usage: do not insist\nthat standard input must come from a file, 2015-10-16).\n\nBefore then, the usage at the top said something like:\n\n  git patch-id < <patch>\n\nand this \"parameter\" made sense. But after, we just talk about stdin in\nthe text, and mentioning \"<patch>\" is simply confusing.\n\nI looked through the other documentation touched by 33e8fc874 to see if\nthere were other cases of this same problem, but I think this is the\nonly one.\n\n-Peff\n"}]}