{"thread":{"id":"46471","subject":"[PATCH] fsck: cleanup unused variable","startedAt":"2017-07-26T01:35:08Z","lastAt":"2017-07-26T13:17:36Z","messageCount":2,"participants":["Jonathan Tan","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"325110","messageId":"20170726013456.4187-1-jonathantanmy@google.com","threadId":"46471","inReplyTo":null,"subject":"[PATCH] fsck: cleanup unused variable","fromName":"Jonathan Tan","fromEmail":"jonathantanmy@google.com","sentAt":"2017-07-26T01:34:56Z","receivedAt":"2017-07-26T01:35:08Z","isPatch":true,"sender":{"key":"jonathantanmy@fastmail.com","avatar":null},"body":"Remove the unused variable \"heads\" from cmd_fsck().\n\nThis variable was made unused in commit c3271a0 (\"fsck: do not fallback\n\"git fsck <bogus>\" to \"git fsck\"\", 2017-01-17).\n\nSigned-off-by: Jonathan Tan <jonathantanmy@google.com>\n---\nWhile working on fsck, I noticed one more possible cleanup.\n---\n builtin/fsck.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)\n\ndiff --git a/builtin/fsck.c b/builtin/fsck.c\nindex 99dea7adf..cc5a5cfab 100644\n--- a/builtin/fsck.c\n+++ b/builtin/fsck.c\n@@ -667,7 +667,7 @@ static struct option fsck_opts[] = {\n \n int cmd_fsck(int argc, const char **argv, const char *prefix)\n {\n-\tint i, heads;\n+\tint i;\n \tstruct alternate_object_database *alt;\n \n \terrors_found = 0;\n@@ -735,7 +735,6 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)\n \t\t}\n \t}\n \n-\theads = 0;\n \tfor (i = 0; i < argc; i++) {\n \t\tconst char *arg = argv[i];\n \t\tunsigned char sha1[20];\n@@ -753,7 +752,6 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)\n \t\t\t\tadd_decoration(fsck_walk_options.object_names,\n \t\t\t\t\tobj, xstrdup(arg));\n \t\t\tmark_object_reachable(obj);\n-\t\t\theads++;\n \t\t\tcontinue;\n \t\t}\n \t\terror(\"invalid parameter: expected sha1, got '%s'\", arg);\n-- \n2.14.0.rc0.400.g1c36432dff-goog\n\n"},{"id":"325123","messageId":"20170726131729.o6bp2qmlqpl674zt@sigill.intra.peff.net","threadId":"46471","inReplyTo":"20170726013456.4187-1-jonathantanmy@google.com","subject":"Re: [PATCH] fsck: cleanup unused variable","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-07-26T13:17:29Z","receivedAt":"2017-07-26T13:17:36Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Jul 25, 2017 at 06:34:56PM -0700, Jonathan Tan wrote:\n\n> Remove the unused variable \"heads\" from cmd_fsck().\n> \n> This variable was made unused in commit c3271a0 (\"fsck: do not fallback\n> \"git fsck <bogus>\" to \"git fsck\"\", 2017-01-17).\n\nThanks, I should have caught this then.\n\nThe patch is obviously correct, though I'm curious why gcc's\n-Wunused-but-set-variable didn't catch this.\n\n-Peff\n"}]}